KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 67 - Still Unstable!

2017-09-04 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/67/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 05 Sep 2017 02:25:19 + Build duration: 13 min and counting JUnit Tests

D7491: Fix invalid id in viewitem.

2017-09-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7491 To: xuetianweng, mart, #plasma, davidedmundson Cc: #frameworks

D7491: Fix invalid id in viewitem.

2017-09-04 Thread Xuetian Weng
xuetianweng added reviewers: Plasma, davidedmundson. xuetianweng added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7491 To: xuetianweng, mart, #plasma, davidedmundson Cc: #frameworks

D7668: Add Tags browser places item to Dolphin and file pickers by default if Baloo is enabled

2017-09-04 Thread Nathaniel Graham
ngraham edited the test plan for this revision. ngraham added a reviewer: aacid. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7668 To: ngraham, #frameworks, #dolphin, dfaure, davidedmundson, ltoscano, broulik, elvisangelaccio, aacid Cc: elvisangelaccio, cfeck, navarromor

D7270: [FileUndoManager] Enable undoing changes in read-only folders

2017-09-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 19183. chinmoyr added a comment. I cannot think of any good reason as to why anyone would want to disable undo. So, removing the checks. As of now copying from a locked folder is not supported. So your example file operation is not possible. CHANGES S

D7648: Fix ksysguard not starting on plasmoid click

2017-09-04 Thread David Edmundson
davidedmundson added a comment. We have a slight problem (and I'm sorry as this is my fault) Plasma 5.10 will depend on frameworks 5.38. This was just tagged and doesn't include your krun change. If this was a feature I would be really strict and make us wait till Plasma 5.11.

D7676: Added openService() method to KRunProxy

2017-09-04 Thread Kai Uwe Broulik
broulik added a comment. Well it is now "openService" calling "runApplication", that's inconsistent isn't it REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D7676 To: maxrd2, davidedmundson Cc: broulik, #frameworks

D7676: Added openService() method to KRunProxy

2017-09-04 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R296:a6d341f817c8: Added openService() method to KRunProxy (authored by maxrd2, committed by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7676?vs

D6833: Add support for PrivilegeExecution in KIO jobs

2017-09-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 19178. chinmoyr added a comment. - Made method const - Removed unnecessary new line CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6833?vs=18019&id=19178 REVISION DETAIL https://phabricator.kde.org/D6833 AFFECTED FILES src/core/chmodjob.

D7676: Added openService() method to KRunProxy

2017-09-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH runproxy_openservice REVISION DETAIL https://phabricator.kde.org/D7676 To: maxrd2, davidedmundson Cc: broulik, #frameworks

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 39 - Fixed!

2017-09-04 Thread no-reply
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Mon, 04 Sep 2017 16:21:38 + Build duration: 10 min and counting JUnit Tests Name:

D7676: Added openService() method to KRunProxy

2017-09-04 Thread Mladen Milinkovic
maxrd2 updated this revision to Diff 19173. maxrd2 marked an inline comment as done. maxrd2 added a comment. Removed service->isApplication() check, improved method description. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7676?vs=19138&id=19173 BRA

KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 38 - Unstable!

2017-09-04 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Mon, 04 Sep 2017 15:56:58 + Build duration: 12 min and counting JUnit Tests Name:

D6831: Make use of kauth helper in methods of file ioslave

2017-09-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 19170. chinmoyr added a comment. - ret -> err - used tryOpen @dfaure shall i merge https://phabricator.kde.org/D6830 & https://phabricator.kde.org/D6831 into a single commit? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6831?vs=18697&i

D6047: Support XDG v6

2017-09-04 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R127:d4c82b60cf16: Support XDG v6 (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6047?vs=19148&id=19169#toc REPOSITORY

D6830: Make use of kauth helper in copy method of file ioslave

2017-09-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 19167. chinmoyr added a comment. removedextra semi-colon CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6830?vs=19166&id=19167 REVISION DETAIL https://phabricator.kde.org/D6830 AFFECTED FILES src/ioslaves/file/file.h src/ioslaves/file/fi

D6830: Make use of kauth helper in copy method of file ioslave

2017-09-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 19166. chinmoyr added a comment. - Added method tryOpen - Ensured correct permissions are set on the newly created file. - auto ret -> auto err - There's no method like failed() in PrivOpReturnValue. We have to leave those calls as they are. CHANG

D6047: Support XDG v6

2017-09-04 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH temp REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma, graesslin Cc: graesslin, mart, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, prog

D7580: Support loading by stream and restoring state on reload

2017-09-04 Thread Friedrich W . H . Kossebau
kossebau marked an inline comment as done. kossebau added a comment. In https://phabricator.kde.org/D7580#142891, @dfaure wrote: > Oops, yes, you're completely right. I got distracted by the word close, but it's a different meaning in closeStream and closeUrl. Apologies for the confusion

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 76 - Still Unstable!

2017-09-04 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/76/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Mon, 04 Sep 2017 11:26:05 + Build duration: 1 min 22 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 72 - Still Unstable!

2017-09-04 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/72/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 04 Sep 2017 11:26:13 + Build duration: 51 sec and counting JUnit Tests Nam

D7675: doc: validation not available in QInputDialog::getText

2017-09-04 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R239:0f7d924b9979: doc: validation not available in QInputDialog::getText (authored by ltoscano). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7675?vs=19132&id

D7194: Detach before setting the d pointer

2017-09-04 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R304:04cc49c71bdb: Detach before setting the d pointer (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7194?vs=17863&id=19155 REVISION DETAIL htt

D7190: Don't complain the knsregistry file is not present before it's useful

2017-09-04 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R304:c381ed0a1758: Don't complain the knsregistry file is not present before it's useful (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7190?vs=178

D6047: Support XDG v6

2017-09-04 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_interface.cpp:40 > the captured "attempt" variable is modified inside the lambda needs to tack the state as needs to track that only a couple of attempts are made REPOSITORY R127 KWayland REVISION DETAIL https:

D7448: generate and use a local cdda_interface headerfile copy

2017-09-04 Thread René J . V . Bertin
rjvbb added a comment. Not by me in any case, but I didn't exactly "invent" the fix, it must have been around for long enough to be upstreamed. Is cdparanoia even being maintained? REPOSITORY R342 KIO AudioCD REVISION DETAIL https://phabricator.kde.org/D7448 To: rjvbb, #frameworks, dfa