dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R239 KDELibs4Support
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7675
To: ltoscano, cfeck, dfaure
Cc: #frameworks
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Has this been reported upstream, so the cdda people can fix it properly?
REPOSITORY
R342 KIO AudioCD
REVISION DETAIL
https://phabricator.kde.org/D7448
To: rjvbb, #frameworks, dfaure
Cc
On dimanche 3 septembre 2017 14:28:44 CEST no-re...@kde.org wrote:
> BUILD UNSTABLE
> Build
> URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7
> /75/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7
XenialQt5.7/autotests/tst_keynavigation.qml:23:1: module "org.kd
dfaure added a comment.
Oops, yes, you're completely right. I got distracted by the word close, but
it's a different meaning in closeStream and closeUrl. Apologies for the
confusion.
As to existing implementations of this stuff, it just happens that I wrote
one recently, see konqueror.g
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/66/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 04 Sep 2017 02:37:21 +
Build duration:
14 min and counting
JUnit Tests
kossebau edited the summary of this revision.
REPOSITORY
R383 SVGPart
REVISION DETAIL
https://phabricator.kde.org/D7580
To: kossebau, #frameworks, dfaure
kossebau added a comment.
> As I see it, it's *either* openUrl/closeUrl *or*
openStream/writeStream/closeStream.
Hm, when I before did a quick search for how to use the stream API, I came
across
https://api.kde.org/frameworks/khtml/html/classKHTMLPart.html#details
which made me think
ngraham added a comment.
Any remaining objections or requested changes?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio
Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano,
#
davidedmundson updated this revision to Diff 19148.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Rename grab signal
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/44/
Project:
Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7
Date of build:
Sun, 03 Sep 2017 17:26:15 +
Build duration:
1 min 57 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/53/
Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Sep 2017 17:26:15 +
Build duration:
1 min 38 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:8b4033f16c2a: Fix python bindings compilation after
7af93dd23873d0b9cdbac192949e7e5114940aa6 (authored by arojas).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator
vkrause added a task: T6711: Support translations.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7680
To: vkrause, #frameworks
vkrause created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7680
AFFECTED FILES
CMakeLists.txt
To: vkrause, #frameworks
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks for the fix!
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7677
To: arojas, dfaure, skelly
Cc: #frameworks, #build_system
ngraham marked an inline comment as done.
ngraham added a comment.
The latest change should take care of that concern; I changed the `#ifdef`to
`if (KProtocolInfo::isKnownProtocol(QStringLiteral("tags")))`, which should
cover the case where Baloo was disabled after compilation but before Dolp
vkrause added a task: T6924: Fix KF5 compilation without X11.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7678
To: vkrause, #frameworks
vkrause added a task: T6924: Fix KF5 compilation without X11.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D6992
To: vkrause, #frameworks, bshah, graesslin
Cc: dfaure, graesslin, bshah
vkrause created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R303 KInit
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7678
AFFECTED FILES
src/wrapper.cpp
To: vkrause, #frameworks
maxrd2 added a comment.
I don't have full developer account so i can't land this one. It also needs
https://phabricator.kde.org/D7676 for this to work.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmun
arojas created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Explicitely set LIBRARY_OUTPUT_DIRECTORY for the python module
TEST PLAN
kcoreaddons python bindings are correctl
maxrd2 added inline comments.
INLINE COMMENTS
> krunproxy.cpp:48
> KService::Ptr service = KService::serviceByDesktopPath(filePath);
> return KRun::runService(*service, QList(), nullptr) != 0;
> } else {
While I'm at it should i also change to runApplication() here?
> kru
maxrd2 added a dependency: D7676: Added openService() method to KRunProxy.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai
maxrd2 added a dependent revision: D7648: Fix ksysguard not starting on
plasmoid click.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
maxrd2 added a comment.
Am not sure whether if( && service->isApplication()) is needed.
While I'm at it should i replace runService() with runApplication() inside
inside openUrl() method?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2,
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolf
maxrd2 updated this revision to Diff 19138.
maxrd2 added a comment.
Replaced runService() call with runApplication()
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7676?vs=19137&id=19138
BRANCH
runproxy_openservice
REVISION DETAIL
https://phabric
broulik added a comment.
Use `runApplication` for running applications which doesn't block until the
app has registered a DBus service
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: broulik, #frameworks
maxrd2 added a comment.
There it goes... updated the qml and added KRunProxy changes here:
https://phabricator.kde.org/D7676
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwo
maxrd2 added a reviewer: davidedmundson.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D7676
To: maxrd2, davidedmundson
Cc: #frameworks
maxrd2 created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Added openService() method to KRunProxy so plasmoids can start applications
without needing to use openUrl() and "apps" data source.
REPOSIT
ltoscano added a comment.
In https://phabricator.kde.org/D7668#142505, @ngraham wrote:
> Oh good point, I forgot that this won't work if Baloo is disabled. I'll
guard it behind an #ifdef, which appears to be the standard way to do this,
looking through Dolphin's code.
>
> Since I'm p
maxrd2 updated this revision to Diff 19136.
maxrd2 added a comment.
Plasmoid uses KRun::openService() to launch ksysguard
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7648?vs=19134&id=19136
BRANCH
launch-change
REVISION DETAIL
https://phabrica
maxrd2 updated this revision to Diff 19134.
maxrd2 edited the summary of this revision.
maxrd2 added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Added KRun::openService() method
REPOSITORY
R296 KDeclarative
CHANGES SI
ngraham updated this revision to Diff 19135.
ngraham added a comment.
Used a different mechanism for gating this code on Baloo being active.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7668?vs=19112&id=19135
REVISION DETAIL
https://phabricator.kde.org/D76
ngraham added a comment.
In https://phabricator.kde.org/D7668#142562, @elvisangelaccio wrote:
> Note that this only works if there are no custom places yet (probably not a
big deal).
Yes, the idea here is to change the default setting for new installs, and
this code is only run t
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
KInputDialog::getText, by default, does not accept an empty value
and accepts a QValidator. QInputDialog::getText does not, so the
retur
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in xdgshell_interface.cpp:40
> what's the idea behind a mutable lambda?
the captured "attempt" variable is modified inside the lambda
REPOSITORY
R127 KWayland
REVISION DET
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/75/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Sun, 03 Sep 2017 12:27:37 +
Build duration:
1 min 7 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/71/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Sep 2017 12:27:37 +
Build duration:
42 sec and counting
JUnit Tests
Nam
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20WindowsMSVCQt5.9/5/
Project:
Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:42:02 +
Build duration:
40 min and counting
build.log
D
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20WindowsMSVCQt5.9/6/
Project:
Frameworks kinit kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:42:02 +
Build duration:
38 min and counting
build.log
Description: Bina
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20WindowsMSVCQt5.9/4/
Project:
Frameworks kdewebkit kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:58 +
Build duration:
34 min and counting
build.log
Descripti
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.9/6/
Project:
Frameworks baloo kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:56 +
Build duration:
23 min and counting
build.log
Description: Bina
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/29/
Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Sep 2017 09:58:52 +
Build duration:
2 min 54 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/4/
Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:52 +
Build duration:
20 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:5e75d6552ca1: Add apidox to
KStandardShorcut::StandardShortcut (authored by elvisangelaccio).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7605?vs=18926&id=19120
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.9/4/
Project:
Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:51 +
Build duration:
16 min and counting
JUnit T
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.9/5/
Project:
Frameworks kparts kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:50 +
Build duration:
11 min and counting
JUnit Tests
N
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20WindowsMSVCQt5.9/5/
Project:
Frameworks kross kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:49 +
Build duration:
8 min 10 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.9/7/
Project:
Frameworks krunner kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:47 +
Build duration:
6 min 12 sec and counting
JUnit Test
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/27/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Sep 2017 09:41:48 +
Build duration:
2 min 44 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20WindowsMSVCQt5.9/4/
Project:
Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 03 Sep 2017 09:41:47 +
Build duration:
2 min 45 sec and counting
dfaure requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7534
To: broulik, kde-frameworks-devel, dfaure
Cc: #frameworks
dfaure added a comment.
Maybe it would be safer/simpler to use a different QObject for watching the
menus.
INLINE COMMENTS
> kurlnavigator.cpp:365
> QPointer popup = new QMenu(q);
> +popup->installEventFilter(q);
> popup->setLayoutDirection(Qt::LeftToRight);
Warning, that even
dfaure added inline comments.
INLINE COMMENTS
> svgpart.cpp:118
> +mStreamedData.clear();
> +mItem = new QGraphicsSvgItem();
> +mItem->setSharedRenderer(mRenderer);
Shouldn't mItem be deleted first?
You seem to rely on closeUrl() being called before the next openStream, but I
don't
dfaure added a comment.
(strange that Phabricator still says "Needs Review" when this has two
approvals)
REVISION DETAIL
https://phabricator.kde.org/D6197
To: chinmoyr, elvisangelaccio, #frameworks, dfaure
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> sharefd.cpp:32
> +
> +//borrowed from klocalsocket.cpp
> +class KSockaddrUn
Either move it to a common header (if QString everywhere is OK), or use a
differe
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
Note that this only works if there are no custom places yet (probably not a
big deal).
INLINE COMMENTS
> kfileplacesmodel.cpp:110
>
dfaure added a comment.
Also please improve the commit log to be more self contained (unit tests for
what? And "https://phabricator.kde.org/T6561"; will mean nothing to someone
doing `git log`).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7430
To: chinmoyr, dfaure
dfaure added a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7430
To: chinmoyr, dfaure
Cc: #frameworks
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kprotocolmanager.h:479
> + */
> +static bool supportsPrivilegeExecution(const QUrl &url);
> +
Missing @since 5.39
BRANCH
master
REVISION DETAIL
https://ph
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7605
To: elvisangelaccio, #frameworks, dfaure
graesslin added inline comments.
INLINE COMMENTS
> xdgshell_interface.cpp:40
> +int attempt = 0;
> +connect(pingTimer, &QTimer::timeout, q, [this, serial, attempt]()
> mutable {
> +++attempt;
what's the idea behind a mutable lambda?
> xdgshell_interface.h:458
> + */
> +
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good, just some minor things.
INLINE COMMENTS
> privilegejobtest.cpp:37
> +#define KIO_JOB_FLAGS KIO::HideProgressInfo | KIO::PrivilegeExecution
> +#define LOCALFILE(x) QUrl
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Please use `arc diff` to upload patches so that context is available.
m_now isn't used to detect changes, but to detect files "in the future".
With your changes, the line if
66 matches
Mail list logo
