Re: relocatable kdoctools

2017-08-30 Thread Ralf Habacker
Am 29.08.2017 um 14:16 schrieb Harald Sitter: > On Thu, Aug 24, 2017 at 3:20 PM, Ralf Habacker > wrote: >> 10. The conclusion of 9. is that it might also be a solution on windows >> to patch only all generated files after 3. and before 4. > Hm, I may be missing a piece of the puzzle in my mind, b

Re: relocatable kdoctools

2017-08-30 Thread Ralf Habacker
Am 29.08.2017 um 15:03 schrieb Harald Sitter: > On Sun, Aug 27, 2017 at 8:37 PM, Luigi Toscano > wrote: >> Even without the if branch it would be still complicated. > Ah! I think I get the complexity now. At build time we need to run our > tools already and so the dtd/xsl need to be able to resol

D7620: Fix KHelpMenu position on Wayland

2017-08-30 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7620 To: elvisangelaccio, #frameworks, davidedmundson, graesslin

D7461: Add syntax highlighting for AppArmor Profiles.

2017-08-30 Thread Nibaldo González
nibags updated this revision to Diff 18983. nibags added a comment. - Updated AppArmor syntax highlighting file: 1. Updating https://phabricator.kde.org/D7461: Add syntax highlighting for AppArmor Profiles. # Updated AppArmor syntax highlighting file. Hi! Sorry for the delay, I'

Re: Retirement of Reviewboard - Transition to Phabricator

2017-08-30 Thread Ben Cooksley
On 25/08/2017 5:41 AM, "Albert Astals Cid" wrote: El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va escriure: > Hi all, > > The following is Sysadmin's suggested plan for the retirement of > Reviewboard now that Phabricator is fully up and running for hosting > of code reviews.

Re: Retirement of Reviewboard - Transition to Phabricator

2017-08-30 Thread Ben Cooksley
On Mon, Aug 28, 2017 at 8:20 PM, René J.V. Bertin wrote: > On Friday August 25 2017 07:33:43 Ben Cooksley wrote: > > Hi, Hi Rene, > >>> Note that due to how Reviewboard stores diffs and reproduces them for >>> use, some reviews may have decayed and may no longer be readable. This >>> is due to s

Re: Retirement of Reviewboard - Transition to Phabricator

2017-08-30 Thread René J . V . Bertin
On Friday August 25 2017 07:33:43 Ben Cooksley wrote: Hi, >> Note that due to how Reviewboard stores diffs and reproduces them for >> use, some reviews may have decayed and may no longer be readable. This >> is due to short-hashes which are used by Git/Reviewboard in diffs now >> having collision

Re: Retirement of Reviewboard - Transition to Phabricator

2017-08-30 Thread Albert Astals Cid
El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va escriure: > Hi all, > > The following is Sysadmin's suggested plan for the retirement of > Reviewboard now that Phabricator is fully up and running for hosting > of code reviews. > > Phase 1: Commences September 2: All repositori

D7620: Fix KHelpMenu position on Wayland

2017-08-30 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This fixes the transient parent of KHelpMenu, which is required to properly position the popup on Wayland. TEST PLAN open Help menu from dolphin Control button. REPOSITORY R263 KXm

D7620: Fix KHelpMenu position on Wayland

2017-08-30 Thread Luigi Toscano
ltoscano added a reviewer: davidedmundson. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D7620 To: elvisangelaccio, #frameworks, davidedmundson

D7620: Fix KHelpMenu position on Wayland

2017-08-30 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D7620 To: elvisangelaccio, #frameworks

D6767: simplify setContents by letting Qt do more of the work

2017-08-30 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R236:c0b452358397: simplify setContents by letting Qt do more of the work (authored by sitter). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6767?vs=16865&id=18

Re: Review Request 129381: kconfig fix kconfigskeletontest

2017-08-30 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129381/ --- (Updated Aug. 30, 2017, 4:08 p.m.) Status -- This change has been di

D7584: [Icon Item] Don't needlessly unset imagePath

2017-08-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a96330292646: [Icon Item] Don't needlessly unset imagePath (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7584?vs=18882&id

D7602: [ConfigModel] Allow programmatically adding and removing ConfigCategory

2017-08-30 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7602 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D7601: [EventPluginsManager] Expose pluginPath in model

2017-08-30 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7601 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a

D6767: simplify setContents by letting Qt do more of the work

2017-08-30 Thread Christoph Feck
cfeck accepted this revision. cfeck added a comment. Could you please commit this to land in 5.38? REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6767 To: sitter, cfeck, davidedmundson Cc: davidedmundson, #frameworks

D7584: [Icon Item] Don't needlessly unset imagePath

2017-08-30 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7584 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliez

D7584: [Icon Item] Don't needlessly unset imagePath

2017-08-30 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in iconitem.cpp:199 > are you saying we'll always hit this one? If we use plasma theme and have valid icon (line 176 does set image path and 181 checks for validity if plasmatheme). If we dont have a plasma theme or failedto

D7584: [Icon Item] Don't needlessly unset imagePath

2017-08-30 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > iconitem.cpp:199 > if (!iconPath.isEmpty()) { > m_svgIcon->setImagePath(iconPath); > m_svgIconName = sourceString; are you saying we'll always hit this one? REPOSITORY R242 Plasm

D7614: [FrameSvg] Use QPixmap::mask() instead of deprecated convoluted way via alphaChannel()

2017-08-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:5921b2a70ced: [FrameSvg] Use QPixmap::mask() instead of deprecated convoluted way via… (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricat

D7614: [FrameSvg] Use QPixmap::mask() instead of deprecated convoluted way via alphaChannel()

2017-08-30 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7614 To: broulik, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed

D7614: [FrameSvg] Use QPixmap::mask() instead of deprecated convoluted way via alphaChannel()

2017-08-30 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QPixmap::alphaChannel() is deprecated. TEST PLAN Corners of popups still nicely rounded (tested with Oxygen which has

D7460: Treat input RGB buffers as premultiplied

2017-08-30 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:dc7e367ecfe0: Treat input RGB buffers as premultiplied (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7460?vs=18530&id=18950 REVISIO

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

2017-08-30 Thread David Faure
dfaure added a comment. Patch for more docu: https://phabricator.kde.org/D7612 BTW CMAKE_LIBRARY_OUTPUT_DIRECTORY is not undocumented, it's part of the cmake documentation: Where to put all the :ref:`LIBRARY ` target files when built. This variable is used to initializ

D7612: KDECMakeSettings: more docu about the layout of the build dir

2017-08-30 Thread David Faure
dfaure created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7612 AFFECTED FILES kde-modules/KDECMake