bshah added a comment.
In https://phabricator.kde.org/D7533#140680, @dfaure wrote:
> Ah, phabricator is strange, I have indeed modified the commit log before
doing `arc diff` but it didn't update it here.
And it also did overwrite your change in actual commit message it seems
*sh
kossebau created this revision.
REVISION SUMMARY
The KTextEditor preview plugin* repeatedly feeds new
versions to the same kpart instance, to allow instant
preview of changes. To avoid stressing of the filesystem
the stream API of the kpart is used if available.
*https://frinring.wordpre
ngraham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: ngraham, #dolphin, #kde_applications
Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano,
#konqueror, navarromorales, firef, andrebarros, emmanue
ngraham updated this revision to Diff 18867.
ngraham added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
This update implements the following requested changes:
1. Located after Home bookmark and before Trash bookmark
ltoscano added inline comments.
INLINE COMMENTS
> CMakeLists.txt:84
> set(kio_audiocd_PART_SRCS audiocd.cpp )
> +ecm_qt_declare_logging_category(kio_audiocd_PART_SRCS HEADER logging.h
> IDENTIFIER AUDIOCD CATEGORY_NAME kf5.kio.audiocd)
>
I would follow a bit more the (unwritten, but used) co
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/14/
Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 27 Aug 2017 21:18:44 +
Build duration:
6 min 5 sec and counting
CONSOLE OUTPUT
mwolff accepted this revision.
This revision is now accepted and ready to land.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7530
To: dfaure, mwolff
Cc: #frameworks
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
lgtm, despite the `delete this`:
https://isocpp.org/wiki/faq/freestore-mgmt#delete-this, esp. if you have proper
unit tests and ran it through valgrind
REPOSITORY
R241 KIO
BRANCH
mast
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/13/
Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 27 Aug 2017 20:23:18 +
Build duration:
4 min 1 sec and counting
CONSOLE OUTPUT
mwolff added a comment.
In https://phabricator.kde.org/D7527#139670, @dfaure wrote:
> Almost perfect ;-)
Indeed, should have reviewed it closer myself. Fixed and pushed - thanks for
the review David!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7527
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1a92575c73d2: Add mimetype filtering capabilities to
KUrlCompletion (authored by mwolff).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7527?vs=18718&id=18861#toc
REPOSITORY
R241 KIO
CHANG
dfaure closed this revision.
REVISION DETAIL
https://phabricator.kde.org/D7533
To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: vandenoever, elvisangelaccio, bshah, #frameworks
dfaure added a comment.
Ah, phabricator is strange, I have indeed modified the commit log before
doing `arc diff` but it didn't update it here.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7533
To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: vandenoever, elvisange
Harald Sitter wrote:
> On Tue, Aug 22, 2017 at 10:18 PM, Luigi Toscano
> wrote:
>> Harald Sitter wrote:
>>> The reason this puzzles me is that the relocatable code for Windows
>>> would work just fine for Linux and OSX, from what I can tell there is
>>> no real downside to it besides the addition
This revision was automatically updated to reflect the committed changes.
Closed by commit R303:1ebdf8ea6ac1: klauncher: fix appId matching for flatpak
apps (authored by elvisangelaccio).
REPOSITORY
R303 KInit
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7479?vs=18758&id=18856
REV
cgilles added a comment.
I don't yet tested, i'm currently busy to prepare digiKam 5.7.0, to review
last code from GSoC 2017 students, and to prepare Randa event tasks.
Do you come to Randa ? If yes, we can take a look together while the event...
Gilles
REPOSITORY
R245 Solid
REVI
rjvbb added a comment.
I can commit it anytime, as soon as I get a green light (within a reasonable
amount of time). Have you tested it?
I expect that the only possible risk with these modifications is that they
might break the build itself on newer OS versions than I have myself. Other
chinmoyr added a dependent revision: D7571: Enable modifying root-owned files
in Dolphin.
REVISION DETAIL
https://phabricator.kde.org/D7563
To: chinmoyr, #frameworks, dfaure
Cc: elvisangelaccio
cgilles added a comment.
Rene, this is a great improvement for MacOS support. Congratualtions.
When code will be add to KDE::Solid framework ?
Best
Gilles Caulier
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D7401
To: rjvbb, #frameworks
Cc: cgilles, kd
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.9/9/
Project:
Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 27 Aug 2017 10:28:29 +
Build duration:
7 min 18 sec and cou
bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.
Looks good to me.
(Maybe modify the commit message to remove the priority int/string bits)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7533
To: dfaure, apol, davidedm
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/83/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 27 Aug 2017 10:02:55 +
Build duration:
1 min 37 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b3d7d9cd02f6: Add highlight definition for Tiger
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7484?vs=18664&id=18837
REVISION
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/17/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sun, 27 Aug 2017 07:57:29 +
Build duration:
2 min 36 sec and counting
JUnit Te
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/58/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 27 Aug 2017 07:57:29 +
Build duration:
34 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/62/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Sun, 27 Aug 2017 07:57:29 +
Build duration:
1 min 1 sec and counting
JUnit Tests
26 matches
Mail list logo
