turbov added reviewers: dhaumann, Kate, Framework: Syntax Hightlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7175
To: turbov, dhaumann, #kate, #framework_syntax_hightlighting
Cc: #frameworks
turbov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
CMake syntax has been redesigned to pursue the following goals:
- the former generator has used an output of `cmake --help` (and friends)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/48/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 07 Aug 2017 02:48:21 +
Build duration:
18 min and counting
JUnit Tests
apol added inline comments.
INLINE COMMENTS
> desktopfileparser.cpp:213
> QByteArray type;
> +const static QRegularExpression typeEntryRegex(
> +QStringLiteral("^Type\\s*=\\s*(.*)$"));
Wrong scope?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D7169
To: mpyne, #frameworks, apol
Cc: cfeck
mpyne created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
As reported in bug 310674, the Desktop Entry spec says that whitespace
surrounding the = sign that separates the key and value in .desktop files
should be ignored when interpreting the key and val
cfeck added a comment.
That also trims trailing spaces in value ...
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D7169
To: mpyne, #frameworks
Cc: cfeck
mpyne created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
As reported in bug 310674, the Desktop Entry spec says that whitespace
surrounding the `=` sign that separates the key and value in .desktop files
should be ignored when interpreting the key and v
carewolf closed this revision.
carewolf added a comment.
Already landed
REVISION DETAIL
https://phabricator.kde.org/D6895
To: carewolf, cullmann
Cc: #frameworks
dhaumann added a reviewer: rkflx.
dhaumann added a comment.
Add Henrik, since he has several patches in the pipe as well...
REVISION DETAIL
https://phabricator.kde.org/D7010
To: brauch, cfeck, rkflx
Cc: dhaumann, aacid, #frameworks
dhaumann added a comment.
David just did his tagging work yesterday for KDE Frameworks 5.37:
https://mail.kde.org/pipermail/release-team/2017-August/010528.html
That means the git shas are fixed for the next release, except if some
show-stopper bug in a module forces us to pick another git
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/40/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 21:40:07 +
Build duration:
50 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/35/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 21:40:07 +
Build duration:
35 sec and counting
JUnit Tests
Nam
dhaumann added a comment.
This patch adds four functions that all "reimplement" functions that exist in
base classes.
However, these functions are not virtual. As such, adding the functions is
probably fine (BC), but essentially the correct behavior now depends on calling
the correct funct
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks certainly better than before, thanks a lot.
Mabye the "@note" about some methods being not virtual in the base class is
even worth to put into the main class documentation. Ca
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
A good patch, and adding new non-virtual functions is binary compatible. So
this looks good to me.
INLINE COMMENTS
> ksqueezedtextlabel.h:110
> + * i.e. the original text does not
dhaumann added inline comments.
INLINE COMMENTS
> dhaumann wrote in ksqueezedtextlabelautotest.cpp:217-234
> margin, indent, and lineWidth are all Q_PROPERTYs, maybe you can use
> QObject::setProperty(const char *, QVariant) to set the values instead of
> using a function pointer? The function
dhaumann added a comment.
Looking at your other change requests: You may want to ignore the note about
using setProperty(), since this will call QLabel::setIndent(), and not the one
that you add in KSqueezedTextLabel (since setIndent() etc. are not virtual).
Maybe this needs further discuss
dhaumann added a comment.
I think this is already a very good patch. I just have some minor comments.
Could you have another look?
By the way: Given you have more patches that build on this one, you should
consider applying for a KDE developer account, if you don't have one yet, see:
ht
dfaure added a comment.
Not sure I understand your question. If we agree on using return values then
there is only one way to do that. E.g. chmod() returns 0 on success, so the
code could be like
if (chmod(...) == 0)
return reply;
break;
which jumps to the if (errno)
dfaure added inline comments.
INLINE COMMENTS
> slavebase.h:939
> +/**
> + * Checks with job if privilege operation is allowed.
> + */
missing @since 5.38, BTW
BRANCH
second
REVISION DETAIL
https://phabricator.kde.org/D6829
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
croick created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
- do not pop up menu if the only selectable mark (i.e. bookmark) is not the
default mark for left click on icon border
TEST PLA
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/47/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:58:22 +
Build duration:
1 hr 2 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/20/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:52:16 +
Build duration:
57 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/19/
Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:51:10 +
Build duration:
57 min and counting
JUnit Tests
Name: (root
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/24/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:49:00 +
Build duration:
58 min and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.7/20/
Project:
Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:38:31 +
Build duration:
56 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/16/
Project:
Frameworks kcrash kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:32:33 +
Build duration:
54 min and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/37/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:32:03 +
Build duration:
54 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:30:55 +
Build duration:
55 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/19/
Project:
Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:24:54 +
Build duration:
54 min and counting
JUnit Tests
Nam
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.7/15/
Project:
Frameworks threadweaver kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:23:19 +
Build duration:
52 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/46/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:13:55 +
Build duration:
43 min and counting
JUnit Tests
chinmoyr updated this revision to Diff 17782.
chinmoyr added a comment.
- added 'return'
- fixed some typos
- dest_file.remove() -> QFile::remove(dest). because when working with fd,
dest_file.remove() fails but doesn't set errno to EACCES or EPERM.
- dest_file.setPermissions() -> QFile:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20XenialQt5.7/17/
Project:
Frameworks kpeople kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:50:05 +
Build duration:
2 min 30 sec and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/19/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:49:00 +
Build duration:
2 min 11 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/19/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:12:50 +
Build duration:
31 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks kimageformats kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:42:21 +
Build duration:
1 min 21 sec and counting
JUnit Te
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/18/
Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:11:45 +
Build duration:
28 min and counting
JUnit Tests
Name: (root
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/42/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:32:03 +
Build duration:
6 min 52 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 16:09:31 +
Build duration:
28 min and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/18/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:24:24 +
Build duration:
12 min and counting
JUnit Tests
Name: (root
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in filehelper.cpp:86
> The documentation for chown and others says:
>
> Upon successful completion, these functions shall return 0. Otherwise, these
> functions shall return −1 and set errno to indicate the error.
>
> It does NOT
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20XenialQt5.7/13/
Project:
Frameworks kcrash kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:32:33 +
Build duration:
2 min 28 sec and counting
JUnit Tests
Name
chinmoyr updated this revision to Diff 17781.
chinmoyr added a comment.
- used single quotes
- check for 'UnitTesting' meta-data before showing a prompt.
- removed private header. it was supposed to appear in another commit.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6829?vs=
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/18/
Project:
Frameworks bluez-qt kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:24:54 +
Build duration:
8 min 27 sec and counting
JUnit Tests
chinmoyr updated this revision to Diff 17780.
chinmoyr added a comment.
- Add private header
- minor fixes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=17507&id=17780
BRANCH
first
REVISION DETAIL
https://phabricator.kde.org/D6197
AFFECTED FILES
src/ioslaves/file/
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.7/19/
Project:
Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 15:58:59 +
Build duration:
14 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20XenialQt5.7/16/
Project:
Frameworks kpeople kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:10:39 +
Build duration:
1 min 30 sec and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/18/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:09:31 +
Build duration:
2 min 31 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20FreeBSDQt5.7/9/
Project:
Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 15:55:41 +
Build duration:
8 min 56 sec and counting
JUn
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20XenialQt5.7/7/
Project:
Frameworks kimageformats kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 16:02:51 +
Build duration:
1 min 22 sec and counting
JUnit Te
Present: me, chinmoy
Minutes in the attachment.
Cheers,
Elvis2017-08-06 14:59:49 eangI'm finally here, shall we start the meeting?
2017-08-06 15:00:07 chinmoy[m] eang, i am here
2017-08-06 15:03:58 eangchinmoy: let's start!
2017-08-06 15:04:41 chinmoy[m] ok
2017
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/36/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 15:52:24 +
Build duration:
9 min 13 sec and counting
JUnit Tes
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/15/
Project:
Frameworks kcrash kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 15:52:59 +
Build duration:
7 min 44 sec and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/22/
Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 15:51:16 +
Build duration:
8 min 32 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20XenialQt5.7/9/
Project:
Frameworks kdesignerplugin kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 15:55:41 +
Build duration:
1 min 28 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20XenialQt5.7/12/
Project:
Frameworks kcrash kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 15:52:59 +
Build duration:
1 min 22 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/17/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 15:43:53 +
Build duration:
5 min 33 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/17/
Project:
Frameworks bluez-qt kf5-qt5 XenialQt5.7
Date of build:
Sun, 06 Aug 2017 15:44:27 +
Build duration:
4 min 50 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/18/
Project:
Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 06 Aug 2017 15:44:27 +
Build duration:
3 min 37 sec and counting
JUnit Tests
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> file_unix.cpp:677
> +if (metaData(QStringLiteral("UnitTesting")) == QLatin1String("true")) {
> +const QString metaData = execAction.name() + ","
> +
chinmoyr updated this revision to Diff 17779.
chinmoyr added a comment.
- removed virtual keyword
- added a private header
- minor fixes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6829?vs=17778&id=17779
REVISION DETAIL
https://phabricator.kde.org/D6829
AFFECTED FILES
sr
chinmoyr updated this revision to Diff 17778.
chinmoyr added a comment.
- removed virtual keyword
- added a private header
- minor fixes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6829?vs=17203&id=17778
REVISION DETAIL
https://phabricator.kde.org/D6829
AFFECTED FILES
sr
rkflx edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks
rkflx added a dependent revision: D7162: KSqueezedTextLabel: Add isSqueezed()
for convenience.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7161
To: rkflx, #frameworks
rkflx edited the summary of this revision.
rkflx added a dependency: D7161: KSqueezedTextLabel: Small improvements to API
docs.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks
rkflx added a dependent revision: D6696: Elide cut off text in sidebar header,
remove restricted max width.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7164
To: rkflx, #frameworks
rkflx created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Text could display cut off when setting indent, margin and/or frame of
the label. On top of that, even when following the size hint to display
the complete text, text could be elided.
This
rkflx added a dependent revision: D7164: KSqueezedTextLabel: Respect indent,
margin and frame width.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7163
To: rkflx, #frameworks
rkflx created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Tests most of the basic functionality and uncovers bugs for a few edge
cases. Testing some of the advanced features is skipped for now, there
might be more bugs lurking.
Checking the text e
rkflx added a dependent revision: D7163: KSqueezedTextLabel: Add several
autotests.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks
rkflx created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
More readable than having to check fullText!=text() again and again.
Will be used in upcoming autotests, but should be useful in general.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
ht
rkflx created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Expand description, add missing documentation.
"Above" in source code does not imply "above" in generated API docs,
better use a reference.
TEST PLAN
Output of kapidox looks better.
REPOS
ltoscano added a comment.
In https://phabricator.kde.org/D7130#132425, @gregormi wrote:
> In https://phabricator.kde.org/D7130#132409, @ltoscano wrote:
>
> > Just update the English messages.
> > More generally, why do we need copies of the system desktop files (even
the ones
75 matches
Mail list logo
