dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6685
To: elvisangelaccio, #frameworks, dfaure
dfaure added a comment.
Code looks good to me.
INLINE COMMENTS
> readonlypart.cpp:244
>
> +// TODO KF6: make it non-virtual so that we can just call
> +// closeUrlImpl() + setUrl(QUrl()) and get rid of m_closeUrlFromOpenUrl.
I'm not sure about that TODO, it would be a horrendous porting tr
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:15451d505fdb: Fix build on musl libc by exposing
setgroups(2). (authored by mpyne).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6597?vs=16422&id=17270
REVISION DETA
This revision was automatically updated to reflect the committed changes.
Closed by commit R303:c42f18a7fc1a: Use proper feature flag to include kill(2).
(authored by mpyne).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6598?vs=16423&id=17269#toc
REPOSITORY
R303 KInit
CHANGES SINCE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/38/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 27 Jul 2017 02:53:33 +
Build duration:
11 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R306:089284db0c0d: Add template for a simple kpart-based
application (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6800?vs=16946&id=17264#toc
REPOSITORY
R306 KParts
CHAN
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D6941
To: mkoller, davidedmundson
Cc: #frameworks
mkoller created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
being hit by the problem of plasmashell using way too much CPU even when
doing "nothing", I found
the description of the QSG_RENDER_LOOP e
winterz abandoned this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6936
To: winterz, dfaure
Cc: #frameworks, #build_system
elvisangelaccio abandoned this revision.
elvisangelaccio added a comment.
Moved relevant test case in https://phabricator.kde.org/D6856
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D6889
To: elvisangelaccio, #kate, #kdevelop, dfaure
Cc: #frameworks
elvisangelaccio updated this revision to Diff 17247.
elvisangelaccio added a comment.
- Fix apidox
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6856?vs=17246&id=17247
BRANCH
reset-url-in-closeUrl
REVISION DETAIL
https://phabricator.kde.org/D6856
AFF
elvisangelaccio updated this revision to Diff 17246.
elvisangelaccio edited the summary of this revision.
elvisangelaccio added a comment.
- Don't emit urlChanged() twice when calling openUrl().
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6856?vs=17149&id
dfaure added a comment.
This would make a large number of other headers accessible on other Unixes.
So this additional include should be added only on Mac OS.
I'm also a bit confused by the description. You say "QT/include" but this is
rather about the includes for the framework, no?
winterz created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
on mac os x framework builds of Qt, QT/include is not added to the list of
include path,. this patch looks up one
elvisangelaccio added a comment.
Ping?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6685
To: elvisangelaccio, #frameworks, dfaure
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in copyjob.cpp:1674
> Should the flag always be set here? Or only if m_privilegeExecutionEnabled is
> true?
Ideally it should be set when m_privilegeExecutionEnabled is true. But it will
add more lines. Even though its just 2-3 lin
chinmoyr updated this revision to Diff 17225.
chinmoyr added a comment.
- Remove extra if statements
- if..else -> switch..case in CopyJob
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6833?vs=17022&id=17225
BRANCH
temp
REVISION DETAIL
https://phabricator.kde.org/D6833
AFFE
cullmann added a comment.
For me only the ruby tests fail, too.
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: cullmann, #frameworks
carewolf updated this revision to Diff 17224.
carewolf edited the summary of this revision.
carewolf added a comment.
Forgot to add the new private headers.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17223&id=17224
REVISION DETAIL
https://phabricator.kde.org/D6914
AFF
carewolf updated this revision to Diff 17223.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17209&id=17223
REVISION DETAIL
https://phabricator.kde.org/D6914
AFFECTED FILES
CMakeLists.txt
autotests/CMakeLists.txt
autotests/src/bug313759.cpp
autotests/src/bug317111.cpp
chinmoyr updated this revision to Diff 17222.
chinmoyr added a comment.
1. Separated enums, vars and functions
2. Removed hardcoding
3. Use the new signal privilegeOperationRequested
4. Removed public methods added in previous revision. Instead of them d_func
is used (which should have b
carewolf added a comment.
As I said it has some instrumentation and dead-code. I will clean it up a
bit. I was just hoping for a bit of help on why the ruby indent tests are being
weird.
INLINE COMMENTS
> dhaumann wrote in katescripthelpers.cpp:178
> Is this all not required anymore?
It is
dhaumann added a comment.
First of all, I also think this is a good patch.
There are some parts with debug output, some parts with warnings (e.g.
Q_FUNC_INFO), I guess this is temporary? :-)
Besides that, there are several parts with commented out code - is that work
in progress, or is
carewolf added a comment.
Note all of the helper functions are now single argument, but no script we
have use more. It doesn't however remove templating in the i18n functions.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann,
cullmann added a comment.
A private not-installed header is fine for that, sure.
I just would minimize the public API changes.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: cullmann, #frameworks
carewolf added a comment.
Actually the Q_GADGET part is not needed. I have commented out the code that
registers the qmetaobject, so at this point those changes are no longer needed.
I needed to do manual conversion anyway. The conversion functions doesn't need
to be in public headers. But t
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:12d50fae7527: Theme: Remove license and author fields
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6913?vs=17208&id=17211
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:34489c2a1cec: Theme: Derive read-only flag from file on
disk (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6912?vs=17206&id=172
cullmann added reviewers: cullmann, dhaumann, Frameworks.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: cullmann, #frameworks
cullmann added a comment.
First: As already said in person: COOL ;=)
I failed to port some years ago and just dumped my patch on the attic.
For the changes: Do we need the helper functions in the public headers? I see
that we need to make the things Q_GADGETs, thats fine, but do we need
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6913
To: dhaumann, cullmann, vkrause
Cc: #frameworks
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6912
To: dhaumann, vkrause
Cc: #frameworks
carewolf created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Replaces the QtScript depedency with QtQml.
WIP: The ruby indentation test doesn't work, and appears unstable as
most fai
dhaumann edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6913
To: dhaumann, cullmann, vkrause
Cc: #frameworks
dhaumann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Remove author and license fields to avoid the mess we have in
highlighting.xml files. Luckily, this was not yet public API.
TEST PLAN
ma
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0ac78aa3fba4: Emit a "." UDSEntry when not present, even
on empty directories. (authored by albertvaka).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6906?vs=17194&id
dhaumann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Instead of having a "read-only" flag in the .theme files, using the file
location typically is exactly what we want.
And having read-only
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.
Tested with mtp and it works, thanks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6906
To: albertvaka, #frameworks, elvisangelaccio
chinmoyr updated this revision to Diff 17203.
chinmoyr added a comment.
Updated doc
Renamed signal to privilegeOperationRequested().
Merged request(signal) and reply into one method,
isPrivilegeOperationAllowed(). Now there is no round trip.
Eliminated QStringList.
CHANGES SINCE LAST UP
chinmoyr updated this revision to Diff 17202.
chinmoyr marked 5 inline comments as done.
chinmoyr added a comment.
1. Updated doc
2. Renamed signal to privilegeOperationRequested().
3. Merged request(signal) and reply into one method,
isPrivilegeOperationAllowed(). Now there is no round tr
40 matches
Mail list logo
