BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/34/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 25 Jul 2017 02:47:02 +
Build duration:
25 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/18/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 25 Jul 2017 02:46:42 +
Build duration:
4 min 26 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:802d106c8e81: Add Conan files (authored by gladhorn).
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6877?vs=17127&id=17153
REVISION DETAIL
https://phabricator.k
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
The URL changes twice because you make it change twice ;)
But that can lead to the application updating stuff twice, which doesn't seem
very optimal. (actions getting disabled
elvisangelaccio edited the summary of this revision.
elvisangelaccio edited the test plan for this revision.
REVISION DETAIL
https://phabricator.kde.org/D6856
To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
elvisangelaccio edited the test plan for this revision.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D6889
To: elvisangelaccio, #kate, #kdevelop, dfaure
Cc: #frameworks
elvisangelaccio added dependencies: D6890: Emit urlChanged() only if we
actually open the URL, D6856: Reset url in closeUrl().
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D6889
To: elvisangelaccio, #kate, #kdevelop, dfaure
Cc: #frameworks
elvisangelaccio added a dependent revision: D6889: TestPart: add more test
cases.
REVISION DETAIL
https://phabricator.kde.org/D6856
To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
elvisangelaccio added a comment.
@cullmann After thinking more about it, the URL does change twice (old url ->
QUrl(), QUrl() -> new url), so it should be expected to get two urlChanged()
signals.
Consider this scenario:
- openUrl(foo)
- part loads url foo.
- openUrl(bar)
- op
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/33/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 24 Jul 2017 21:34:02 +
Build duration:
9 min 48 sec and counting
JUnit Tes
elvisangelaccio updated this revision to Diff 17149.
elvisangelaccio added a comment.
- Use setUrl() to reset the URL.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6856?vs=17070&id=17149
BRANCH
reset-url-in-closeUrl
REVISION DETAIL
https://phabricator.kde.org/D6856
AFFECTED
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
TestPart is now able to simulate a part that fails to open an URL.
REPOSITORY
R306 KParts
BRANCH
improve-testpart
REVISION DET
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Good work, just some small things, and a suggested simplification to the
overall slave<->job protocol.
INLINE COMMENTS
> slavebase.h:941
> + * with elevated privileges. It is
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> job.cpp:345
> +m_confirmationAsked = true;
> +return status == 5;
> +}
This hardcoded 5 is awful, please use SlaveBase::Continue instead.
> job_base.
dfaure added inline comments.
INLINE COMMENTS
> chmodjob.cpp:238
> KIO::SimpleJob *job = KIO::chmod(info.url, info.permissions);
> +if (m_privilegeExecutionEnabled) {
> +job->setParentJob(q);
Maybe all these if()s can be removed? I assume setParentJob just stores a
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I'll use this as basis for generating such files with an ECM macro, similar
to what we do for pri files.
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricator.k
gladhorn updated this revision to Diff 17127.
gladhorn marked an inline comment as done.
gladhorn added a comment.
fix url
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6877?vs=17126&id=17127
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
gladhorn marked 3 inline comments as done.
gladhorn added inline comments.
INLINE COMMENTS
> apol wrote in conanfile.py:5
> Can we re-use the version from the `CMakeLists.txt`?
The goal is to generate it.
> apol wrote in conanfile.py:7
> Re-use from metainfo.yml?
For now we consider this as a
gladhorn updated this revision to Diff 17126.
gladhorn added a comment.
Updated according to comments
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6877?vs=17124&id=17126
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6877
AFFECTED FILE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/32/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 24 Jul 2017 15:34:56 +
Build duration:
11 min and counting
JUnit Tests
gladhorn updated this revision to Diff 17124.
gladhorn added a comment.
remove -git from the version
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6877?vs=17118&id=17124
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6877
AFFECTED FILES
aacid added a comment.
Ok, so i guess that would apply to kparts too.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D6800
To: kossebau, #frameworks, dfaure
Cc: lueck, ltoscano, aacid
gladhorn updated this revision to Diff 17118.
gladhorn added a comment.
Fix license
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6877?vs=17116&id=17118
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6877
AFFECTED FILES
conanfile.py
lueck added a comment.
In https://phabricator.kde.org/D6800#128307, @kossebau wrote:
>
> I cannot see though any catalogs which would match the template-string
catalog names, so seems there is some magic already to prevent that?
l10n-kf5/scripts/extract-messages
apol added a comment.
Makes sense to me, I can reproduce the issue, I cannot reproduce the fix
because `androiddeployqt` doesn't accept my system's gradle.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6876
To: aacid, apol, mart, kossebau
Cc: #framewo
gladhorn updated this revision to Diff 17116.
gladhorn added a comment.
Remove private test stuff
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6877?vs=17115&id=17116
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6877
AFFECTED FILES
apol added inline comments.
INLINE COMMENTS
> conanfile.py:3
> +
> +class KarchiveConan(ConanFile):
> +name = "KArchive"
`KArchiveConan`?
> conanfile.py:5
> +name = "KArchive"
> +version = "5.37.0-git"
> +license = "lgpl2"
Can we re-use the version from the `CMakeLists.txt`?
>
cfeck added inline comments.
INLINE COMMENTS
> example.cpp:6
> +KZip a("somefile");
> +FrederikTest ttt;
> +return 0;
:)
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D6877
To: gladhorn
Cc: cfeck, #frameworks
gladhorn created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Conan is a C++ package manager. This is an experiment to make KF5
frameworks available on Conan to make building KDE applications easier.
kossebau added a subscriber: ltoscano.
kossebau added a comment.
In https://phabricator.kde.org/D6800#128256, @aacid wrote:
> At least there is a problem l10n wise in which there is a Messages.sh so i
guess it will be run and create a "fake" .pot file (and something similar for
the .desk
aacid created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REPOSITORY
R240 Extra CMake Modules
BRANCH
fix_install_apk
REVISION DETAIL
https://phabricator.kde.org/D6876
AFFECTED FILES
t
dhaumann abandoned this revision.
dhaumann added a comment.
Submitted:
https://commits.kde.org/syntax-highlighting/916efa110fffc33d6350f3ca4a7ec73cf5b2b8e3
Just borked the log message, so I'll just abandon this.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kd
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9f43abc06b21: indexer checks for leading/trailing
whitespaces in XML highlighting definitions (authored by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabrica
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:916efa110fff: Doxygen: Add Doxyfile highlighting
(authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5338?vs=13205&id=17112#toc
REPOSITORY
R216 Syntax Highlighting
CHANGE
aacid created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Otherwise when trying to build with the newest Qt/android toolchains it fails
REPOSITORY
R240 Extra CMake Modules
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me...
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6871
To: cullmann, vkrause, dhaumann
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c40ad3513f91: add missing standard types to C
highlighting and update to C11 (authored by brauch).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6870?vs=17104&id=17109#toc
REPOSITORY
R216 S
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Please inc the version number.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6870
To: brauch, vkrause, dhaumann
Cc: vkrause, dhaumann, #framework
aacid added a comment.
At least there is a problem l10n wise in which there is a Messages.sh so i
guess it will be run and create a "fake" .pot file (and something similar for
the .desktop file)
Though probably this is already happening?
Any idea on how we would make that not happen
cullmann added a comment.
It is no error ATM, as first one needs to cleanup the xml files with
something like:
perl -pi -e 's@\s*(\S+)\s*@\1@gi' *.xml
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6871
To: cullmann, vkrause, dhaumann
Cc: #framewor
cullmann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Let the indexer check for keywords with leading/trailing spaces, they lead to
not needed allocs for trimmed() after loading.
REPOSITORY
brauch added reviewers: vkrause, dhaumann.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6870
To: brauch, vkrause, dhaumann
Cc: vkrause, dhaumann, #frameworks
brauch created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
See bug: https://bugs.kde.org/show_bug.cgi?id=367798
My suggestion is to add the new C11 keywords to the C highlighting, add the
missing
vkrause closed this revision.
vkrause added a comment.
Pushed to master.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6867
To: vkrause, dhaumann, vonreth
Cc: #frameworks
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6867
To: vkrause, dhaumann, vonreth
Cc: #frameworks
vkrause updated this revision to Diff 17103.
vkrause added a comment.
Right, license is due to the original file.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6867?vs=17094&id=17103
REVISION DETAIL
https://phabricator.kde.org/D6867
AFFECTE
dhaumann added a comment.
Ah, and we need spellChecking="0" almost everywhere except for HereString and
String, and comments right?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6867
To: vkrause, dhaumann, vonreth
Cc: #frameworks
dhaumann updated this revision to Diff 17097.
dhaumann added a comment.
Update again to reflect unit testing changes.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6866?vs=17096&id=17097
REVISION DETAIL
https://phabricator.kde.org/D6866
AFF
dhaumann updated this revision to Diff 17096.
dhaumann added a comment.
Remove section header, since it did not work as expected at all.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6866?vs=17092&id=17096
REVISION DETAIL
https://phabricator
emaurer added a comment.
In https://phabricator.kde.org/D5338#128106, @dhaumann wrote:
> @emaurer We just agreed that your version is better and would like to use
this. Are you also OK with using the MIT license? Currently, we are trying to
unify the licensing to MIT for as many of our x
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
Looks almost good, but I think another iteration would be nice.
I assume we cannot relicense to MIT?
INLINE COMMENTS
> powershell.xml:5
> + version="1"
> + kateversion=
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Based on https://github.com/jgm/highlighting-kate/pull/80/ with some fixes
and improvements.
REPOSITORY
R216 Syntax Highlighting
REVISIO
dhaumann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This adds Doxyfile highlighting support, initially taken from
https://github.com/KDE/syntax-highlighting/pull/5 and slightly modified.
Al
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/30/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 24 Jul 2017 09:13:09 +
Build duration:
24 min and counting
JUnit Tests
kfunk abandoned this revision.
kfunk added a comment.
Note: Abandoning this Diff in favor of the one from @emaurer
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D5338
To: kfunk, dhaumann, kwrite-devel, vkrause
Cc: turbov, emaurer, #frameworks
dhaumann added a comment.
@emaurer We just agreed that your version is better and would like to use
this. Are you also OK with using the MIT license? Currently, we are trying to
unify the licensing to MIT for as many of our xml highlighting files as
possible.
REPOSITORY
R216 Syntax Highli
elvisangelaccio planned changes to this revision.
elvisangelaccio added a comment.
In https://phabricator.kde.org/D6856#128029, @cullmann wrote:
> Hi, I see the issue that the url is changed without calling setUrl. That
doesn't emit urlChanged() that way.
> On the other side, if setUrl
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/29/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 24 Jul 2017 08:31:06 +
Build duration:
10 min and counting
JUnit Tests
58 matches
Mail list logo
