D6858: Fix replaceCaptures() to work with more than 9 captures

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1010ce8b7e7a: Fix replaceCaptures() to work with more than 9 captures (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6858?vs=170

D6856: Reset url in closeUrl()

cullmann added a comment. Hi, I see the issue that the url is changed without calling setUrl. That doesn't emit urlChanged() that way. On the other side, if setUrl would be used, you will get the urlChanged twice in openUrl which might lead to not-wanted side-effects. REPOSITORY R306 KPa

D6858: Fix replaceCaptures() to work with more than 9 captures

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6858 To: dhaumann, vkrause Cc: #frameworks

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 23 Jul 2017 18:01:09 + Build duration: 2 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/20/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 23 Jul 2017 17:59:59 + Build duration: 47 sec and counting JUnit Tests Nam

D6794: assert the testpackage appstream data validates

This revision was automatically updated to reflect the committed changes. Closed by commit R290:cd4ec70f3539: assert the testpackage appstream data validates (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6794?vs=16936&id=17079#toc REPOSITORY R290 KPackage CHANGE

D6793: adopt new KAboutLicense::spdx

This revision was automatically updated to reflect the committed changes. Closed by commit R290:f2127b122bd1: adopt new KAboutLicense::spdx (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6793?vs=16935&id=17078 REVISION DETAIL https://

D6858: Fix replaceCaptures() to work with more than 9 captures

dhaumann created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Currently, the for loop iterates from 1...n, which is an issue, if n > 9. Luckily, this so far was never an issue, since we typically h

D6856: Reset url in closeUrl()

elvisangelaccio added a reviewer: KDevelop. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop Cc: #frameworks

D6857: Improve apidox of openFile()

elvisangelaccio marked an inline comment as done. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6857 To: elvisangelaccio, dfaure Cc: #frameworks

D6857: Improve apidox of openFile()

This revision was automatically updated to reflect the committed changes. Closed by commit R306:5ac4fab4e5de: Improve apidox of openFile() (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6857?vs=17071&id=17073#toc REPOSITORY R306 KParts CHANGES SINCE LAST

D6856: Reset url in closeUrl()

elvisangelaccio added reviewers: KTextEditor, Kate. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure, #ktexteditor, #kate Cc: #frameworks

D6856: Reset url in closeUrl()

dfaure added a comment. It seems to make sense, but since it's been that way for so long, I'd like confirmation from at least Kate / KDevelop that this doesn't break anything. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D6856 To: elvisangelaccio, dfaure Cc: #frame

D6857: Improve apidox of openFile()

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > readonlypart.h:253 > + * If this method returns true, the part emits completed(), > + * otherwise emits canceled(). > + * otherwise += it REPOSITORY R306

D6857: Improve apidox of openFile()

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add a note about the signals emitted depending on its return value. REPOSITORY R306 KParts BRANCH improve-apidox REVISION DETA

D6856: Reset url in closeUrl()

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise url() will return a possibly stale URL (for example, if loading failed). REPOSITORY R306 KParts BRANCH empty-url-af

D6793: adopt new KAboutLicense::spdx

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D6793 To: sitter, sebas, apol Cc: #frameworks

D6793: adopt new KAboutLicense::spdx

sitter added a comment. Ping? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D6793 To: sitter, sebas, apol Cc: #frameworks

D6596: Fix dev_t declaration for Solid UDisks2 backend

This revision was automatically updated to reflect the committed changes. Closed by commit R245:2382c3f8d366: Require sys/types.h for dev_t unconditionally. (authored by mpyne). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6596?vs=16420&id=17066 REVISION DETA

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 23 Jul 2017 13:58:56 + Build duration: 3 min 20 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/39/ Project: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 Date of build: Sun, 23 Jul 2017 13:58:56 + Build duration: 1 min 28 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/38/ Project: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 Date of build: Sun, 23 Jul 2017 13:50:41 + Build duration: 6 min 34 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/38/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 23 Jul 2017 13:50:41 + Build duration: 1 min 43 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/37/ Project: Frameworks syntax-highlighting kf5-qt5 XenialQt5.7 Date of build: Sun, 23 Jul 2017 13:09:43 + Build duration: 1 min 53 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/37/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 23 Jul 2017 13:09:43 + Build duration: 1 min 10 sec and counting

D6596: Fix dev_t declaration for Solid UDisks2 backend

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D6596 To: mpyne, #frameworks, davidedmundson