This revision was automatically updated to reflect the committed changes.
Closed by commit R127:a00a5d5e1c97: [server] Send pointer leave if focused
surface gets unbound (authored by graesslin).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6754?vs=16829&id=
graesslin added a comment.
Your commit message has a typo where X is written but Wayland is meant.
INLINE COMMENTS
> dialog.cpp:1160
>
> -if (ee->region().isNull()) {
> +if (ee->region().isNull() || KWindowSystem::isPlatformX11()) {
> return QQuickWindow::event(
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
https://phabricator.kde.org/R242:fd2e850156ac7aa9c9dc2cf46652b2a1f1fc3a07
introduces some behaviour
changes tha
lvsouza accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D6687
To: pvillani, jgrulich, lvsouza
Cc: #frameworks
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma, davidedmundson
Cc: plasma-devel, davidedmundson, #frameworks, Zren
asturmlechner updated this revision to Diff 16896.
asturmlechner added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Changed according to review
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
For consistency with https://phabricator.kde.org/D6774.
TEST PLAN
None as I can't figure out whether these strings are actually displayed
somewhere.
REPOSITORY
R237 KConfig
BRANCH
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
These actions can be applied also to folders, so their user-visible
labels should not explicitly mention "File".
BUG: 382450
REPOSITORY
R265 KConfigWidgets
BRANCH
master
REVI
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
adddoxforqtsyspaths
REVISION DETAIL
https://phabricator.kde.org/D6773
To: kossebau, #frameworks, apol
Cc: #build_system
kossebau added a comment.
Given the slightly complicated history of what KDE_INSTALL_USE_QT_SYS_PATHS
does, I omitted a "since" on purpose for now.
Would you agree it makes sense to simplify things be just adding "Since 5.22"
and ignore previous behaviour?
See also https://phabricator.
kossebau added a comment.
See also https://phabricator.kde.org/D6773 for making the resulting behaviour
documented.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6772
To: kossebau, #frameworks, ltoscano, rdieter
Cc: #build_system
kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REPOSITORY
R240 Extra CMake Modules
BRANCH
adddoxforqtsyspaths
REVISION DETAIL
https://phabricator.kde.org/D6773
AFFECTED FILES
kde-m
kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REVISION SUMMARY
when KDE_INSTALL_USE_QT_SYS_PATHS has been explicitely set,
qmake can be considered a required dependency, otherwise the
winterz closed this revision.
winterz added a comment.
see https://phabricator.kde.org/R240:db46fb7c2fdcfbff5f8a0445e4d055cf4388ead8
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #fr
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/38/
Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 18 Jul 2017 12:30:24 +
Build duration:
2 min 14 sec and counting
winterz added a comment.
In https://phabricator.kde.org/D6762#126463, @nalvarez wrote:
> Looks reasonable – although I wonder why on earth you're building KDE stuff
on Cygwin...
fun. as an experiment. i'm curious.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://
sitter updated this revision to Diff 16865.
sitter retitled this revision from "do not keep constructing new
selectionmodels" to "simplify setContents by letting Qt do more of the work".
sitter edited the summary of this revision.
sitter added a comment.
did some more digging with input from D
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
QAIV creates a new selectionModel whenever we call setModel.
(qabstractitemview.cpp:762)
So you're right this is at best, a bit pointlesss, but the fix isn't r
sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
simply change its underlying model after it has been initialized once.
ideally I suppose instead of changing the model at all we should h
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ca40063c4e49: do not crash qaccessible by causing a
resize in a resize event (authored by sitter).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6624?vs=16502&id=16860#toc
REPOSITORY
R236 K
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
Would be nice if you also commit the conditional in the KCharSelectItemModel
::setColumnCount.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
sitter added a comment.
In https://phabricator.kde.org/D6624#126506, @cfeck wrote:
> Let's say someone fixes the referenced Qt bug, and we are at a point
requiring that Qt version anyway. Are you going to remove the workaround?
Anyone who happens to stumble upon it can.
REPOSITOR
cfeck added a comment.
Let's say someone fixes the referenced Qt bug, and we are at a point
requiring that Qt version anyway. Are you going to remove the workaround?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfeck, anthonyf
sitter added a comment.
In https://phabricator.kde.org/D6624#126503, @cfeck wrote:
> If you are sure that your fix is "correct", then please remove the comment.
From reading it, it looks like a workaround for a Qt bug.
It is a workaround. It crashes because the life time of the qa
cfeck added a comment.
Reading your comment it is also wrong. Resizing the model does not cause a
resize of the widget. The widget size is controlled by the layout manager.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfeck, a
sitter updated this revision to Diff 16858.
sitter added a comment.
- do not use ctor delegation, can't use that in kf5 yet
- eliminate the "partial" private ctor, instead call the full private ctor
from the partial public ctors. this results in defaults being implemented in
the public ctor
cfeck added a comment.
If you are sure that your fix is "correct", then please remove the comment.
From readiong it, it looks like a workaround for a Qt bug.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D6624
To: sitter, gladhorn
Cc: cfeck, anthonyfieroni,
sitter added a comment.
In https://phabricator.kde.org/D6624#126465, @cfeck wrote:
> > It probably does.
>
> Were you able to test? I would prefer the simpler patch. I cannot test it,
because my system does not have accessibility enabled.
Yes, I did not manage to crash it that
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #frameworks, #build_system
29 matches
Mail list logo
