KDE CI: Frameworks kxmlgui kf5-qt5 FreeBSDQt5.7 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks kxmlgui kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 14 Jul 2017 21:02:59 + Build duration: 3 min 9 sec and counting JUnit Tests N

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130180/#review103451 --- Ship it! Enlarging the dialog when showing a child widget

D6687: Adding support to ipv*.route-metric

lvsouza requested changes to this revision. lvsouza added a comment. This revision now requires changes to proceed. The summary says this patch adds route metric support to IPv4 too, but no IPv4 file is touched by this patch. Have you missed the IPv4 changes? INLINE COMMENTS > ipv6setting.cp

D6706: Fix empty string when change the Proxy SOCKS address

dmariano retitled this revision from "Empty string when change the Proxy address" to "Fix empty string when change the Proxy SOCKS address". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6706 To: dmariano Cc: #frameworks

D6706: Empty string when change the Proxy address

dmariano created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The url of the field "Proxy SOCKS:" is not restored to the QLineEdit when the Proxy program is reopened. The problem is if the variable "

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/19/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 14 Jul 2017 15:56:33 + Build duration: 58 sec and counting JUnit Tests Name:

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/18/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 14 Jul 2017 15:56:33 + Build duration: 34 sec and counting JUnit Tests Nam

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/17/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 14 Jul 2017 14:39:41 + Build duration: 1 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/18/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 14 Jul 2017 14:39:41 + Build duration: 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/17/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 14 Jul 2017 14:30:33 + Build duration: 1 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/16/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 14 Jul 2017 14:30:33 + Build duration: 30 sec and counting JUnit Tests Nam

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer updated this revision to Diff 16705. wbauer added a comment. New diff with full context. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6701?vs=16701&id=16705 REVISION DETAIL https://phabricator.kde.org/D6701 AFFECTED FILES tests/EC

D6687: Adding support to ipv*.route-metric

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good, thank you so much. INLINE COMMENTS > ipv6setting.cpp:412 > > +if(routeMetric() > 0){ > +setting.insert(QLatin1String(NMQT_SETTING_IP6_CONFIG_ROUTE_METRIC), >

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer added a comment. From the cmake documentation: > set( ... [PARENT_SCOPE]) > > Set the given in the current function or directory scope. > > If the ``PARENT_SCOPE`` option is given the variable will be set in > the scope above the current scope. Each new directory

D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong

wbauer created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Currently the test still passes even if one of the check_translations() calls fail. The reason is that check_tran

D6687: Adding support to ipv*.route-metric

pvillani requested review of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv*.route-metric

pvillani added a comment. Done REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv*.route-metric

pvillani updated this revision to Diff 16697. pvillani retitled this revision from "Adding support to ipv4.route-metric" to "Adding support to ipv*.route-metric". pvillani edited the summary of this revision. pvillani edited the test plan for this revision. pvillani added a comment. Adding sup

D6700: disable compiler warning on testing deprecated function

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN builds and doesn't warn anymore REPOSITORY R244 KCoreAddons BRANCH no-testwarning REVISION DETAIL https://phabricator.kde.org/D6700 AFFECTE

D6700: disable compiler warning on testing deprecated function

sitter added a reviewer: mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D6700 To: sitter, mpyne Cc: #frameworks

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130177/ --- (Updated July 14, 2017, 1:20 p.m.) Status -- This change has been ma

D6686: Drop usage of KDE_DEFAULT_WINDOWFLAGS

This revision was automatically updated to reflect the committed changes. Closed by commit R263:0e57265c5cb6: Drop usage of KDE_DEFAULT_WINDOWFLAGS (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6686?vs=16664&id=16695 REVISION DETAIL

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130177/#review103448 --- Ship it! Ship It! - David Faure On July 14, 2017, 7:38

D6686: Drop usage of KDE_DEFAULT_WINDOWFLAGS

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH changedefaultwf REVISION DETAIL https://phabricator.kde.org/D6686 To: kossebau, #frameworks, dfaure

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter updated this revision to Diff 16694. sitter added a comment. BC constructor addition + change to enum for orlater as suggested + switch param orders to take license, then restriction, then kaboutdata kaboutdata looks and feels idiomatically like a qobject parent which also is

D6624: do not crash qaccessible by causing a resize in a resize event

gladhorn added a comment. Considering that the Qt bug will not be fixed in the next few days (I hope to get around to it, but it's involved), this makes sense. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc: cfeck, anthonyfieroni

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130177/ --- (Updated Juli 14, 2017, 9:38 vorm.) Review request for KDE Frameworks.