D6687: Adding support to ipv4.route-metric

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me. If you can also remove this property from the TODO list that would be great. Btw. there is the same property missing in IPv6Setting in case you would like to do t

D6693: Install the PlasmaComponents.3/private folder

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It's used by ToolButton et al. We install it in the theme folder, but not in the plasma components dir. TEST PL

D6687: Adding support to ipv4.route-metric

pvillani edited reviewers, added: lvsouza; removed: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6687: Adding support to ipv4.route-metric

pvillani added a reviewer: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, #frameworks Cc: #frameworks

D6687: Adding support to ipv4.route-metric

pvillani added a comment. Sorry if something are missing, its my first pull request, let me know if any change are needed. I've tested and it's working fine. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich Cc: #frameworks

D6687: Adding support to ipv4.route-metric

pvillani created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 AFFECTED FILES autotests/settings/ipv4settingtest.cpp src/settings

D6672: add KAboutLicense::spdx and introduce orLater qualification

mpyne requested changes to this revision. mpyne added a comment. This revision now requires changes to proceed. AFAICT we do need to maintain BIC here even for private ctors. The inline comment has more detail. Other than that and with using a flag enum instead of a `bool` I like the patch

D6686: Drop usage of KDE_DEFAULT_WINDOWFLAGS

kossebau added a comment. If okayed, same change to default value would also be done for KParts::MainWindow, s/KDE_DEFAULT_WINDOWFLAGS/Qt::WindowFlags()/. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D6686 To: kossebau, #frameworks, dfaure

D6686: Drop usage of KDE_DEFAULT_WINDOWFLAGS

kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This define seems some KDE3 legacy, time to get more rid of it. REPOSITORY R263 KXmlGui BRANCH changedefaultwf REVISION DETAIL https://phabricator.kde.org/D6686 AFFECTED FILES src/k

D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event

elvisangelaccio added a dependent revision: D6684: Fix drop menu position with urlnavigator drops. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6685 To: elvisangelaccio, #frameworks, dfaure

D6685: KUrlNavigator: expose the KUrlNavigatorButton that received a drop event

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Commit https://phabricator.kde.org/R241:1e251d2f6a428fc5cc27a766c2a6d7b5e8fb2594 does not work with KUrlNavigator drops because the drop event is processed at the KUrlNavigatorButton l

D6683: [server] Send keyboard leave when client destroys the focused surface

graesslin created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a change inspired by https://bugreports.qt.io/browse/QTBUG-61930. When Qt closes a window due to a key press

D6569: [client] Track all created ConnectionThreads and add API to access them

graesslin updated this revision to Diff 16660. graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Make this compile. Looks like kdevelop fooled me and compiled KWin instead of KWayland (that happens all the time to me) REPOSITORY R127

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/18/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 13 Jul 2017 15:04:32 + Build duration: 2 min 26 sec and counting JUnit Tests

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter added a comment. In https://phabricator.kde.org/D6672#124995, @sitter wrote: > For convenience reasons it may actually be prudent to expose both `spdxID` and `orLater` publicly. Case in point right now appstream license information seem to be semi-expressions... they have the spdx

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter added a comment. For convenience reasons it may actually be prudent to expose both `spdxID` and `orLater` publicly. Case in point right now appstream license information seem to be semi-expressions... they have the spdx ID followed by plus sign notation but compound expressions use lo

D6679: Treat Button/ToolButton labels as plaintext

fvogt marked an inline comment as done. fvogt added inline comments. INLINE COMMENTS > broulik wrote in ToolButtonStyle.qml:100 > `Text.StyledText` I think the priority queue in my brain is somehow backwards REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde

D6679: Treat Button/ToolButton labels as plaintext

fvogt updated this revision to Diff 16649. fvogt added a comment. Fix typo in ToolButtonStyle REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6679?vs=16648&id=16649 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6679 AFF

D6679: Treat Button/ToolButton labels as plaintext

broulik added a comment. +1 (for others reading this: Explicitly turning it into `StyledText` prevents Qt's `AutoText` from deciding to use `PlainText` in some cases which will then again look broken. Note that `StyledText` uses a basic string parser so it's nowhere near as heavy as `Ri

D6679: Treat Button/ToolButton labels as plaintext

fvogt created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The label text gets treated as RichText/StyledText, which is required to display mnemonics underlined. Therefore it is necessary to ma

D6676: Declare AppManager.js as pragma library

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d8f1d44a493c: Declare AppManager.js as pragma library (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6676?vs=16643&id=1664

D6676: Declare AppManager.js as pragma library

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Before, I would get at least 6 instances (from various Dialogs that were created for instance). I doubt it, no-one uses that. Probably TabBars. In any case, I wou

D6676: Declare AppManager.js as pragma library

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It doesn't store any state but contains only functions. TEST PLAN Only one instance of this script is created in plasm

D6665: Make kssl compile against OpenSSL 1.1.0

dvratil added a comment. @dfaure neither do I :-) The patch does not require understanding of the API, I just want a formal review. Feel free to add someone who knows openssl if you want - no-one really touched the code for 10 years, so I don't know who to add for review. @ltoscano Not

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

> On July 12, 2017, 9:11 a.m., Kevin Funk wrote: > > src/kdecore/kurl.h, line 437 > > > > > > Maybe it's also worth pointing people to > > `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` as well -- because

D6665: Make kssl compile against OpenSSL 1.1.0

ltoscano added a comment. Does it require Qt to be compiled with the same version of openssl? REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: ltoscano, rdieter, #frameworks

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130177/#review103446 --- src/kdecore/kurl.h (line 437)

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

> On July 12, 2017, 9:11 a.m., Kevin Funk wrote: > > src/kdecore/kurl.h, line 437 > > > > > > Maybe it's also worth pointing people to > > `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` as well -- because

D6604: add a metainfo.yaml to make ECM a proper framework

This revision was automatically updated to reflect the committed changes. Closed by commit R240:5f6aa58b8067: add a metainfo.yaml to make ECM a proper framework (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6604?vs=16626&id=1

D6665: Make kssl compile against OpenSSL 1.1.0

dfaure added a comment. Thanks for this work, but I can't review it, I don't know anything about openssl APIs or this code. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: rdieter, #frameworks

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/16/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Thu, 13 Jul 2017 10:59:45 + Build duration: 4 min 19 sec and counting JUnit Tests

D6604: add a metainfo.yaml to make ECM a proper framework

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6604 To: sitter, ochurlaud, dfaure, skelly Cc: #frameworks, #build_system

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/15/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 13 Jul 2017 10:59:45 + Build duration: 37 sec and counting JUnit Tests Nam

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/32/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Thu, 13 Jul 2017 10:44:08 + Build duration: 7 min 28 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/27/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 13 Jul 2017 10:44:08 + Build duration: 1 min 36 sec and counting JUnit Tes

D6674: use an initializer list instead of calling insert a million times

This revision was automatically updated to reflect the committed changes. Closed by commit R244:30b735056fa2: use an initializer list instead of calling insert a million times (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6674?vs=16635&id=16638#toc REPOSITORY R24

D6674: use an initializer list instead of calling insert a million times

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutdata.cpp:352 > // Use normalized keywords, by the algorithm below. > -static QHash ldict; > -if (ldict.isEmpty()) { > -ldict.insert("gpl", KAbou

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter added a reviewer: mpyne. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D6672 To: sitter, sebas, mpyne Cc: #frameworks

D6674: use an initializer list instead of calling insert a million times

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY looks nicer, is probably also more optimized, and allows us to tag the dict as const. TEST PLAN builds and kaboutdatatest passes REPOSIT

Re: kaboutlicense api extension ::spdxId()?

On Tue, Jul 11, 2017 at 2:17 PM, Sebastian Kügler wrote: > On dinsdag 11 juli 2017 13:41:17 CEST Harald Sitter wrote: >> I was wondering if anyone had an opinion on extending kaboutlicense >> with a ::spdxId() instance method returning the license's spdx id [1]. >> >> Use case at hand is kpackaget

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter updated this revision to Diff 16634. sitter added a comment. add missing since tag REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6672?vs=16633&id=16634 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6672 AFFECTED FILES autot

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter updated this revision to Diff 16633. sitter added a comment. forgot to sort out BIC There is one theoretical BIC with the License ctor which has a new param. I am not sure we care about this given the ctor is private. Objections welcome but I think in the past we decied to not car

D6672: add KAboutLicense::spdx and introduce orLater qualification

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY External software (e.g. appstream) uses the standardized SPDX license identifiers. Seeing as they are specified and ours are not it is usefu

D6665: Make kssl compile against OpenSSL 1.1.0

dvratil edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D6665 To: dvratil, #frameworks, dfaure Cc: rdieter, #frameworks

D6604: add a metainfo.yaml to make ECM a proper framework

sitter updated this revision to Diff 16626. sitter added a comment. add a readme I've tried for like 2 hours to wire this into the existing docs build and get away with one README. Alas, no luck. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

bcooksley added a comment. In https://phabricator.kde.org/D5173#124620, @habacker wrote: > BTW: You mentioned that KF5_LIBEXEC_INSTALL_DIR is 'bin/libexec/kf5/' on Windows, Should it not be lib/libexec/kf5 ? On unix this is located in 'lib[64]/libexec/kf5 ' - why this difference ?