KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 1 - Failure!

2017-07-01 Thread no-reply
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/1/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sun, 02 Jul 2017 00:42:52 + Build duration: 3 min 23 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 WindowsQt5.7 - Build # 1 - Unstable!

2017-07-01 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsQt5.7/1/ Project: Frameworks kirigami kf5-qt5 WindowsQt5.7 Date of build: Sun, 02 Jul 2017 00:43:13 + Build duration: 2 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 1 - Unstable!

2017-07-01 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/1/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 02 Jul 2017 00:43:10 + Build duration: 1 min 13 sec and counting JUnit Tests

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-07-01 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6008 To: elvisangelaccio, mart, #frameworks, dfaure Cc: #frameworks

D6452: Add missing export to QueueSignals

2017-07-01 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R279 ThreadWeaver BRANCH master REVISION DETAIL https://phabricator.kde.org/D6452 To: davidedmundson, dfaure Cc: #frameworks

D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys

2017-07-01 Thread David Faure
dfaure added a comment. Ping? it seems like you are OK with this after all? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D6234 To: dfaure, graesslin Cc: #frameworks

D6198: Add KAuth support to delete operation

2017-07-01 Thread David Faure
dfaure added a comment. OK now I see the purpose of the Helper class. Strange that it appeared in the previous commit, but OK. INLINE COMMENTS > deletejobtest.cpp:119 > +QVERIFY(spy.isValid()); > +QVERIFY(spy.wait(10)); > +QCOMPARE(job->error(), KJOB_NO_ERROR); 100s is too m

D6197: Add basic KAuth support to file ioslave

2017-07-01 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jobuidelegateextension.h:230 > + */ > + virtual bool askPrivilegeOpConfirmation(const QList &urls, > PrivilegeConfType privilegeConfType) = 0; >

Re: Kirigami in Frameworks

2017-07-01 Thread David Faure
On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote: > Hi, > I have moved it, should be good to go. > one sidenote (hoping is not a problem) for historical reasons, the > tarballs were called kirigami2-version instead of just kirigami (or > distributions may have some problems in upgrading)..

Re: Kirigami in Frameworks

2017-07-01 Thread Albert Astals Cid
https://websvn.kde.org/trunk/l10n-kf5/templates/messages/frameworks/libkirigami2plugin_qt.pot?revision=1492189&view=markup Disagrees with you  Sent from Yahoo Mail on Android On ds., jul. 1, 2017 at 9:02, Sebastian Kügler wrote: On vrijdag 30 juni 2017 23:16:49 CEST Albert Astals Cid wrote:

Re: Kirigami in Frameworks

2017-07-01 Thread Sebastian Kügler
On vrijdag 30 juni 2017 23:16:49 CEST Albert Astals Cid wrote: > What happened to the "no new strings after the first two weeks" rule? Kirigami doesn't have any translatable strings. -- sebas http://www.kde.org | http://vizZzion.org