D6413: Use KIO::rename instead of KIO::moveAs in setData

2017-06-27 Thread Eike Hein
hein added a comment. dfaure, this what I was gonna talk to you about on Wednesday FWIW. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6413 To: hein, #frameworks, dfaure, davidedmundson

D6413: Use KIO::rename instead of KIO::moveAs in setData

2017-06-27 Thread Eike Hein
hein created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY We've recently been plagued by issues where renaming via KDirModel would fail to call into the rename() implementation of kio_desktop (which is a KIO::ForwardingSlaveBase). Instead it would end u

D6250: Expand documentation of Persistence attribute

2017-06-27 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R283:8352c0d49eeb: Expand documentation of Persistence attribute (authored by elvisangelaccio). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6250?vs=15928&id=15929 REVI

D6250: Expand documentation of Persistence attribute

2017-06-27 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D6250 To: elvisangelaccio, #frameworks, davidedmundson Cc: chinmoyr, davidedmundson

D6250: Expand documentation of Persistence attribute

2017-06-27 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D6250 To: elvisangelaccio, #frameworks, davidedmundson Cc: chinmoyr, davidedmundson

D6250: Expand documentation of Persistence attribute

2017-06-27 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 15928. elvisangelaccio added a comment. - Explain what happens when the persistence attribute is missing. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6250?vs=15519&id=15928 BRANCH master REVISION DETAIL h

D6202: Expand apidox of KJobWidget::setWindow()

2017-06-27 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R288:7596f6bbc699: Expand apidox of KJobWidget::setWindow() (authored by elvisangelaccio). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6202?vs=15401&id=15927 REV

D5902: Expand KNewStuff documentation

2017-06-27 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:4b37ece102dd: Expand KNewStuff documentation (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5902?vs=15908&id=15924 REVISION DETAIL https:

D6047: WIP: Support XDG v6

2017-06-27 Thread David Edmundson
davidedmundson added a comment. Update from IRC chat: It was BIC from when I renamed that signal. All resolved. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, le

D6047: WIP: Support XDG v6

2017-06-27 Thread Marco Martin
mart added a comment. right now, the xdgv6 branch (xdgv6popup actually) for me causes a crash in kwin at startup, with the following BT: #0 _int_malloc (av=av@entry=0x7556ab20 , bytes=bytes@entry=72) at malloc.c:3414 #1 0x7522a5d4 in __GI___libc_malloc (bytes=72) at malloc.c

D5902: Expand KNewStuff documentation

2017-06-27 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > leinir wrote in README.md:35 > It still need to be found before you can set it as runtime (unless i am > fundamentally misunderstanding something of course) - like how it's

D6008: Give a parent to KMoreToolsMenuFactory menus

2017-06-27 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6008 To: elvisangelaccio, mart Cc: #frameworks

D5208: Allow loading i18n catalogs from arbitrary locations

2017-06-27 Thread David Edmundson
davidedmundson marked 3 inline comments as done. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ilic wrote in klocalizedstringtest.cpp:59 > I think we're not allowed to use initializer lists yet, due to MSVC11 support. Pretty sure it's fine

D5902: Expand KNewStuff documentation

2017-06-27 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > apol wrote in README.md:35 > Still it shouldn't be looked-for, should it? It still need to be found before you can set it as runtime (unless i am fundamentally misunderstanding something of course) - like how it's done in Discover... or am i misu

D5902: Expand KNewStuff documentation

2017-06-27 Thread Aleix Pol Gonzalez
apol added a comment. General +1 INLINE COMMENTS > leinir wrote in README.md:35 > No, you are quite right - i don't think it is even technically possible in > most cases, so this will need some reworking to explain that (it's a Qt Quick > module, after all) Still it shouldn't be looked-for

D5902: Expand KNewStuff documentation

2017-06-27 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 15908. leinir added a comment. Add/fix a whole bunch of more documentation, identified as missing (or incorrect) by Aniketh REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5902?vs=14660&id=15908 REVISION DETAIL http

KDE CI: Frameworks kfilemetadata kf5-qt5 XenialQt5.7 - Build # 12 - Fixed!

2017-06-27 Thread no-reply
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20XenialQt5.7/12/ Project: Frameworks kfilemetadata kf5-qt5 XenialQt5.7 Date of build: Tue, 27 Jun 2017 10:03:55 + Build duration: 1 min 13 sec and counting JUnit Te

D6394: Add KF6-TODO to make KComboBox::minimumSizeHint() public

2017-06-27 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R284:1910d3ac9b1e: Add KF6-TODO to make KComboBox::minimumSizeHint() public (authored by kossebau). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6394?vs=15882&id=1

D6047: WIP: Support XDG v6

2017-06-27 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6047#119765, @graesslin wrote: > In https://phabricator.kde.org/D6047#119698, @mart wrote: > > > trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 > > > no need to hurry with it. IMHO