KDE CI: Frameworks plasma-framework kf5-qt5 WindowsQt5.7 - Build # 44 - Still Failing!

2017-06-24 Thread no-reply
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsQt5.7/44/ Project: Frameworks plasma-framework kf5-qt5 WindowsQt5.7 Date of build: Sun, 25 Jun 2017 05:03:37 + Build duration: 6 min 55 sec and counting

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

2017-06-24 Thread Albert Astals Cid
aacid added a comment. I don't think i know enough sh to give it a "this is compatible with basic sh", but i guess that if it works you can commit it. Only thing is that maybe you don't really need to de-bash optimize-svg.sh and icons-dark/light2Dark since they seem things you run manual

Re: Kirigami in Frameworks

2017-06-24 Thread Ben Cooksley
On Sun, Jun 25, 2017 at 8:44 AM, David Faure wrote: > On samedi 24 juin 2017 11:15:25 CEST Ben Cooksley wrote: >> Please check the new CI at https://build-sandbox.kde.org/ for the >> current state of affairs. > > This doesn't appear to have kirigami at all? Kirigami is currently in Extragear, and

Re: Kirigami in Frameworks

2017-06-24 Thread David Faure
On samedi 24 juin 2017 11:15:25 CEST Ben Cooksley wrote: > Please check the new CI at https://build-sandbox.kde.org/ for the > current state of affairs. This doesn't appear to have kirigami at all? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE CI: Frameworks kfilemetadata kf5-qt5 XenialQt5.7 - Build # 11 - Failure!

2017-06-24 Thread Ben Cooksley
This is due to a breakage in Neon, i've asked the Neon developers to fix it. Regards, Ben On Sun, Jun 25, 2017 at 4:00 AM, wrote: > *BUILD FAILURE* > Build URL https://build-sandbox.kde.org/job/Frameworks% > 20kfilemetadata%20kf5-qt5%20XenialQt5.7/11/ > Project: Frameworks kfilemetadata kf5-qt5

Re: Kirigami in Frameworks

2017-06-24 Thread Ben Cooksley
On Sun, Jun 25, 2017 at 1:27 AM, David Faure wrote: > On samedi 24 juin 2017 11:52:22 CEST Marco Martin wrote: >> > from requiring Qt 5.7. >> > This Qt version difference creates an issue for the CI though, as can be >> > seen at https://build.kde.org/job/kirigami%20master%20stable-kf5-qt5/ >> >>

KDE CI: Frameworks kfilemetadata kf5-qt5 XenialQt5.7 - Build # 11 - Failure!

2017-06-24 Thread no-reply
BUILD FAILURE Build URL https://build-sandbox.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20XenialQt5.7/11/ Project: Frameworks kfilemetadata kf5-qt5 XenialQt5.7 Date of build: Sat, 24 Jun 2017 15:59:31 + Build duration: 1 min 5 sec and counting C

D6366: Fix configure with Qt5Multimedia disabled.

2017-06-24 Thread Michael Palimaka
This revision was automatically updated to reflect the committed changes. Closed by commit R286:f30fede21bf0: Fix configure with Qt5Multimedia disabled. (authored by palimaka). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6366?vs=15810&id=15821 REVISI

D6366: Fix configure with Qt5Multimedia disabled.

2017-06-24 Thread Matthieu Gallien
mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Thanks for the help. I did not knew this could be wrong. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D6366 To: palimaka, #framework

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

2017-06-24 Thread Adriaan de Groot
adridg updated this revision to Diff 15820. adridg added a comment. Make the diff smaller: only de-bash it, and save make-validation-optional for a later patch. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6076?vs=15116&id=15820 BRANCH arcpatch-

D6076: Do not depend on bash uncessarily, and do not validate icons by default.

2017-06-24 Thread Adriaan de Groot
adridg commandeered this revision. adridg added a reviewer: tcberner. adridg added a comment. Taking over to follow up Albert's suggestion -- this could be two patches, one to de-bash it, one to make validation optional. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kd

Re: Kirigami in Frameworks

2017-06-24 Thread David Faure
On samedi 24 juin 2017 11:52:22 CEST Marco Martin wrote: > > from requiring Qt 5.7. > > This Qt version difference creates an issue for the CI though, as can be > > seen at https://build.kde.org/job/kirigami%20master%20stable-kf5-qt5/ > > so it could be released as a framework anyways, good > If i

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

2017-06-24 Thread Adriaan de Groot
adridg added reviewers: kfunk, poboiko. adridg added a comment. Add reviewers who have commented, or who have committed to baloo recently. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, kfunk, poboiko Cc: adridg, kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

2017-06-24 Thread Adriaan de Groot
adridg added a comment. So this patch looks ready to land to me: it simplifies the code, defers fstype-detection to QStorageInfo (for FreeBSD, we should fix the original issue there), and is otherwise non-intrusive. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784

D5799: Rebase Less syntax highlighting on SCSS one

2017-06-24 Thread Grzegorz Szymaszek
gszymaszek updated this revision to Diff 15814. gszymaszek added a comment. Added a test file (`autotests/input/highlight.less`). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5799?vs=14376&id=15814 REVISION DETAIL https://phabricator.kde.or

Re: Kirigami in Frameworks

2017-06-24 Thread Marco Martin
whops, forgot cc to kde-frameworks, resending On Sat, Jun 24, 2017 at 10:58 AM, David Faure wrote: > On lundi 5 juin 2017 14:42:47 CEST Marco Martin wrote: >> Hi all, >> The Kirigami component set always was targeted to be eventually released as >> a framework, ideally tier 1. since a framework mu

Re: Kirigami in Frameworks

2017-06-24 Thread Ben Cooksley
On Sat, Jun 24, 2017 at 8:58 PM, David Faure wrote: > On lundi 5 juin 2017 14:42:47 CEST Marco Martin wrote: >> Hi all, >> The Kirigami component set always was targeted to be eventually released as >> a framework, ideally tier 1. since a framework must depend at most from 2 >> Qt releases before

D5111: Provide demo/preview for checkable menu items

2017-06-24 Thread René J.V. Bertin
rjvbb retitled this revision from "Provide demo/preview for checkable menu items and colour scheme comparison" to "Provide demo/preview for checkable menu items". rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to

D5111: Provide demo/preview for checkable menu items and colour scheme comparison

2017-06-24 Thread René J.V. Bertin
rjvbb updated this revision to Diff 15812. rjvbb added a comment. Updated for 5.10.2+ CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5111?vs=12788&id=15812 REVISION DETAIL https://phabricator.kde.org/D5111 AFFECTED FILES kstyle/demo/main.cpp kstyle/demo/oxygendemodialog.cpp

Re: Kirigami in Frameworks

2017-06-24 Thread David Faure
On lundi 5 juin 2017 14:42:47 CEST Marco Martin wrote: > Hi all, > The Kirigami component set always was targeted to be eventually released as > a framework, ideally tier 1. since a framework must depend at most from 2 > Qt releases before the current one, it couldn't be released there yet. Now > t

D6202: Expand apidox of KJobWidget::setWindow()

2017-06-24 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D6202 To: elvisangelaccio, #frameworks, dfaure