palimaka created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
When passed -DBUILD_TESTING=OFF -DCMAKE_DISABLE_FIND_PACKAGE_Qt5Multimedia=ON,
CMake failed because find_package(Qt5 COMPONENTS MULTIMEDIA) was treated as
required due to the previous find_pa
palimaka added a comment.
Sorry for the delay, I was away. Thanks for pushing!
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6249
To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system
BUILD FAILURE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/41/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 23 Jun 2017 23:32:42 +
Build duration:
3 min 45 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/40/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Fri, 23 Jun 2017 23:32:42 +
Build duration:
1 min 45 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b715b58563ca: Get the doc dirs with the newly exported
function (authored by ltoscano).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6353?vs=15768&id=15809
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R238:7780d972ad6e: New function to retrieve the documentation
directories (authored by ltoscano).
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6352?vs=15767&id=15808
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6353
To: ltoscano, dfaure
Cc: #frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R238 KDocTools
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6352
To: ltoscano, dfaure
Cc: #frameworks, #documentation, skadinna
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Good fix, thanks.
INLINE COMMENTS
> aacid wrote in kbookmarkmanager.cpp:341
> i'd go for non const as the other two methods, yes they could be const since
> they're not modyfing the object
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6255
To: davidedmundson, dfaure
Cc: #frameworks
davidedmundson updated this revision to Diff 15797.
davidedmundson edited the summary of this revision.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Try to upload via arc...
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDAT
arrowdodger added a comment.
In https://phabricator.kde.org/D6087#118963, @dhaumann wrote:
> Demo for the highlighting rule - I don't think I can say anything to the
auto completion issue. I am pretty sure it is unrelated to your xml file.
Sure. Pragmas have following form:
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:a13f1dcd2e7b: FindQHelpGenerator: avoid picking up Qt4
version (authored by palimaka, committed by kossebau).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
kossebau added a comment.
So pushing now myself, so this todo can be checked off :)
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6249
To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system
dhaumann added a comment.
Demo for the highlighting rule - I don't think I can say anything to the auto
completion issue. I am pretty sure it is unrelated to your xml file.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6087
To: arrowdo
mart added inline comments.
INLINE COMMENTS
> graesslin wrote in xdgshell_interface.h:80
> @davidedmundson for the ping you could check the old wl_shell_surface
> implementation in KWayland.
the implementation here in xdgshell_interface is basically copied over the
kwayland wl_shell_surface.
This revision was automatically updated to reflect the committed changes.
leinir marked an inline comment as done.
Closed by commit R304:eb2e65a882f0: Fix incorrect error detection for missing
knsrc files (authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6340?vs=15742&i
leinir marked an inline comment as done.
leinir added inline comments.
INLINE COMMENTS
> apol wrote in engine.cpp:130
> are you sure the `endl` is necessary?
i am, in fact, reasonably certain it is not required - leftovers are fun, i'll
get rid of that :)
REPOSITORY
R304 KNewStuff
REVISION
bcooksley added a comment.
All the tooling and functionality i've described is provided by Phabricator
itself. We don't have any control over that (without codebase changes, which
i'm strongly against due to the speed of development of Phabricator)
REPOSITORY
R302 KIconThemes
REVISION DET
rjvbb added a comment.
Ben Cooksley wrote on 20170623::09:17:33 re:
"https://phabricator.kde.org/D6309: KIconThemes: some additional details about
themes & icons on Mac & MSWin"
> The system has now polled the repository and the hook has correspondingly
been
bcooksley added a comment.
As Phabricator does not host the repositories it polls them periodically
based on activity in the repository. For KIconThemes this is about once an hour.
The system has now polled the repository and the hook has correspondingly
been triggered.
REPOSITORY
R302 K
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:ac5cbf6b4aa9: More details about deploying icon themes on
Mac & MSWin (authored by rjvbb).
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6309?vs=15694&id=15775
arrowdodger added a comment.
In https://phabricator.kde.org/D6087#117019, @dhaumann wrote:
> Also: could you provide us with a small demo code so that we can extend our
unit test?
The demo for added highlighting rule, or the problem with autocompletion?
REPOSITORY
R216 Syntax H
arrowdodger updated this revision to Diff 15772.
arrowdodger added a comment.
- Use WordDetect instead of StringDetect for `omport` keyword.
- Pop `Pragma` context on `#-}` string, not newline.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D60
rjvbb added a comment.
Well, somehow this wasn't closed automatically:
https://commits.kde.org/kiconthemes/ac5cbf6b4aa969542a780077213cb39a4c110fe6
> Arguably, this is not the place where I would have looked for an answer to
that question, first, but since it does provide an answer, it
chinmoyr added a comment.
> If there was a malicous agent hiding in a dolphin plugin, it would just be
making a direct call to the helper and skip all that.
Till now I was not aware of what a dolphin plugin can or cannot do. I assumed
there would be some kind of restriction. I was wrong
26 matches
Mail list logo
