D6277: Emit errors when keditbookmarks is missing

2017-06-20 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > valeriymalov wrote in kbookmarkmanager.cpp:341 > Uh oh, I'd assume startKEditBookmarks should be const (which I forgot) since > it doesn't change the object, yet we need to emit non-const singal error. So > should it be const or not? > > Also, I'm

D6197: Add basic KAuth support to file ioslave

2017-06-20 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > chinmoyr wrote in file.cpp:1382 > This method will be used by FileProtocol::mkdir and FileProtocol::chmod which > are not virtual method. So when called in windows this must return false for > the time being. So IMO ifdef or something similar is n

creating an index.theme file

2017-06-20 Thread René J . V . Bertin
Hi, A bit off-topic, but after my recent run-in with icon themes I had a look at the Breeze icons build system to see how it creates the binary resource. My own theme uses inheritance, so I think that in order to create an .rcc resource from it I'd first need to merge the themes it inherits, wh

Re: unwanted breeze('ish) icons in KFileWidget on Mac

2017-06-20 Thread René J . V . Bertin
Could it be I'll have to start hacking around in KIconLoader::loadMimeTypeIcon()?

Re: kxmlgui regression on OS X between 5.32.0 and 5.35.0

2017-06-20 Thread René J . V . Bertin
David Faure wrote: > * 78e572dadf - Revert "use transientparent directly" (7 days ago) > [] > * 4690808e65 - use transientparent directly (5 weeks ago) > Thanks, cherry-picking 78e572dadf resolves the issue without any further changes required. I'll check the proposed Qt change (provided

Re: unwanted breeze('ish) icons in KFileWidget on Mac

2017-06-20 Thread René J . V . Bertin
Sebastian Kügler wrote: > A screenshot says more than a thousand words... :) You asked for it ;) Snippets from KDevelop (1st) and Dolphin (2nd), kept as small as possible. The round icons with arrows and the silver'ish folder icons are from my custom icon theme (these sourced from Ciment), the

Re: unwanted breeze('ish) icons in KFileWidget on Mac

2017-06-20 Thread Sebastian Kügler
On dinsdag 20 juni 2017 16:10:59 CEST René J.V. Bertin wrote: > So where do those icons come from, and why are some applications immune? > Pointers highly appreciated! A screenshot says more than a thousand words... :) -- sebas http://www.kde.org | http://vizZzion.org

Re: unwanted breeze('ish) icons in KFileWidget on Mac

2017-06-20 Thread René J . V . Bertin
On Tuesday June 20 2017 16:10:59 René J.V. Bertin wrote: > Other applications like KDevelop still work as I expect them to, even in > their implementation of such navigation views. In case that helps: KDevelop does show the wrong icons for symlinks. R.

unwanted breeze('ish) icons in KFileWidget on Mac

2017-06-20 Thread René J . V . Bertin
Hi, I've been (less and less) mildly annoyed by the use of what looks like Breeze icons in what is probably the KFileWidget on Mac, where the same widget uses the user-selected theme on Linux. As you know I'm developing a platform theme plugin for Mac which among other things allows feature p

Re: kxmlgui regression on OS X between 5.32.0 and 5.35.0

2017-06-20 Thread René J . V . Bertin
On Tuesday June 20 2017 13:19:51 David Faure wrote: >k-f-d is the proper place for this discussion => CC'ed. I know, at least theoretically. In practice I didn't want to create noise there where it might not interest the majority and fail to reach the person(s) most likely to have an answer. Af

Re: kxmlgui regression on OS X between 5.32.0 and 5.35.0

2017-06-20 Thread David Faure
On mardi 20 juin 2017 13:01:29 CEST René J.V. Bertin wrote: > Hi, > > Apologies for writing you directly and not a generic mailing list. > > I noticed an issue that was introduced by one of the relatively few changes > to KXmlGui between v5.32.0 and v5.35.0 : the QtCurve configuration dialog > (h

D6279: API dox: add notes to KActionCollection about QAction ownership handling

2017-06-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. kossebau marked 2 inline comments as done. Closed by commit R263:951bc8a9b3c9: API dox: add notes to KActionCollection about QAction ownership handling (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.k

D6047: WIP: Support XDG v6

2017-06-20 Thread David Edmundson
davidedmundson updated this revision to Diff 15634. davidedmundson edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15020&id=15634 REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt autotests

D6198: Add KAuth support to delete operation

2017-06-20 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 15625. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Added unit tests and addressed minor issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6198?vs=15517&id=15625 REVISION DETAIL https://phab

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7 - Build # 12 - Fixed!

2017-06-20 Thread no-reply
BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.7/12/ Project: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 20 Jun 2017 08:15:11 + Build duration: 1 min 18 sec and counting

D6279: API dox: add notes to KActionCollection about QAction ownership handling

2017-06-20 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kactioncollection.h:325 > * > + * The ownership of the action object is not transferred. If the action > is destroyed > + * it will be removed automatical