kfunk updated this revision to Diff 15437.
kfunk added a comment.
Polishing
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6220?vs=15436&id=15437
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6220
AFFECTED FILES
data/CMakeL
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
CMake Warning (dev):
Policy CMP0058 is not set: Ninja requires custom command byproducts to be
explicit. Run "cmake --help-polic
hein added a comment.
I used to subclass in Simple Menu, but then eliminated the C++ plugin so I
could put it on the Store, so this is important for now.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6215
To: mart, #plasma, davidedmundson
Cc: he
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in dialog.cpp:1368-1370
> this is already done in updateVisibility which is effectively called from
>
> QQuickWindow::setVisible(visible);
>
> So we're just doing things twice.
>
> You've not really said what problem we're try
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dialog.cpp:1368-1370
> +if (d->mainItem) {
> +d->mainItem->setVisible(true);
> +d->syncToMainItemSi
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
introduce this new signal: make sure the size of the dialog
is final, sinced with the main item and the optional layout
I've investigated this failure.
It's initial cause was an upgrade of SIP, likely from Neon.
However it has revealed a weakness within the Python bindings code.
The header sip.h can be found at two places:
/usr/include/python3.5dm/sip.h
/usr/include/python3.5m/sip.h
It would appear that /usr/incl
BUILD FAILURE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/23/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Tue, 13 Jun 2017 08:40:43 +
Build duration:
1 min 24 sec and counting
CONS
This revision was automatically updated to reflect the committed changes.
Closed by commit R467:ddd546251022: Set organization name for Wayland icon.
(authored by lesliezhai).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5405?vs=13342&id=15416#toc
REPOSITORY
R467 K3b
CHANGES SINCE L
