This revision was automatically updated to reflect the committed changes.
Closed by commit R283:ada2dc24381b: Check error status after every
PolKitAuthority usage (authored by skalinichev).
REPOSITORY
R283 KAuth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5983?vs=14908&id=15127
R
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/19/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Sat, 03 Jun 2017 23:41:52 +
Build duration:
3 min 31 sec and counting
JUn
Kanedias added a comment.
In https://phabricator.kde.org/D1231#112772, @davidedmundson wrote:
>
> Would it benefit from a series of damage events being sent in the
org_kde_kwin_remote_buffer before the gbm_handle event?
> Kwin should have all this information available. O
Kanedias updated this revision to Diff 15125.
Kanedias added a reviewer: davidedmundson.
Kanedias added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
Rebased the protocol against latest KWayland branch.
Will update on the
dfaure added inline comments.
INLINE COMMENTS
> apol wrote in dialog.cpp:1141
> Maybe we should only wrap this one function call?
The error message is dialog.cpp:1166:17: error: ‘class
PlasmaQuick::DialogPrivate’ has no member named ‘shellSurface’, so no.
REPOSITORY
R242 Plasma Framework (Li
dfaure added a reviewer: davidedmundson.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5828
To: winterz, mart, davidedmundson
Cc: dfaure, asturmlechner, apol, #frameworks
dfaure added a comment.
Ping? This was reported by the packagers for KF5.35 as a build error, and it
seems the patch just needs review/approval.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5828
To: winterz, mart
Cc: dfaure, asturmlechner, apol
dfaure added inline comments.
INLINE COMMENTS
> kossebau wrote in CMakeLists.txt:55
> What about "Build API documentation in QCH format (for e.g. Qt Assistant, Qt
> Creator & KDevelop)"
I like it.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D3458
To: kossebau, #f
rakuco added a comment.
See also: https://git.reviewboard.kde.org/r/129246/
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D6076
To: tcberner, #freebsd, winterz
Cc: rakuco, #frameworks
tcberner updated this revision to Diff 15116.
tcberner added a comment.
Add find_programm(SH_EXE sh)
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6076?vs=15115&id=15116
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6076
AFFECTED F
tcberner updated this revision to Diff 15115.
tcberner added a comment.
- Fix cmake
- find_program call for xmllint
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6076?vs=15114&id=15115
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/
tcberner added a reviewer: winterz.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D6076
To: tcberner, #freebsd, winterz
Cc: #frameworks
tcberner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I don't think it makes sense, that the icons are xmllint'ed every time
someone builds the icons.
This is an action that should take plac
kossebau added inline comments.
INLINE COMMENTS
> dfaure wrote in CMakeLists.txt:55
> slightly cryptic for someone who wouldn't know what QCH is. You could add
> (for opening in Qt Assistant) or something similar?
>
> Then again these days people don't know what Assistant is, they use the
> em
BUILD SUCCESS
Build URL
https://build-sandbox.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Sat, 03 Jun 2017 14:19:04 +
Build duration:
1 min 44 sec and count
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/7/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Sat, 03 Jun 2017 12:21:11 +
Build duration:
1 min 47 sec and coun
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:187055408f59: fix warnings from clazy with the default
warning level (authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6070?vs=15104&id=1
dfaure reopened this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5856
To: dfaure, aacid
Cc: #frameworks
guoyunhe closed this revision.
guoyunhe added a comment.
Committed
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4289
To: guoyunhe, #plasma:_design, #plasma, davidedmundson
Cc: andreaska, guoyunhe, #frameworks
bcooksley created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Currently we've found that strict iterators as available in MSVC, with
certain codebases such as Threadweaver ca
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:07ef5b2d0d36: Use KDirWatch removeDir/addDir instead of
stopDirScan/restartDirScan (authored by dfaure).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5856?vs=14545&id
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e10f44d87270: Workaround for QTBUG-59017 (authored by
broulik, committed by dfaure).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6063?vs=15072&id=15107
REVISION DET
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
"first declared as a struct and later declared as a class" must indeed be
fixed. It's only a warning for clang, but AFAIK it leads to a hard error with
MSVC. So yes, this all looks good to
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4289
To: guoyunhe, #plasma:_design, #plasma, davidedmundson
Cc: andreaska, guoyunhe, #frameworks
dfaure added inline comments.
INLINE COMMENTS
> entryinternal.cpp:443
> +{
> +Q_ASSERT(xml->tokenType()==QXmlStreamReader::StartElement);
> +QStringRef ret;
missing spaces around ==
> entryinternal.cpp:446
> +const auto token = xml->readNext();
> +if (token==QXmlStreamReader::Ch
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/9/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Sat, 03 Jun 2017 09:19:53 +
Build duration:
19 min and counting
JUnit Tests
Name
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6063
To: broulik, kde-frameworks-devel, dfaure
Cc: #frameworks
On mardi 30 mai 2017 16:18:42 CEST Aleix Pol wrote:
> On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano
wrote:
> > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote:
> >> Is there a reason ECM's project is placed in kdesupport rather than
> >> frameworks?
> >>
> >> https://cgit.kde.org/sysa
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/18/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Sat, 03 Jun 2017 09:19:54 +
Build duration:
6 min 54 sec and counting
JUn
mgallien added a comment.
In https://phabricator.kde.org/D6070#113705, @apol wrote:
> I am not super sure about the struct -> class. Why?
I had missed the fact that the warnings where from clang and not clazy.
The compiler warns that the private class is first declared as a struc
mgallien updated this revision to Diff 15104.
mgallien added a comment.
replaced the at(0) by constFirst
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6070?vs=15100&id=15104
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6070
AFFEC
dfaure added a comment.
Great feature, will be very useful.
INLINE COMMENTS
> CMakeLists.txt:55
> +
> +option(BUILD_QCH "Build API documentation in QCH format" OFF)
> +add_feature_info(QCH ${BUILD_QCH} "API documentation in QCH format")
slightly cryptic for someone who wouldn't know what QCH
guoyunhe added a comment.
Any news about this icon? will it be approved?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4289
To: guoyunhe, #plasma:_design, #plasma
Cc: andreaska, guoyunhe, #frameworks
guoyunhe added a comment.
Could someone approve this patch? So I can commit it.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D5463
To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate
Cc: vkrause, dhaumann, #frameworks
34 matches
Mail list logo
