BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/10/
Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
Date of build:
Fri, 02 Jun 2017 05:56:27 +
Build duration:
3 min 19 sec and counting
skelly accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D5821
To: cfeck, #frameworks, skelly
Cc: mlaurent
cfeck added a comment.
ping?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D5821
To: cfeck, #frameworks
Cc: mlaurent
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/9/
Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 20:17:22 +
Build duration:
2 min 24 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:ccbad906db1b: Use explicit flag values or explicit
constructor instead of nullptr (authored by kossebau).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6054?
kossebau added a comment.
Checking the diff another time I find it would be even nicer to extend
`NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0`
value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g.
`Qt::ItemFlags`), so those enum value
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xdgshell_interface.h:80
> We need the serial Ids here, otherwise it's not very usable; especially as
> the pong doesn't have an elapsed time.
>
> A kjob like API wrapping this might be perfect for here?
so storing all the id
Hello,
I just discovered that the Control+Tab and Control+Shift+Tab shortcuts don't
work in KF5 applications on Mac:
- In a pure Qt application I can assign Control+Tab to an action (using
Qt::Meta+Qt::Key_Tab, evidently) and pressing the key combination will trigger
the action.
- In KF5, I ca
BUILD SUCCESS
Build URL
https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/11/
Project:
Frameworks ktexteditor kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 14:57:43 +
Build duration:
7 min 24 sec and counting
JUni
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/10/
Project:
Frameworks ktexteditor kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 14:18:07 +
Build duration:
6 min 56 sec and counting
JUn
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/9/
Project:
Frameworks ktexteditor kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 14:04:22 +
Build duration:
6 min 32 sec and counting
JUni
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130138/
---
(Updated June 1, 2017, 1:27 p.m.)
Status
--
This change has been dis
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130139/
---
(Updated June 1, 2017, 1:27 p.m.)
Status
--
This change has been dis
> On May 25, 2017, 2:36 p.m., René J.V. Bertin wrote:
> > See also https://phabricator.kde.org/D5972
agree that it should be fixed in ecm. Hope the fix can make it to the next
release of kf5-ecm so I can remove my hack from homebrew
- Harald
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/
---
(Updated June 1, 2017, 1:20 p.m.)
Status
--
This change has been dis
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks ktexteditor kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 12:53:43 +
Build duration:
7 min 11 sec and counting
JUni
davidedmundson added a comment.
Comments for Marco:
INLINE COMMENTS
> xdgshell_interface.h:80
>
> +void ping();
> +
We need the serial Ids here, otherwise it's not very usable; especially as the
pong doesn't have an elapsed time.
A kjob like API wrapping this might be perfect for her
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ff2e1d8e22fe: Use explicit flag values or explicit
constructor instead of nullptr (authored by kossebau).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6053
cfeck accepted this revision.
REPOSITORY
R236 KWidgetsAddons
BRANCH
nonullptrforflagsplease
REVISION DETAIL
https://phabricator.kde.org/D6053
To: kossebau, #frameworks, cfeck, kfunk
Cc: kfunk
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
nonullptrforflagsplease
REVISION DETAIL
https://phabricator.kde.org/D6054
To: kossebau, #plasma, graesslin, kfunk
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
kossebau added inline comments.
INLINE COMMENTS
> cfeck wrote in kfontrequester.cpp:187
> Does removing the default value mean the flags would be now uninitialized?
No, the constructor called would be (as before)
`QFlags::QFlags(Zero zero = Q_NULLPTR)`, so
still default to 0 internally, so wit
kfunk accepted this revision.
kfunk added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> cfeck wrote in kfontrequester.cpp:187
> Does removing the default value mean the flags would be now uninitialized?
No, `QFontDialog::FontDialogOptions` is a `QFlags<>` wh
cfeck added inline comments.
INLINE COMMENTS
> kfontrequester.cpp:187
> {
> -QFontDialog::FontDialogOptions flags = nullptr;
> +QFontDialog::FontDialogOptions flags;
> if (m_onlyFixed) {
Does removing the default value mean the flags would be now uninitialized?
REPOSITORY
R236 K
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:7dfdace2b445: Consistently emit
MouseEventListener::pressed signal (authored by apol).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5979?vs=14866&id=15045
R
elvisangelaccio abandoned this revision.
elvisangelaccio added a comment.
Fixed with https://phabricator.kde.org/D6045.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D6016
To: elvisangelaccio, dfaure
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:ce0b8de001b3: Set main window as parent of stand-alone
popup menus (authored by elvisangelaccio).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6045?vs=15010&id=15
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5979
To: apol, #frameworks, davidedmundson
Cc: broulik, davidedmundson
27 matches
Mail list logo
