dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6045
To: elvisangelaccio, dfaure
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 01:02:28 +
Build duration:
3 min 9 sec and counting
J
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/7/
Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 00:48:32 +
Build duration:
2 min 51 sec and counting
kossebau created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The constructor of QFlags which was intended to handle literal "0"
as commonly used indicator of no-flags-set has been
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/7/
Project:
Frameworks ktexteditor kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 00:33:27 +
Build duration:
8 min 20 sec and counting
JUni
BUILD SUCCESS
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/10/
Project:
Frameworks kdeclarative kf5-qt5 XenialQt5.7
Date of build:
Thu, 01 Jun 2017 00:14:35 +
Build duration:
1 min 37 sec and counting
JU
kossebau created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The constructor of QFlags which was intended to handle literal "0"
as commonly used indicator of no-flags-set has been done with a
trick based on pointer types. Which these days of nullptr ex
apol added a comment.
In https://phabricator.kde.org/D5979#112068, @davidedmundson wrote:
> What things are not consistent?
connect(m_listener, &MEL::pressed, this, &ThisClass:blah);
void ThisClass::blah()
{
if (m_listener->isPressed()) changeSomethingN
apol added a comment.
Yes sure.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6041
To: apol, #frameworks, #plasma, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg
davidedmundson updated this revision to Diff 15020.
davidedmundson added a comment.
Arc didn't work, I think it was too big.
Manually uploading the patch did.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6047?vs=15013&id=15020
REVISION DETAIL
https://phabricator.kde.org/D6047
adridg added reviewers: whiting, Frameworks.
adridg added a comment.
(also, this repo has a .reviewboardrc but no .arcconfig)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6049
To: adridg, whiting, #frameworks
Cc: #frameworks
adridg created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- Helper function constructs a permutation of the list of menu-items that
need to be sorted, then sorts and tests.
- Test ten permutations
davidedmundson added a comment.
Can we wait till after the next release is tagged as that's super soon and
this isn't that important.
We've had major bugs porting stuff in this area before.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6041
To: apol, #frameworks, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, al
apol updated this revision to Diff 15015.
apol marked an inline comment as done.
apol added a comment.
Address Marco's comments
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6041?vs=15003&id=15015
BRANCH
master
REVISION DETAIL
http
apol marked 2 inline comments as done.
apol added inline comments.
INLINE COMMENTS
> mart wrote in appletquickitem.h:105
> despite the warning in the header, this ended up being an exported symbol, so
> binary compatibility rules apply here too.
> Plasma::Package appletPackage() const; has to st
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/9/
Project:
Frameworks kdeclarative kf5-qt5 XenialQt5.7
Date of build:
Wed, 31 May 2017 10:40:28 +
Build duration:
1 min 33 sec and counting
JU
davidedmundson abandoned this revision.
davidedmundson added a comment.
Flipping phabricator...
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6047
To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jen
davidedmundson created this revision.
davidedmundson added projects: Plasma on Wayland, Frameworks.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
REVISION SUMMARY
To move forward faster I thought we could start reviewing the
davidedmundson/xdgv6 branch for the
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Stand-alone popup menus are elements that are children of the
top-level element. Their initial parent is nullptr, but if we are
davidedmundson abandoned this revision.
davidedmundson added a comment.
I was hoping to put anything that affected v5 in a separate commits, with v6
separate, but that didn't really happen.
Will include with the other stuff.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricat
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pluginloader.h:208
> + **/
> +PLASMA_DEPRECATED KPluginInfo::List listAppletInfoForMimeType(const
> QString &mimetype);
> +
wow, phab isn't that smart in
BUILD UNSTABLE
Build URL
https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks kdeclarative kf5-qt5 XenialQt5.7
Date of build:
Wed, 31 May 2017 09:08:53 +
Build duration:
2 min 5 sec and counting
JUn
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:695f24fb522a: Don't leak MimeData object (authored by
davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6017?vs=14959&id=15008
REVISION DETAIL
hein accepted this revision.
hein added a comment.
Sounds good
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart, hein
Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohame
davidedmundson added a comment.
> So you're cleaning up the leak the next time the getter is accessed?
No? If it's accessed again m_data is not null so we don't get in that branch
The main cleanup is implicitly in the DeclarativeDropEvent destructor
REPOSITORY
R296 KDeclarative
BR
hein added a comment.
So you're cleaning up the leak the next time the getter is accessed? What if
this never happens?
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart
Cc: hein, plasma-devel, #frameworks, Z
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6017
To: davidedmundson, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed
28 matches
Mail list logo
