D5981: Fix compilation of Python bindings

lbeltrame added a comment. I'll try to test and report back. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid Cc: lbeltrame, #frameworks

D5981: Fix compilation of Python bindings

lbeltrame added a reviewer: lbeltrame. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid, lbeltrame Cc: lbeltrame, #frameworks

KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/10/ Project: Frameworks kiconthemes kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 06:35:27 + Build duration: 1 min 2 sec and counting JUni

D5975: breeze-icons: don't look for bash on Windows

winterz added a comment. Because Hannah told me the script doesn't work on Windows. let's look at validate-svg.sh. you need a working unix 'find' command (not the WIndows find command) as well as xmllint for the bash script to work. REPOSITORY R266 Breeze Icons REVISION DETAIL htt

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

heikobecker added a comment. Ping? Not sure what to do with this, still would like to hear something from @skelly. Or should I just go ahead and use ClangConfig.cmake (meaning dropping the version requirement, I don't have any older clang versions around to easily test it.) REPOSITORY R24

D5981: Fix compilation of Python bindings

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY We only need to pass TRANSLATION_DOMAIN when compiling the C++ code since it's the only part that contains i18n() calls. Reason: The kloc

Re: Problems with Python bindings in KF5

El dijous, 25 de maig de 2017, a les 1:02:58 CEST, Stephen Kelly va escriure: > On 04/15/2017 10:53 PM, Luca Beltrame wrote: > > I can't understand the error thrown by ki18n (when it does not build) or > > I'd have attempted to fix it myself... > > Hi, sorry for my delayed response. > > Should we

D5975: breeze-icons: don't look for bash on Windows

aacid added a comment. I don't understand, you say it has bash, so why are you commenting out the bash related code? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5975 To: winterz Cc: aacid, #frameworks

D5979: Consistently emit MouseEventListener::pressed signal

apol updated this revision to Diff 14866. apol added a comment. Removed unrelated changes REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5979?vs=14865&id=14866 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5979 AFFECTED FILES src/

D5979: Consistently emit MouseEventListener::pressed signal

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Update the state before emitting, otherwise things could be not consistent REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D5979 AFFECTED FILES src/

D5966: Fix race-condition in KRandom-seeding.

tfry updated this revision to Diff 14863. tfry added a comment. Switch to QThreadStorage, use quintptr as suggested, add auto-test. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5966?vs=14831&id=14863 BRANCH master REVISION DETAIL https://phabric

D5975: breeze-icons: don't look for bash on Windows

winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The GoW package on Windows has bash. We don't want to find bash on Windows. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabr

D5550: Fix property changes being missed immediately after an obejct is added

This revision was automatically updated to reflect the committed changes. Closed by commit R269:c02c4806c9bf: Fix property changes being missed immediately after an obejct is added (authored by drosca). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5550?vs=13

D5970: Fix KSNIs being unable to register service under flatpak

This revision was automatically updated to reflect the committed changes. Closed by commit R289:2b0b904ee0e9: Fix KSNIs being unable to register service under flatpak (authored by davidedmundson). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5970?vs=1

D5970: Fix KSNIs being unable to register service under flatpak

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D5970 To: davidedmundson, #frameworks, jgrulich Cc: jgrulich

D5970: Fix KSNIs being unable to register service under flatpak

jgrulich added a comment. +1 I tested this change with flatpak and it works as it should. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5970 To: davidedmundson, #frameworks Cc: jgrulich

D5966: Fix race-condition in KRandom-seeding.

tfry added a comment. In https://phabricator.kde.org/D5966#111878, @rjvbb wrote: > but I also didn't verify if QSet::insert is thread-safe. Ouch, you're right, it isn't. QThreadStorage it shall be, then (until we can use thread_local). That also handles thread-destruction, properl

D5966: Fix race-condition in KRandom-seeding.

rjvbb added a comment. Using QSet was my suggestion, if cheaper than QThreadStorage - something I didn't check, but I also didn't verify if QSet::insert is thread-safe. About C++11: since when exactly does Qt require C++11 again? REPOSITORY R244 KCoreAddons REVISION DETAIL https://p