Re: Problems with Python bindings in KF5

On 04/15/2017 10:53 PM, Luca Beltrame wrote: > I can't understand the error thrown by ki18n (when it does not build) or I'd > have attempted to fix it myself... Hi, sorry for my delayed response. Should we disable the ki18n bindings at this point? I'm fine with doing that until someone can repro

D5966: Fix race-condition in KRandom-seeding.

rjvbb added a comment. I was going to reflect that it would be better to set `init` in an atomic operation, but: In https://phabricator.kde.org/D5966#111735, @tfry wrote: > On further investigation, I see that qsrand() would probably have to be called for //each// thread, in any cas

D5966: Fix race-condition in KRandom-seeding.

tfry added a comment. On further investigation, I see that qsrand() would probably have to be called for //each// thread, in any case. So that would mean keeping track of initialization state in a QThreadStorage? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5

D5775: Don't include the pid in the dbus path when on flatpak

This revision was automatically updated to reflect the committed changes. Closed by commit R271:8b79a5374afc: Don't include the pid in the dbus path when on flatpak (authored by apol). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5775?vs=14782&id=14825

D5775: Don't include the pid in the dbus path when on flatpak

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R271 KDBusAddons BRANCH arcpatch-D5775 REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich, aacid Cc: dfaure, davidedmundson, aacid

D5966: Fix race-condition in KRandom-seeding.

tfry created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Consider the following scenario: Thread A calls KRandom::random(), for the first time. It will now go through a (relatively) expensive proced

D5912: minimize dialog resizes/moves

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D5912 REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #fr

D5912: minimize dialog resizes/moves

davidedmundson added a comment. Offtopic, but in future can you adjust the summary when rewriting a patch rather than leaving a comment, it's easier to read. Phab still keeps the history if we need it. So this is for fixing when we have a mainItem whose size is bigger/smaller than its o

D5912: minimize dialog resizes/moves

broulik added inline comments. INLINE COMMENTS > dialog.cpp:487 > +} > +Q_ASSERT(mainItem); > +Q_ASSERT(mainItemLayout); Those asserts are redundant now REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein, davide

D5912: minimize dialog resizes/moves

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in tooltipdialog.cpp:45 > Calling set flags explicitly and set type explicitly is conflicting. now just uses settype, tested on x11, still works and tooltip windows still has _NET_WM_WINDOW_TYPE_TOOLTIP settype is needed in wayl

D5912: minimize dialog resizes/moves

mart updated this revision to Diff 14809. mart added a comment. - use settype, not setflags REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5912?vs=14690&id=14809 BRANCH arcpatch-D5912 REVISION DETAIL https://phabricator.kde.org/D591

D5912: minimize dialog resizes/moves

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > tooltipdialog.cpp:45 > setLocation(Plasma::Types::Floating); > +setType(Dialog::WindowType::Tooltip); > Calling set flags explicitl

D5912: minimize dialog resizes/moves

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/dialogresize REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma, hein Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, prog

D5912: minimize dialog resizes/moves

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5912 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, luka

D5757: add requestToggleKeepAbove/below

This revision was automatically updated to reflect the committed changes. Closed by commit R127:e8e88174571c: add requestToggleKeepAbove/below (authored by mart). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5757?vs=14582&id=14807 REVISION DETAIL https:/

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. In https://phabricator.kde.org/D5802#109416, @mwolff wrote: > Then I can also apply the patch locally and try it out myself and maybe come up with a concrete idea to fix this all. So, do you have any ideas? REPOSITORY R39 KTextEditor REVISION DETAIL