D5783: Use application name instead of pid when creating SNI dbus service

jgrulich updated this revision to Diff 14361. jgrulich added a comment. Remove my useless debug REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5783?vs=14360&id=14361 BRANCH application-dbus (branched from master) REVISION DETAIL https://phabric

D5783: Use application name instead of pid when creating SNI dbus service

jgrulich updated this revision to Diff 14360. jgrulich added a comment. Use applicationName() instead of applicationPid() only for sandboxed applications This still doesn't make the service name unique, but at least there won't be collision between instances running outside the sandbox

D5783: Use application name instead of pid when creating SNI dbus service

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. are we sure applicationname is unique? what about of multiple instances of the same application? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5783

D5783: Use application name instead of pid when creating SNI dbus service

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. are we sure applicationname is unique? what about of multiple instances of the same application? REPOSITORY R289 KNotifications BRANCH application-dbus (branched from master) REVISION DET

D5788: Add syntax highlighting for YANG data modeling language

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. The patch looks good to me. Can you please also add a unit test for this? We try to have as many highlighting unit tests as possible... The unit test highlighting file should preferably

D5788: Add syntax highlighting for YANG data modeling language

nalvarez created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add syntax highlighting for YANG data modeling language, based on yang.vim .

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner planned changes to this revision. tcberner added a comment. I agree. I'll try and figure out whats wrong inside QStorageInfo, and then update the review here to be using it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd Cc: kfunk

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. Okay, then maybe support for the current FreeBSD version is not implemented? I have no idea about FreeBSD, to be honest. But it looks like using this API, and implementing the proper support in `QStorageInfo` internals would be the appropriate place. Anyhow, if Qt

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner added a comment. Hm, QStorageInfo does not seem to return anything sensible on FreeBSD: "" name: "" fileSystemType: "" size: 0 MB availableSize: 0 MB This is the output from the `QStorageInfo::root()` example. REPOSITORY R293 Baloo REVISION DETAIL http

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. What about http://doc.qt.io/qt-5/qstorageinfo.html#fileSystemType? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd Cc: kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is not really needed at the moment, as it only seems to be needed to check if the filesystem is btrfs. I'm however not sure, if t

D5775: Don't include the pid in the dbus path when on flatpak

aacid added a comment. This means we get the same path if we start the process twice, does it still work? Don't you get some kind of collision at the dbus level? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich Cc: aacid

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On May 4, 2017, 12:40 p.m., Albert Astals Cid wrote: > > Lamarque, you broke the build. > > Lamarque Souza wrote: > Fixed. Thanks for the quick report about the broken build and sorry for > not adding all files to the commit. > > Ben Cooksley wrote: > This patch broke the MSVC build

D5783: Use application name instead of pid when creating SNI dbus service

jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is required when using SNI in sandbox (e.g. in flatpak) where the pid starts from 1, usually it is 2 (the first one is bwrap) and th

D5783: Use application name instead of pid when creating SNI dbus service

jgrulich added a reviewer: apol. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5783 To: jgrulich, apol Cc: #frameworks