D4711: Ungrab mouse on menu close

2017-04-29 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 14014. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4711?vs=11600&id=14014 REVISION DETAIL https://phabricator.kde.org/D4711 AFFECTED FILES src/scriptengines/qml/plasmoid/appletinterface.cp

D4711: Ungrab mouse on menu close

2017-04-29 Thread Anthony Fieroni
anthonyfieroni added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 To: anthonyfieroni, #plasma, mart, broulik, davidedmundson Cc: mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, ali-mohamed, je

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-04-29 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review103158 --- ping apps 17.04 are out, this ca be useful - Anthony Fieron

D5394: KAuth integration in document saving - vol. 2

2017-04-29 Thread Martin Kostolný
martinkostolny added a comment. One more thing I've changed in the last diff: When creating a new file in privileged directory, the file is then set to be readable by group and others. This is because kate wouldn't be able to read it later with regular user who managed to create it in the f

D5394: KAuth integration in document saving - vol. 2

2017-04-29 Thread Martin Kostolný
martinkostolny updated this revision to Diff 14013. martinkostolny added a comment. Thanks for noticing the security issues! And sorry for the pause. Here is an updated diff which should ensure, QFile is using relative path. I've managed to reduce the use of absolute paths to this state - str

D5646: Solve problem with microphone-sensitivity-medium

2017-04-29 Thread Luigi Toscano
ltoscano added a comment. So this should rebased on top of the current master, I guess REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5646 To: patrickelectric, #kate, andreaska Cc: ltoscano, winterz, #frameworks

D5656: Adds method to force the reloading of a document

2017-04-29 Thread Pedro Arthur P. R. Duarte
pedroarthurp added reviewers: dfaure, brauch, dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5656 To: pedroarthurp, dfaure, brauch, dhaumann, cullmann Cc: kwrite-devel, #frameworks

D5646: Solve problem with microphone-sensitivity-medium

2017-04-29 Thread Allen Winter
winterz added a comment. my commit was a hack to get the validator to pass. this patch is far more extensive. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5646 To: patrickelectric, #kate, andreaska Cc: ltoscano, winterz, #frameworks

D5656: Adds method to force the reloading of a document

2017-04-29 Thread Pedro Arthur P. R. Duarte
pedroarthurp created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Currently, `KTextEditor::Document::documentReload()` shows a dialog asking the user if he/she wants to reload a file from

D5645: Add Arduino extension

2017-04-29 Thread patrick j pereira
This revision was automatically updated to reflect the committed changes. Closed by commit R216:ba8ed1f28885: Add Arduino extension (authored by patrickelectric). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5645?vs=13945&id=13985 REVISION DETAI

D5645: Add Arduino extension

2017-04-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Strange endings but the internet tells me they are used for that. REPOSITORY R216 Syntax Highlighting BRANCH arduino REVISION DETAIL https://phabricator.kde.org/D5645 To: patric

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-29 Thread Lamarque Souza
> On April 28, 2017, 1:28 p.m., Lamarque Souza wrote: > > Ship It! > > KJ Tsanaktsidis wrote: > Great - thanks for your help and for bearing with my rusty C++! What > happens now? I'm waiting on this patch to land for another patch I submitted > a while ago: https://git.reviewboard.kde.org

D5646: Solve problem with microphone-sensitivity-medium

2017-04-29 Thread Luigi Toscano
ltoscano added subscribers: winterz, ltoscano. ltoscano added a comment. @winterz committed https://phabricator.kde.org/R266:2b49fafc60235a83ffd8b92a24f800d622cc3050 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5646 To: patrickelectric, #kate, andreaska Cc:

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 561 - Fixed!

2017-04-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/561/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Apr 2017 11:35:01 + Build duration: 14 min CHANGE SET Revision 2b49fafc60235a83ffd8b92a24f800d622cc305

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 561 - Fixed!

2017-04-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/561/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Apr 2017 11:35:01 + Build duration: 14 min CHANGE SET Revision 2b49fafc60235a83ffd8b92a24f800d622cc305

Breeze Icons Compilation Failure

2017-04-29 Thread Ben Cooksley
Hi all, Is there some reason why the Breeze Icons repository was left broken for two days? Having a Frameworks level repository broken for two days (given we have monthly release windows) isn't exactly the best look. As a reminder to everyone, it is an obligation of contributors to only commit/p

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 560 - Fixed!

2017-04-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/560/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Apr 2017 11:35:01 + Build duration: 3 min 27 sec CHANGE SET Revision 2b49fafc60235a83ffd8b92a24

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 560 - Fixed!

2017-04-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/560/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Apr 2017 11:35:01 + Build duration: 3 min 27 sec CHANGE SET Revision 2b49fafc60235a83ffd8b92a24

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-29 Thread KJ Tsanaktsidis
> On April 28, 2017, 1:28 p.m., Lamarque Souza wrote: > > Ship It! Great - thanks for your help and for bearing with my rusty C++! What happens now? I'm waiting on this patch to land for another patch I submitted a while ago: https://git.reviewboard.kde.org/r/130084/ - KJ -