lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Looks fairly harmless to me. Perhaps wait one or two days more to see if
anyone chimes in.
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D563
lbeltrame added a reviewer: andreaska.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5646
To: patrickelectric, #kate, andreaska
Cc: #frameworks
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/539/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 29 Apr 2017 02:08:41 +
Build duration: 6 min 26 sec
CHANGE SET
Revision a8392c679f2b8bdb80cde357de8d8c1c979a0a19 b
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/539/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 29 Apr 2017 02:08:41 +
Build duration: 6 min 26 sec
CHANGE SET
Revision a8392c679f2b8bdb80cde357de8d8c1c979a0a19 b
apol added a reviewer: Kate.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D5646
To: patrickelectric, #kate
Cc: #frameworks
apol added a reviewer: Kate.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D5645
To: patrickelectric, #kate
Cc: #frameworks
patrickelectric created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
error: Namespace prefix inkscape for connector-curvature on path is not
defined
class="ColorScheme-Text" />
Signed-off-
patrickelectric created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Signed-off-by: Patrick José Pereira
REPOSITORY
R216 Syntax Highlighting
BRANCH
arduino
REVISION DETAIL
https://phabricator.
xuetianweng added a comment.
I saw there's filesearchstoretest.cpp in autotests/integration, but
CMakeLists.txt doesn't build it. I guess this test might not work yet.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D5631
To: xuetianweng, #frameworks
Cc: lbeltrame
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/538/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 28 Apr 2017 15:22:40 +
Build duration: 14 min
CHANGE SET
Revision f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8 by Elv
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/538/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 28 Apr 2017 15:22:40 +
Build duration: 13 min
CHANGE SET
Revision f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/538/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 28 Apr 2017 15:22:40 +
Build duration: 13 min
CHANGE SET
Revision f29bbfb1c17dbfa92b27fa6d5a1c86b06a71a6b8
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128574/
---
(Updated April 28, 2017, 3:22 p.m.)
Status
--
This change has been m
apol added a comment.
Won't caching already fix the problem of traffic there? This change adds
quite some complexity (all these QMutex make me cringe, these methods should
always be called from the same thread anyway...)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.
apol added inline comments.
INLINE COMMENTS
> httpworker.cpp:33
> +
> +Q_GLOBAL_STATIC(QNetworkAccessManager, NetworkManager)
> +Q_GLOBAL_STATIC(QMutex, NetworkManagerMutex)
How about getting a class with these 3 attributes? Looks like we're juggling
here...
REPOSITORY
R304 KNewStuff
REVISI
> On April 28, 2017, 12:44 p.m., Elvis Angelaccio wrote:
> > Thanks. Do you have commit access?
Nope.
So now I wait. (Again.) :)
- Mathis
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130090/#review103148
---
Ship it!
Ship It!
- Lamarque Souza
On April 23, 2017,
leinir created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This is a two layer approach to creating less network traffic when
initialising a KNSCore::Engine:
- Firstly, cache the xml documents th
leinir created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Use a single QNetworkAccessManager instance for all our HTTP jobs, and also
add a simple diskcache to that qnam. Further ensure there is only
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128574/#review103147
---
Ship it!
Thanks. Do you have commit access?
- Elvis Ange
lbeltrame added a comment.
+1, I assume there are no tests for this functionality already present?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D5631
To: xuetianweng, #frameworks
Cc: lbeltrame
xuetianweng created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
canonicalPath() does not include the file name, but only the directory
name. Should use canonicalFilePath() instead.
TEST PLAN
Manually test with baloosearch
REPOSITORY
R293 Baloo
BRA
22 matches
Mail list logo
