Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-21 Thread KJ Tsanaktsidis
> On April 20, 2017, 4:19 p.m., Lamarque Souza wrote: > > autotests/fakeUdisks2.h, line 35 > > > > > > It is common practice to pass QString parameters QString as const &: > > > > FakeUdisks2BlockDevice(Q

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

2017-04-21 Thread KJ Tsanaktsidis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/ --- (Updated April 22, 2017, 12:38 a.m.) Review request for KDE Frameworks.

D5286: QtCurve alternative style for named menu section headers

2017-04-21 Thread René J . V . Bertin
rjvbb closed this revision. rjvbb added a comment. Submitted: https://commits.kde.org/qtcurve/88296597a57eaac7849aaa2feb201cba3a9213b4 REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D5286 To: rjvbb, yuyichao Cc: #plasma, kde-mac, #frameworks

D5286: QtCurve alternative style for named menu section headers

2017-04-21 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5286#103899, @yuyichao wrote: > Assuming the coordinate calculations are correct (which I can never get right without seeing the result) this LGTM. They can't be completely wrong as I have now used the new mode for a while an

Re: Threadweaver compilation failure: Windows

2017-04-21 Thread Ben Cooksley
On Fri, Apr 21, 2017 at 11:43 PM, Alexey Min wrote: > P.S.: But it built fine when I changed -DQT_STRICT_ITERATORS to > -UQT_STRICT_ITERATORS in CXX_DEFINES. This affects class > QTypedArrayData ( > http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qarraydata.h#n131 > ) maybe someone wil

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 165 - Fixed!

2017-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Apr 2017 16:18:12 + Build duration: 1 min 13 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 165 - Fixed!

2017-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Apr 2017 16:18:12 + Build duration: 1 min 13 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 187 - Fixed!

2017-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/187/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 21 Apr 2017 16:12:15 + Build duration: 2 min 22 sec CHANGE SET No changes

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 187 - Fixed!

2017-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/187/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 21 Apr 2017 16:12:15 + Build duration: 2 min 22 sec CHANGE SET No changes

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 165 - Fixed!

2017-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Apr 2017 16:12:15 + Build duration: 1 min 11 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 165 - Fixed!

2017-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Apr 2017 16:12:15 + Build duration: 1 min 11 sec CHANGE SET No changes JUNIT RESULTS Name:

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

2017-04-21 Thread Kevin Funk
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c56cf46b4beb: Sanitizers: Don't use GCC-like flags for e.g. MSVC (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5489?vs=13555&id=13

D5286: QtCurve alternative style for named menu section headers

2017-04-21 Thread Yichao Yu
yuyichao accepted this revision. yuyichao added a comment. This revision is now accepted and ready to land. Assuming the coordinate calculations are correct (which I can never get right without seeing the result) this LGTM. There was a previous issue on scaled display but I guess this sho

D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

2017-04-21 Thread Friedrich W. H. Kossebau
kossebau added a comment. This revision now requires changes to proceed. Ping. Is there anything wrong that would need to be improved in the current patch, or can this go in as is? Adding an official note to the constructor to not create a KAboutData instance before the QApp instance is

D5286: QtCurve alternative style for named menu section headers

2017-04-21 Thread René J . V . Bertin
rjvbb retitled this revision from "QtCurve alternative style for named menu section headers (WIP)" to "QtCurve alternative style for named menu section headers". REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D5286 To: rjvbb, yuyichao Cc: #plasma, kde-mac, #frameworks

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5521#103818, @palokisa wrote: > In https://phabricator.kde.org/D5521#103810, @graesslin wrote: > > > The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData. > > > I've had

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Palo Kisa
palokisa added a comment. In https://phabricator.kde.org/D5521#103810, @graesslin wrote: > The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData. I've had a look... and the plugins are also handled by there are more of them: `KPlu

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Martin Gräßlin
graesslin added a comment. oh and yes for removing service dependency please open a separate review. The other dependencies: well KCoreAddons is needed for KCrash only IIRC. That is setting the KAboutData. So a possibility could be to move the binary out and replace it by a binary which does

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D5521#103778, @palokisa wrote: > In https://phabricator.kde.org/D5521#103775, @cfeck wrote: > > > Btw, libKF5GlobalAccel is actually Tier1, so applications needing global shortcuts will not have any (additional) KF5 dependencie

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-21 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R236:8a1c758516fd: KPasswordDialog: don't hide visibility action in plaintext mode (authored by elvisangelaccio). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5

D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode

2017-04-21 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R236:6976a54f2355: KNewPasswordWidget: don't hide visibility action in plaintext mode (authored by elvisangelaccio). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-21 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ok, I just wanted to be sure :) REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5534: Fix ki18n bootstrapping

2017-04-21 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R249:c187a59514e8: Fix ki18n bootstrapping (authored by apol). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5534?vs=13663&id=13664 REVISION DETAIL https://phabricator.

D5534: Fix ki18n bootstrapping

2017-04-21 Thread Harald Sitter
sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D5534 To: apol, #frameworks, sitter

D5534: Fix ki18n bootstrapping

2017-04-21 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 13663. apol added a comment. add comment REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5534?vs=13662&id=13663 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5534 AFFECTED FILES CMakeLists.txt To: apol,

D5534: Fix ki18n bootstrapping

2017-04-21 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY We are not including the macros file through find_package in this case but directly including it, so set up the information the scripts will need. REPOSITORY R249 KI18n BRANCH master REVISIO

Re: Threadweaver compilation failure: Windows

2017-04-21 Thread Alexey Min
P.S.: But it built fine when I changed -DQT_STRICT_ITERATORS to -UQT_STRICT_ITERATORS in CXX_DEFINES. This affects class QTypedArrayData ( http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qarraydata.h#n131 ) maybe someone will have some clever thoughts with this info. 2017-04-21 15:46 G

Re: Threadweaver compilation failure: Windows

2017-04-21 Thread Kevin Funk
On Friday, 21 April 2017 15:46:58 CEST Alexey Min wrote: > Ok, I created "Debug" caft build environment and repeated build with > cmake parameters you asked, and I guess it shows exactly the same > build log with exactly the same error in the end - > https://paste.kde.org/p8wj1dqzf > Looks like a p

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Palo Kisa
palokisa added a comment. In https://phabricator.kde.org/D5521#103775, @cfeck wrote: > Btw, libKF5GlobalAccel is actually Tier1, so applications needing global shortcuts will not have any (additional) KF5 dependencies, only the runtime has. But without the runtime the application

Re: Threadweaver compilation failure: Windows

2017-04-21 Thread Alexey Min
Ok, I created "Debug" caft build environment and repeated build with cmake parameters you asked, and I guess it shows exactly the same build log with exactly the same error in the end - https://paste.kde.org/p8wj1dqzf Looks like a problem in STL header with debug iterator? Compiler unable to find p

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Christoph Feck
cfeck added a comment. I can confirm that kglobalaccel does not need the KF5Service dependency (neither the library does, nor the runtime). While it is listed in the link dependencies, no symbol is pulled from the library, so dependency can just be removed. Btw, libKF5GlobalAccel is act

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Palo Kisa
palokisa added a comment. What is `KF5::Service` used for? You don't seem to be `#ifdef` it. Maybe it's not needed at all? >>> >>> I don't know. I didn't investigate that.I thought, it's some kind of "self-initializing" component and it is enough to link the library. >> >>

D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

2017-04-21 Thread Palo Kisa
palokisa added a comment. > The obvious reason is that it would be impossible to install frameworks and lxqt at the same time. Why? With the aforementioned package names example: frameworks will provide `foo` by `foo-kde` and `foo-lxqt`. LXQt will require `foo` and KDE will (strictly)

Re: KTextEditor : best way to add background vertical guide lines?

2017-04-21 Thread René J . V . Bertin
Dominik Haumann wrote: Hi Dominik, > This discussion belongs to kwrite-de...@kde.org. Forgive me if I prefer not to subscribe to another ML just yet... > The KTextEditor::View can only display one vertical indicator. > Is that what you mean? I didn't know that, I looked for ways to activate ma