D5521: Allow the KGlobalAccel be a "Tier 2" framework, if needed

palokisa created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY By using the MINIMAL_RUNTIME_DEPS we allow minimizing the run-time dependencies -> remove the KCrash & KService dependency/usage. Wit

Jenkins-kde-ci: kactivities master kf5-qt5 » Linux,gcc - Build # 534 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/534/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 02:24:36 + Build duration: 16 min CHANGE SET No changes

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 552 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/552/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 02:24:36 + Build duration: 15 min CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 527 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/527/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 02:15:09 + Build duration: 22 min CHANGE SET Revision 2180b75251e560f014f15849fab86c225d005f5b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 527 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/527/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 02:15:09 + Build duration: 22 min CHANGE SET Revision 2180b75251e560f014f15849fab86c225d005f5b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 526 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/526/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 00:54:24 + Build duration: 7 min 39 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 525 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/525/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 00:35:51 + Build duration: 6 min 23 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 525 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/525/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 20 Apr 2017 00:35:51 + Build duration: 6 min 23 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 228 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/228/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 23:22:20 + Build duration: 5 min 41 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 228 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/228/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 23:22:20 + Build duration: 5 min 41 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 180 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/180/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 19 Apr 2017 22:52:19 + Build duration: 59 sec CHANGE SET No chang

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 180 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/180/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 19 Apr 2017 22:52:19 + Build duration: 59 sec CHANGE SET No chang

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 227 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/227/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 22:51:55 + Build duration: 1 min 50 sec CHANGE SET No changes

D5394: KAuth integration in document saving - vol. 2

martinkostolny updated this revision to Diff 13621. martinkostolny added a comment. Understood and implemented by switching to "current directory" where the final rename is taking place. This way I could use filenames only rename. Hopefully I didn't miss anything. One other issue I've no

D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation

This revision was automatically updated to reflect the committed changes. Closed by commit R293:74601ed37da9: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation (authored by alexeymin, committed by ltoscano). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https

D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation

ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Thanks! Do you have a developer account (aka: can you commit it possibly with arcanist)? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5516 To: alexeymin, #fr

D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation

alexeymin updated this revision to Diff 13616. alexeymin added a comment. Removed spaces at the beginning of the blank line REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5516?vs=13615&id=13616 REVISION DETAIL https://phabricator.kde.org/D5516 AFFECTED FI

D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation

ltoscano added inline comments. INLINE COMMENTS > main.cpp:68 > +QCoreApplication app(argc, argv); > + > KAboutData aboutData(QStringLiteral("baloo"), i18n("balooctl"), > PROJECT_VERSION); small nit: remove the whitespaces here > main.cpp:39 > +QCoreApplication app(argc, argv)

D5516: balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation

alexeymin retitled this revision from "balooshow: Fix order of QApplication object creation" to "balooctl, baloosearch, balooshow: Fix order of QCoreApplication object creation". alexeymin edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org

D5516: balooshow: Fix order of QApplication object creation

ltoscano added a comment. Can you please update the commit message as well? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5516 To: alexeymin, #frameworks, aacid, ltoscano Cc: ltoscano

D5516: balooshow: Fix order of QApplication object creation

alexeymin updated this revision to Diff 13615. alexeymin added a comment. Fixed this also in balooctl and baloosearch. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5516?vs=13613&id=13615 REVISION DETAIL https://phabricator.kde.org/D5516 AFFECTED FILES

D5515: Update the ungrabMouse hack for Qt 5.8

anthonyfieroni added a comment. https://phabricator.kde.org/D4712 https://phabricator.kde.org/D4711 It has one unfixible case, dismiss context menu by clicking on onther window. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmu

D5516: balooshow: Fix order of QApplication object creation

ltoscano added a comment. Would you mind to extend the fix to all applications mentioned? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5516 To: alexeymin, #frameworks, aacid, ltoscano Cc: ltoscano

D5516: balooshow: Fix order of QApplication object creation

alexeymin updated this revision to Diff 13613. alexeymin added a comment. Moved QCoreApplication object creation before KAboutData object creation. But, in neighbour directories, src/tools/ baloosearch and balooctl also have this problem then - QCoreApplication object is created right bef

D5516: balooshow: Fix order of QApplication object creation

ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. Please move the QCoreAddons creation before the KAboutData (line ~55). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5516 To: alexeymin, #frameworks,

D5516: balooshow: Fix order of QApplication object creation

alexeymin retitled this revision from "Fix order of QApplication object creation" to "balooshow: Fix order of QApplication object creation". alexeymin edited the test plan for this revision. alexeymin added a reviewer: aacid. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/

Re: KTextEditor : best way to add background vertical guide lines?

Hi Rene, On Mon, Apr 17, 2017 at 3:55 PM, René J.V. Bertin wrote: > Hi, > > What's the best way to add render a couple of vertical lines in a widget > derived from KTextEditor, for instance to provide margin indicators? This discussion belongs to kwrite-de...@kde.org. The KTextEditor::View can

D5516: Fix order of QApplication object creation

alexeymin created this revision. alexeymin added a project: Frameworks. REVISION SUMMARY QCoreApplicaion object should exist at the moment when KAboutData::setApplicationData() is called. BUG: 378539 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5516 AFFECTED FI

D5515: Update the ungrabMouse hack for Qt 5.8

mvourlakos added a comment. I had reported qts faulty behavior concerning centextmenus at: https://bugreports.qt.io/browse/QTBUG-59044 I think it is the mentioned case... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5515 To: davidedmundson

D5515: Update the ungrabMouse hack for Qt 5.8

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There was an unidentified bug where when opening a context menu in response to a mousePress event led to the nex

D5503: No "KDE Daemon" in password dialogs

graesslin added a comment. not that "KDE Daemon" is a good name, but what about i18n it? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D5503 To: lukas, #frameworks Cc: graesslin, apol, mck182

D5503: No "KDE Daemon" in password dialogs

apol added a comment. Maybe we want to have something else? Sometimes it's good to see where a dialog is coming from... REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D5503 To: lukas, #frameworks Cc: apol, mck182

D5503: No "KDE Daemon" in password dialogs

mck182 added a comment. +1 looks good, although "Dialog hesla" je zvláštní češtin :) REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D5503 To: lukas, #frameworks Cc: mck182

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

mdawson added a comment. In https://phabricator.kde.org/D5502#103322, @wbauer wrote: > In https://phabricator.kde.org/D5502#103316, @mdawson wrote: > > > Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one for a d

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer added a comment. In https://phabricator.kde.org/D5502#103316, @mdawson wrote: > Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one for a desktop file in a config directory, one in a data directory, and one pr

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

mdawson requested changes to this revision. mdawson added a comment. This revision now requires changes to proceed. +1 This definitely looks like the correct fix. Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one fo

D5506: Don't even try to create icons with empty sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R302:683bb49d4949: Don't even try to create icons with empty sizes (authored by apol). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5506?vs=13595&id=13597 REVISIO

D5506: Don't even try to create icons with empty sizes

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. :) REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D5506 To: apol, #frameworks, markg Cc: markg, kfunk

D5506: Don't even try to create icons with empty sizes

apol updated this revision to Diff 13595. apol added a comment. Readability REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5506?vs=13592&id=13595 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5506 AFFECTED FILES src/kiconengine.cpp

D5506: Don't even try to create icons with empty sizes

markg requested changes to this revision. markg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kiconengine.cpp:87 > > -if (!size.isValid()) { > +if (!size.isValid() || size.height() == 0 || size.width() == 0) { > return QPixmap(); It to

D5506: Don't even try to create icons with empty sizes

kfunk added inline comments. INLINE COMMENTS > kiconengine.cpp:87 > > -if (!size.isValid()) { > +if (!size.isValid() || size.height() == 0 || size.width() == 0) { > return QPixmap(); `size.isEmpty()`? REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.or

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103067 --- autotests/fakeUdisks2.h (line 2)

D5506: Don't even try to create icons with empty sizes

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY It's not enough to have QSize::isValid, as it needs both width and height to be 0, so we explicitly check it. Fixes a warning about writing into an empty image. REPOSITORY R302 KIconThemes BR

Re: Threadweaver compilation failure: Windows

Built fine for me with "Build Tools for Visual Studio 2017" (https://www.visualstudio.com/downloads/ "Other Tools And Frameworks" section) which contains only compiler and libs without IDE. I used part of the environment provided by craft, for cmake to able to find ECM (my KDEROOT is E:\KDE, or R:

D5503: No "KDE Daemon" in password dialogs

lukas added a comment. In action: F3729023: dialog-kded1.png before F3729025: dialog-kded2.png after REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D5503 To: lukas, #frameworks

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 18, 2017, 9:45 p.m., Lamarque Souza wrote: > > src/solid/devices/backends/udisks2/udisksblock.cpp, line 31 > > > > > > Usually we use uppper case for macros. That would also save some lines > > in this

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/ --- (Updated April 19, 2017, 11:05 a.m.) Review request for KDE Frameworks.

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/ --- (Updated April 19, 2017, 11:03 a.m.) Review request for KDE Frameworks.

D5503: No "KDE Daemon" in password dialogs

lukas created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Do not append non-translatable text "KDE Daemon" to the password dialog window title. This is done automatically by the xcb QPA plugin here: https://code.woboq.org/qt5/qtbase/src/gui/kernel/q

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D5502 To: wbauer, #frameworks Cc: #frameworks

D5502: Fix relativePath calculation in KDesktopFile::locateLocal()

wbauer created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The "dir" and "path" variables are obviously swapped here by mistake. This results in the relativePath always being empty, and makes the fun

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 524 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/524/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 07:45:02 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 523 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/523/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 02:41:55 + Build duration: 16 min CHANGE SET Revision 365d5c30d46f4927b4da2d48b6ddf16df8e7ce7e

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 523 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/523/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Apr 2017 02:41:55 + Build duration: 16 min CHANGE SET Revision 365d5c30d46f4927b4da2d48b6ddf16df8e7ce7e

Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

> On April 18, 2017, 9:45 p.m., Lamarque Souza wrote: > > src/solid/devices/backends/udisks2/udisksblock.cpp, line 31 > > > > > > Usually we use uppper case for macros. That would also save some lines > > in this