kossebau added a comment.
In https://phabricator.kde.org/D5439#102241, @mpyne wrote:
> Is there any reason why we cannot just do the needed `setlocale(LC_ALL,
"")` within ki18n itself (e.g. in the `KLocalizedStringPrivateStatics` ctor
which is used to support translation of `i18n` calls?
mpyne added a comment.
Is there any reason why we cannot just do the needed `setlocale(LC_ALL, "")`
within ki18n itself (e.g. in the `KLocalizedStringPrivateStatics` ctor which is
used to support translation of `i18n` calls? `QCoreApplication` is going to do
this anyways so making it happen
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
I think these warning flags make sense as default warning flags. I don't
agree that `__DATE__` and `__TIME__` should be avoided as a rule, but projects
that find this valuable can disable th
ltoscano added a comment.
opt/docbook-xsl/ ? O.o
Well, not up to me to discuss that.
Just a question, no need for ${CMAKE_INSTALL_DATAROOTDIR}? I understand that
it's a suffix, so not required, but if it was /opt, maybe it could be changed
to ${CMAKE_INSTALL_DATAROOTDIR}/docbook etc etc
winterz created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
On Mac, homebrew installs the docbook-xml and docbook-xls files under
/usr/local/opt
so add searchpaths accord
kossebau added a comment.
Actually, I simplified/ignored how i18n calls internally make the gettext
call chose a locale name for which a catalog has been found, by temporarily
setting the LANGUAGE variable.
What do you think, should this implementation detail be noted here as well,
or woul
kossebau added inline comments.
INLINE COMMENTS
> kossebau wrote in kaboutdata.h:314
> Aha! i18n() calls before the creation of QApplication instance currently fail
> (or rather: only return the untranslated string) for this reason:
> gettext(), as used internally by ki18n, looks at the locale n
kossebau added a comment.
See thread around https://phabricator.kde.org/D5439#102005 for related
discussion.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D5455
To: kossebau, #frameworks, ilic
kossebau created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Collect knowlegde found when investigating why i18n calls before line
QApplication app;
do not return translated strings.
Perhaps needs more prominent place to warn about the issues.
B
ltoscano added inline comments.
INLINE COMMENTS
> kossebau wrote in kaboutdata.cpp:689
> Isn't the KF6 comment added in KAboutData::desktopFileName() not already
> doing that, more or less? Not sure what you exactly ask for.
Nothing, I'm just stupid and I should not comment when I'm tired. Sorr
kossebau added inline comments.
INLINE COMMENTS
> ltoscano wrote in kaboutdata.cpp:689
> I think that any extra unneeded step is only prone to produce issues.
> In 90% of the cases (and probably more, like basically all stuff on kde.org),
> the desktop file name is org domain + component. No nee
ltoscano added inline comments.
INLINE COMMENTS
> kossebau wrote in kaboutdata.cpp:689
> Why would you also add a comment here? Would you think the comments at the
> places which should be changed are not enough?
> The KF6 TODO proposes to change the behaviour to follow the idea of
> https://ph
kossebau added inline comments.
INLINE COMMENTS
> ltoscano wrote in kaboutdata.cpp:689
> I would add something like
> // KF6: if desktopFileName has not been explicitly set, set it to domain +
> component name
Why would you also add a comment here? Would you think the comments at the
places wh
kossebau updated this revision to Diff 13439.
kossebau added a comment.
- update example to not do i18n calls before qapplication instance
- improve KF6 TODO comments
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5439?vs=13413&id=13439
BRANCH
impr
apol added a reviewer: Windows.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5443
To: mgallien, kfunk, #windows
Cc: #frameworks
Hello,
On jeudi 13 avril 2017 19:31:37 CEST Kevin Funk wrote:
> On Thursday, 13 April 2017 18:25:19 CEST Matthieu Gallien wrote:
> > Hello,
> >
> > I am trying to use KFileMetaData on Windows with mingw-5.3 32 bits. I am
> > getting compilation errors in the automatic tests and have an hard time
>
16 matches
Mail list logo
