ltoscano edited the summary of this revision.
REPOSITORY
R313 KHtml
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5392
To: apol, #frameworks, kfunk
Cc: mpyne, ltoscano, #frameworks
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R313 KHtml
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5392
To: apol, #frameworks, kfunk
Cc: mpyne, ltoscano, #frameworks
mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.
...provided the usage of `uiLanguages[0]` is safe like this.
INLINE COMMENTS
> DaysCalendar.qml:315
> height: daysCalendar.cellHeight
> -text: Qt.locale().d
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d47b970e9802: Fix
KActionSelectorPrivate::insertionIndex() (authored by antonanikin).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5329?vs=13177&id=13315
martinkostolny added a comment.
I've created a follow-up diff https://phabricator.kde.org/D5394 and added
every subscriber from here. I hope it wasn't too invasive of me.
> Once implemented, it will be possible to get kauth for free when calling
(for example) KIO::move(). Not sure if tha
martinkostolny created this revision.
martinkostolny added projects: KTextEditor, Frameworks.
Restricted Application added subscribers: Frameworks, kwrite-devel.
REVISION SUMMARY
This is a follow-up of https://phabricator.kde.org/D4847, trying to fix
issues pointed out by Fabian:
- send th
mpyne added a comment.
I can confirm that the patch works with KHTML built on Qt 5.8.1, and that
Konqueror still finds KHTML fine after.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D5392
To: apol, #frameworks
Cc: mpyne, ltoscano, #frameworks
kossebau added a comment.
Eek, I just learned that changing the doctype name to "kpartgui" breaks the
XML standard, which requires this:
"The Name in the document type declaration MUST match the element type of the
root element." (cmp. https://www.w3.org/TR/xml11/#dt-doctype)
That info
This revision was automatically updated to reflect the committed changes.
Closed by commit R263:8629cc027e9f: Use non-deprecated root element
(authored by kossebau).
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5296?vs=13081&id=13313
REVISION DETAIL
http
ltoscano added a comment.
Please add a reference to https://bugs.kde.org/show_bug.cgi?id=377490, which
is exactly this issue.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D5392
To: apol, #frameworks
Cc: ltoscano, #frameworks
apol added a comment.
I would appreciate if someone could test it on earlier versions of Qt.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D5392
To: apol, #frameworks
Cc: #frameworks
apol added a reviewer: Frameworks.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D5392
To: apol, #frameworks
Cc: #frameworks
apol created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Otherwise we get the following error:
/home/apol/devel/frameworks/khtml/src/khtml_factory.h:31: Error: Plugin
Metadata file "" could not be o
elvisangelaccio added a comment.
In https://phabricator.kde.org/D4847#101163, @aacid wrote:
> How is this related with https://phabricator.kde.org/T5202 ?
Once implemented, it will be possible to get kauth for free when calling (for
example) `KIO::move()`. Not sure if that's enoug
Aleix Pol ha scritto:
> On Sat, Apr 8, 2017 at 9:31 PM, Luigi Toscano
> wrote:
>> Hi all,
>> I was checking the manpages shipped with Frameworks.
>> I know that this is not the most existing topics, but: can I move the man
>> pages currently in section 8 (System management commands) to section 1
aacid added a comment.
How is this related with https://phabricator.kde.org/T5202 ?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4847
To: martinkostolny, dhaumann, #ktexteditor, dfaure
Cc: aacid, ivan, lbeltrame, fvogt, apol, dfaure, anthonyfieroni, cullmann,
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
usenondeprecatedelement
REVISION DETAIL
https://phabricator.kde.org/D5296
To: kossebau, #frameworks, aacid
Cc: aacid
kossebau added a comment.
Ping? If no-one has further comments or objects, will push around April 17th.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5296
To: kossebau, #frameworks
Cc: aacid
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/175/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 10 Apr 2017 15:36:23 +
Build duration: 5 min 53 sec
CHANGE SET
No changes
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/175/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 10 Apr 2017 15:36:23 +
Build duration: 5 min 53 sec
CHANGE SET
No changes
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/399/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 10 Apr 2017 14:02:51 +
Build duration: 14 min
CHANGE SET
Revision
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/399/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 10 Apr 2017 14:02:51 +
Build duration: 12 min
CHANGE SET
Revi
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/397/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 10 Apr 2017 14:02:51 +
Build duration: 2 min 20 sec
CHANGE SET
Revis
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/397/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 10 Apr 2017 14:02:51 +
Build duration: 4 min 23 sec
CHANGE SET
Revision
sitter added inline comments.
INLINE COMMENTS
> CMakeLists.txt:25
> +
> +if(NOT TARGET fetch-translations AND NOT EXISTS
> "${CMAKE_CURRENT_SOURCE_DIR}/../../po")
> +message(FATAL_ERROR "should have a fetch-translations target")
`AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../../po"` is the
lbeltrame added a comment.
Notice from downstream integration: this feature is considered an "abuse" of
the Polkit system and at least openSUSE will explicitly disable it. See
https://bugzilla.suse.com/show_bug.cgi?id=1033055 for the reasoning.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2df613f9381f: Generate plugins.qmltypes files for the
plugins we install (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5088?
lbeltrame added a comment.
In https://phabricator.kde.org/D4847#101088, @ivan wrote:
> @lbeltrame
>
> I don't really see 'reasoning' in that report more than something that
sounds like 'polkit is a hack to replace suid for setting the system time and
time zone'.
That said, th
fvogt added a comment.
In https://phabricator.kde.org/D4847#101088, @ivan wrote:
> @lbeltrame
>
> I don't really see 'reasoning' in that report more than something that
sounds like 'polkit is a hack to replace suid for setting the system time and
time zone'.
Me neither. In my
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:86f19ab46690: Introduce ecm_generate_qmltypes (authored
by apol).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5087?vs=12570&id=13298
REVISION DETAIL
fvogt added a comment.
Adding to Luca's comment, I also find two additional issues with this
approach, it is absolutely impossible to make this secure.
There is always a race condition between acquiring the privilege and renaming
the file to the new location.
Only solution for that is to
ivan added subscribers: lbeltrame, ivan.
ivan added a comment.
@lbeltrame
I don't really see 'reasoning' in that report more than something that sounds
like 'polkit is a hack to replace suid for setting the system time and time
zone'.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
http
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/174/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 10 Apr 2017 13:34:15 +
Build duration: 4 min 18 sec
CHANGE SET
No changes
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/398/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 10 Apr 2017 13:10:23 +
Build duration: 11 min
CHANGE SET
Revi
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/396/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 10 Apr 2017 13:10:23 +
Build duration: 11 min
CHANGE SET
Revision 2df613
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/398/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 10 Apr 2017 13:10:23 +
Build duration: 3 min 9 sec
CHANGE SET
Rev
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/396/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Mon, 10 Apr 2017 13:10:23 +
Build duration: 3 min 3 sec
CHANGE SET
Revisi
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:16aabe1c24b5: Add a test for _repository_name() a
function added for fetch-translations (authored by apol).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.or
sitter accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5352
To: apol, sitter, aacid
Cc: #frameworks, #build_system
apol updated this revision to Diff 13296.
apol marked an inline comment as done.
apol added a comment.
Fix test
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5352?vs=13293&id=13296
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
apol updated this revision to Diff 13293.
apol added a comment.
Include a check to make sure the target is created
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5352?vs=13234&id=13293
BRANCH
master
REVISION DETAIL
https://phabricator.kde.
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/647/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 10 Apr 2017 08:31:11 +
Build duration: 18 min
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/647/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 10 Apr 2017 08:31:11 +
Build duration: 18 min
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/505/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 10 Apr 2017 08:12:41 +
Build duration: 7 min 15 sec
CHANGE SET
Revision efbeacb3594f8d3d75bc7940e19a6ecf557
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/505/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 10 Apr 2017 08:12:41 +
Build duration: 7 min 15 sec
CHANGE SET
Revision efbeacb3594f8d3d75bc7940e19a6ecf557
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Right.
Would be nice to have an autotest for this but since there's no autotest for
KActionSelector at all that i can see i'm not going to block you on that :)
REPOSITORY
R236 KWidgets
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:3d1d436da60a: Fix compilation under AppleClang (authored
by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5379?vs=13284&id=13289
REVISION DETA
kfunk added a comment.
In https://phabricator.kde.org/D5379#100960, @rjvbb wrote:
> LGTM.
>
> Is this related to the compiler features issue in one of Qt's cmake modules?
No, it's related to CMake starting to treat AppleClang & Clang differently
since 3.0
REPOSITORY
R240 Ex
48 matches
Mail list logo