D5329: Fix KActionSelectorPrivate::insertionIndex()

2017-04-08 Thread Anton Anikin
antonanikin added a comment. > Is this really needed? > Without your code it defaults to > index = -1; > what is the same as appending that is the same as atBottom, no? Yes, it needed - see here about negative index http://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/itemviews/

Section of man pages shipped with Frameworks

2017-04-08 Thread Luigi Toscano
Hi all, I was checking the manpages shipped with Frameworks. I know that this is not the most existing topics, but: can I move the man pages currently in section 8 (System management commands) to section 1 (User commands (Programs))? The program documented are definitely not administrative programs

D5329: Fix KActionSelectorPrivate::insertionIndex()

2017-04-08 Thread Albert Astals Cid
aacid added a comment. Is this really needed? Without your code it defaults to index = -1; what is the same as appending that is the same as atBottom, no? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5329 To: antonanikin, #frameworks Cc: aacid, kde

D5352: Add a test for _repository_name() a function added for fetch-translations

2017-04-08 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY It turns out it's more complex than it looks, it's always better to have tests. REPOSITORY R240 Extra CMake Module

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

2017-04-08 Thread Andreas Sturmlechner
> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. Thanks, anyone else who wants to +1? I've tried to test migration today but it didn't work. May as well have nothing to do with te patch and be caused by the permanently troubled migration agent though... KMail happi

D5338: Add syntax highlighting file for Doxyfile

2017-04-08 Thread Kevin Funk
kfunk added a comment. In https://phabricator.kde.org/D5338#100509, @dhaumann wrote: > Oh, and see this: https://github.com/KDE/syntax-highlighting/pull/5 What the... Created at almost the exact same time? :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 275 - Fixed!

2017-04-08 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 08 Apr 2017 09:11:13 + Build duration: 6 min 40 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 275 - Fixed!

2017-04-08 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 08 Apr 2017 09:11:13 + Build duration: 6 min 40 sec CHANGE SET No changes JUNIT RESULTS Nam

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

2017-04-08 Thread Shaheed Haque
shaheed added a comment. I did some negative testing, and from what I can see, 3.8 might well be OK for the ECM fork. My version depends on 3.9 (for example, there are some new constants defined by clang which I use), but I've no idea if this will ever be merged. REPOSITORY R240 Extra

D5344: Relax constraints for processing QGroupBoxes

2017-04-08 Thread Volker Krause
vkrause closed this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D5344 To: vkrause, dvratil, dfaure Cc: #frameworks

D5344: Relax constraints for processing QGroupBoxes

2017-04-08 Thread Daniel Vrátil
dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D5344 To: vkrause, dvratil, dfaure Cc: #frameworks

D5345: Calendar: Use correct language for month and day names

2017-04-08 Thread David Rosca
drosca created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Apply fix for bug 353715 also on QML side. TEST PLAN I have English ui language + Czech time format. Months and days ar

D5344: Relax constraints for processing QGroupBoxes

2017-04-08 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY So far this was only accepting QGroupBoxes containing only auto-exclusive buttons. Now we also accept QGroupBoxes that contain non-buttons,

D5338: Add syntax highlighting file for Doxyfile

2017-04-08 Thread Dominik Haumann
dhaumann added a comment. Oh, and see this: https://github.com/KDE/syntax-highlighting/pull/5 REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, kwrite-devel, dhaumann Cc: #frameworks

D5338: Add syntax highlighting file for Doxyfile

2017-04-08 Thread Dominik Haumann
dhaumann added a comment. I would prevent MIT license for the highlighting - and also for the test. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, kwrite-devel, dhaumann Cc: #frameworks