tcberner added a comment.
We talked about it some more, and think that it is maybe better to not do any
cmake magic.
#ifdef st_birthtime
if (buff.st_birthtime > 0) {
entry.insert(KIO::UDSEntry::UDS_CREATION_TIME,
buff.st_birthtime);
}
#endif
#i
elvisangelaccio added a dependent revision: D5313: Add workaround for bug in
QLineEdit's clear button.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D5312
To: elvisangelaccio, cfeck, fvogt
Cc: #frameworks
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Otherwise the user cannot tell whether what's going to be typed will be
visible or not.
BUG: 378276
FIXED-IN: 5.34
REPOSITO
aacid added a comment.
tobias will you commit this? Or are we still waiting for some other approval?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5138
To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: aacid, kfunk, emmanuelp, #frameworks
sitter accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5143
To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic, sitter
Cc: sitter
ltoscano added inline comments.
INLINE COMMENTS
> KDECMakeSettings.cmake:289
> +option(KDE_L10N_AUTO_TRANSLATIONS "Automatically 'make
> fetch-translations`" OFF)
> +set(KDE_L10N_BRANCH "trunk" CACHE STRING "Branch from l10n.kde.org to
> fetch from: trunk | stable | lts | trunk_kde4 | s
apol updated this revision to Diff 13120.
apol added a comment.
FWIW this works, although it feels weird to include the source dir despite it
not existing
REPOSITORY
R325 KAlgebra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5197?vs=12870&id=13120
BRANCH
master
REVISION DET
apol added a comment.
Fixed.
Can I please have a ship it? 😿 we can maybe polish it over time
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5143
To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter
apol marked 3 inline comments as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5143
To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter
apol updated this revision to Diff 13118.
apol added a comment.
Makes it possible to have ${CMAKE_SOURCE_DIR} and ${CMAKE_BINARY_DIR}
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5167?vs=12987&id=13118
BRANCH
fetchbuildtime
REVISION DETAIL
https://pha
apol updated this revision to Diff 13117.
apol added a comment.
Address sitter's comments
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5143?vs=13006&id=13117
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5143
AFFECTED FILES
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/494/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 14:28:18 +
Build duration: 5 min 35 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) Fa
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/494/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 14:28:18 +
Build duration: 5 min 35 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) Fa
sitter added a comment.
needs a version bump in the docs now 👅
beyond that LGTM
INLINE COMMENTS
> KDECMakeSettings.cmake:86
> +#
> +# Since 5.33.0
>
5.34 now
> KDECMakeSettings.cmake:323
> +COMMAND ruby "${CMAKE_BINARY_DIR}/releaseme/fetchpo.rb" --origin
> ${KDE_L10N_BRANCH}
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c20a9f69e8e2: Use -Wno-gnu-zero-variadic-macro-arguments
more (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5302?vs=13096&id=13113
kossebau added a comment.
In https://phabricator.kde.org/D5296#99818, @aacid wrote:
> Do you know where we do the parsing that allows both gui and kpartgui to be
"valid"?
>
> I did some searching and i think i found it but would be nice if you can
find it and we agree on it D:
dfaure added a comment.
5.33 is tagged since last saturday, you can push without waiting. It's always
summer in master, for KF5.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5302
To: kfunk, kossebau, apol, dfaure
Cc: apol, #frameworks
kfunk added a comment.
FYI: I'll wait with pushing until v5.33 is released.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5302
To: kfunk, kossebau, dfaure, apol
Cc: apol, #frameworks, #build_system
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5302
To: kfunk, kossebau, dfaure, apol
Cc: apol, #frameworks, #build_system
adridg accepted this revision.
adridg added a comment.
I just happened to need a FindGperf in another project today, so I've tested
this in non-ECM settings (adding this plus ECMFindModuleHelpers to that
project's own cmake/) and it works fine on FreeBSD. The docs in the header are
good, too
kfunk added a comment.
In https://phabricator.kde.org/D5302#99816, @apol wrote:
> +1
>
> Which warnings? Are they proper warnings that should be fixed?
See comment inside the source code: It's triggered by normal usage from
`qCDebug()`...
REPOSITORY
R240 Extra CMake Modules
rjvbb accepted this revision.
rjvbb added a comment.
This revision is now accepted and ready to land.
Sorry, I haven't had the occasion to test this modification but given our
exchange above this ought to be fine as far as I can tell.
REPOSITORY
R240 Extra CMake Modules
BRANCH
pino-gperf
22 matches
Mail list logo
