Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
On pondělí 3. dubna 2017 15:04:54 CEST Hartmut Goebel wrote: > Am 03.04.2017 um 14:16 schrieb Jan Grulich: > > Pushed two fixes into master branch, hopefully they fix all issues with > > the > > failing unit test. > > Applying both patches make the tests pass. Thanks for the fix. Awesome, I'm gla

D5275: Kapidox generates qch files

2017-04-03 Thread Anton Anikin
antonanikin added a comment. Hi, Olivier. Your QCH files displayed normally but with one bug - broken links for some JavaScript code. For example open `KTipDialog` class doc from your `Frameworks` file. Then try to click (open) `Public Member Functions inherited from QDialog` - nothing

D5296: Use non-deprecated root element

2017-04-03 Thread Friedrich W. H. Kossebau
kossebau created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The DTD talks about being deprecated as toplevel element, so the data and tests should follow that. Also fixes wrong DOCTYPE name usage, "gui" instead of "kpartgui" makes no sense given

D4778: Add include that is needed in msys2

2017-04-03 Thread Russell Greene
russellg added a comment. So where does this go now? Sorry I've never submitted a patch in phabricator before :P Am I supposed to merge this, or is somebody else? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4778 To: russellg, #frameworks, kfunk Cc: kfunk

D5275: Kapidox generates qch files

2017-04-03 Thread Olivier Churlaud
ochurlaud updated this revision to Diff 13076. ochurlaud edited the summary of this revision. ochurlaud added a comment. Update: Order alphabetically the libs in a product REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5275?vs=13045&id=13076 BRANCH olivi

D5275: Kapidox generates qch files

2017-04-03 Thread Olivier Churlaud
ochurlaud added a comment. Here 3 examples. Frameworks only contains KApiDox, KConfigWidgets and KItemModels. I could have generated all of them of course... F3526219: okular.qch F3526218: frameworks.qch F35

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

2017-04-03 Thread Shaheed Haque
shaheed added subscribers: kde-buildsystem, shaheed. shaheed added a comment. Fwiw, I think that a specific version check may not be needed. The original code I wrote, which I assume Steve may have simply carried forward in the cmake ecm logic, DID have a version check but only because the

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

2017-04-03 Thread Luca Beltrame
lbeltrame added a comment. +1, we have the same problem in openSUSE. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5289 To: heikobecker, #frameworks, #build_system, skelly, kfunk Cc: lbeltrame

D5291: FindPyModGen: Also search for an unversioned clang++

2017-04-03 Thread Heiko Becker
heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY While my distro does have a versioned clang executable, it doesn't have a versioned clang++ executable. The versioned executable is still searched first, falling back to the u

D5290: FindPyModGen: Don't hard-code share dir

2017-04-03 Thread Heiko Becker
heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY ...but use KDE_INSTALL_DATAROOTDIR instead. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5290 AFFECTED FILES find-mod

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

2017-04-03 Thread Heiko Becker
heikobecker created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY On non Debian-based systems libclang is mostly installed as libclang.so., evading detection by clang-${_LIBCLANG_FIND_VERSION}.0. Instead of specyfing and maintaing a list o

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 392 - Unstable!

2017-04-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/392/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 03 Apr 2017 14:07:46 + Build duration: 2 min 39 sec CHANGE SET Revision

D5243: if the user did set an implicit size, keep it

2017-04-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:fb8ed07651a7: if the user did set an implicit size, keep it (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5243?vs=13064&id=1

D5243: if the user did set an implicit size, keep it

2017-04-03 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/implicitSize REVISION DETAIL https://phabricator.kde.org/D5243 To: mart, #plasma, hein Cc: hein, davidedmundson, plasma-devel, #frameworks, progwolff, lesli

D5243: if the user did set an implicit size, keep it

2017-04-03 Thread Marco Martin
mart updated this revision to Diff 13064. mart added a comment. - always emit implicitWidth/HeightChanged2 when implicit changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5243?vs=12978&id=13064 BRANCH phab/implicitSize REVISION D

D5275: Kapidox generates qch files

2017-04-03 Thread Aleix Pol Gonzalez
apol added a comment. Having qch files should work, yes. If you can generate one, we can easily check if it works in KDevelop... REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D5275 To: ochurlaud, kossebau, #kdevelop, mwolff, apol Cc: #frameworks, #documentation, sk

D5243: if the user did set an implicit size, keep it

2017-04-03 Thread Eike Hein
hein added a comment. review talk ‎[22:08] ‎<‎Sho_‎>‎ notmart: if you redefine a property with different NOTIFY signals, do the other signals from the baseclass still work, too? ‎[22:09] ‎<‎Sho_‎>‎ notmart: also, why do you need different NOTIFY signals, can't you just emit the base cl

Re: Test failures with networkmanager-qt

2017-04-03 Thread Hartmut Goebel
Am 03.04.2017 um 14:16 schrieb Jan Grulich: > Pushed two fixes into master branch, hopefully they fix all issues with the > failing unit test. Applying both patches make the tests pass. Thanks for the fix. -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com

D5275: Kapidox generates qch files

2017-04-03 Thread Olivier Churlaud
ochurlaud added reviewers: mwolff, apol. ochurlaud added a comment. I add some people who may be able to tell me if the output can be used in the kdevelop generation (because I heard you use it). I don't use qch files myself, so I need an external view REPOSITORY R264 KApiDox REVISION

Re: Test failures with networkmanager-qt

2017-04-03 Thread Hartmut Goebel
Hi Jan, > could you please try attached patch? For me it was working even without the > patch, but I think I spotted a potential problem and this hopefully will fix > it. Thanks for the patch, unfortunately it did not solve the problem. I'll send you the log-output via personal mail to avoid cl

Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
Pushed two fixes into master branch, hopefully they fix all issues with the failing unit test. Jan On pondělí 3. dubna 2017 13:28:06 CEST David Faure wrote: > On lundi 3 avril 2017 12:57:11 CEST Jan Grulich wrote: > > Hi, > > > > could you please try attached patch? For me it was working even w

Re: Test failures with networkmanager-qt

2017-04-03 Thread David Faure
On lundi 3 avril 2017 12:57:11 CEST Jan Grulich wrote: > Hi, > > could you please try attached patch? For me it was working even without the > patch, but I think I spotted a potential problem and this hopefully will fix > it. This isn't happening on my own system but on a CI server I don't contro

Re: Test failures with networkmanager-qt

2017-04-03 Thread Jan Grulich
Hi, could you please try attached patch? For me it was working even without the patch, but I think I spotted a potential problem and this hopefully will fix it. Regards, Jan On sobota 1. dubna 2017 21:54:04 CEST David Faure wrote: > On mardi 28 mars 2017 08:10:15 CEST Jan Grulich wrote: > > Hi

D5286: QtCurve alternative style for named menu section headers (WIP)

2017-04-03 Thread René J . V . Bertin
rjvbb added a comment. I have been unable to figure out whether it's indeed impossible to detect if a menu item is the 1st or last in a menu when calculating its content size (CT_MenuItem). Is it? Idem for drawing (CE_MenuItem): is there anything other than the content rect co-ordinates to

D5286: QtCurve alternative style for named menu section headers (WIP)

2017-04-03 Thread René J . V . Bertin
rjvbb added a comment. F3517948: qtcurve-menusections-config.png F3517946: qtcurve-menusections-new.png F3517943: qtcurve-menusections-buttonstyle.png F3517944:

D5286: QtCurve alternative style for named menu section headers (WIP)

2017-04-03 Thread René J . V . Bertin
rjvbb created this revision. REVISION SUMMARY This patch introduces an optional new/modern look for named menu section headers to the Qt4 and Qt5 style plugins. The context: I have been tinkering with (minimal changes to) Qt's Cocoa backends to enable full support of named menu sections