Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 230 - Fixed!

2017-03-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 30 Mar 2017 20:05:04 + Build duration: 13 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 230 - Fixed!

2017-03-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 30 Mar 2017 20:05:04 + Build duration: 13 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 229 - Unstable!

2017-03-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/229/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 30 Mar 2017 19:35:07 + Build duration: 15 min CHANGE SET Revision ce81d9cbf23b4ab95649a9c249290569c9def0

D5104: Error page, correctly load the image (with a real URL)

2017-03-30 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R313:ce81d9cbf23b: Error page, correctly load the image (with a real URL) (authored by ltoscano). REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5104?vs=12606&id=13013 RE

D5178: QtCurve/Qt5 : further KF5 adaptation

2017-03-30 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5178#99097, @ltoscano wrote: > > Differential Revision: https://phabricator.kde.org/D5178 I suppose it would technically be possible to support `REVIEW:` instead of `Differential Revision:` on a commit's last line o

D5178: QtCurve/Qt5 : further KF5 adaptation

2017-03-30 Thread Luigi Toscano
ltoscano set the repository for this revision to R626 QtCurve. REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D5178 To: rjvbb, yuyichao Cc: ltoscano, #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

2017-03-30 Thread Luigi Toscano
ltoscano added a comment. In order to properly close the review, please either use arcanist (suggested method) or the last line should have been: Differential Revision: https://phabricator.kde.org/D5178 REVISION DETAIL https://phabricator.kde.org/D5178 To: rjvbb, yuyichao Cc: ltoscano, #

D5178: QtCurve/Qt5 : further KF5 adaptation

2017-03-30 Thread René J . V . Bertin
rjvbb closed this revision. rjvbb added a comment. https://commits.kde.org/qtcurve/820a35e02cc6c31a4db9dccf40a83ba7a771dd03 REVISION DETAIL https://phabricator.kde.org/D5178 To: rjvbb, yuyichao Cc: #frameworks, yuyichao

D5178: QtCurve/Qt5 : further KF5 adaptation

2017-03-30 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5178#99057, @yuyichao wrote: > Is this the new review platform? Yep. > LGTM. Hopefully I'm doing the right action here (phabricator always seem to have way more buttons than I need..) I think so. Phab is indeed c

D5178: QtCurve/Qt5 : further KF5 adaptation

2017-03-30 Thread Yichao Yu
yuyichao accepted this revision. yuyichao added a comment. This revision is now accepted and ready to land. Is this the new review platform? LGTM. Hopefully I'm doing the right action here (phabricator always seem to have way more buttons than I need..) REVISION DETAIL https://phab

D5143: Introduce fetch-translations build command

2017-03-30 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5143 To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid Cc: sitter

D5143: Introduce fetch-translations build command

2017-03-30 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 13006. apol added a comment. Few improvements Use regex to figure out the repo name Improve comment when fetching translations indicating what it's fetching Correct arguments to add_custom_target REPOSITORY R240 Extra CMake Modules CHANGES SINCE L

D5143: Introduce fetch-translations build command

2017-03-30 Thread Aleix Pol Gonzalez
apol added a comment. > This only works if you used kde:okular but not git://anongit.kde.org/okular.git, no? Addressed on the next interation. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5143 To: apol, #frameworks, #build_system, kfunk, ltoscano

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-03-30 Thread Chinmoy Ranjan Pradhan
> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > > > > > I don't see the advantage of using a single kauth action. This way you > > are generating on

D5247: [ModelContextMenu] Silence warnings

2017-03-30 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:edb05ef98983: [ModelContextMenu] Silence warnings (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5247?vs=12985&id=13004 R

D5247: [ModelContextMenu] Silence warnings

2017-03-30 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5247 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, se