GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kitemmodels%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 06:14:23 +
Build duration: 2 min 56 sec
CHANGE SET
Revision fdbb6556017036ac159e15bb6285b104a1
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kitemmodels%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 20 Mar 2017 06:14:23 +
Build duration: 3 min 1 sec
CHANGE SET
Revision fdbb6556017036ac159e15bb6285
mpyne added a comment.
The patch looks fine to me, and gives a file:// that successfully opens in a
separate Konq tab... but the image still doesn't show in the actual error page.
I'm not sure of the cause though and have no time to research further tonight.
:(
REPOSITORY
R313 KHtml
REV
nalvarez added a comment.
Writing tests for this might not be easy, so even having passing tests for
the current behavior would be very useful, as a first step.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4234
To: cactus, #ktexteditor, mwolff
Cc: nalvarez, mw
brauch added a comment.
Hm, I think the biggest problem is that we don't know how we want it to work
... so we can't write tests either ;)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4234
To: cactus, #ktexteditor, mwolff
Cc: mwolff, anthonyfieroni, dhaumann,
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ca4028aed27b: Fixed normalization/toLower order (authored
by poboiko).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4995?vs=12340&id=12624#toc
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPD
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1693ee7a2501: User messages cleanup (and de-emphasize
Konqueror) (authored by ltoscano).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5090?vs=12615&id=12623
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9a9f51956d44: fix debug warning (and wrong pen value)
found by kfunk, introduced my me (authored by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5108
kfunk added a comment.
Thanks for the quick fix!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5108
To: cullmann, kfunk
Cc: kwrite-devel, #frameworks
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5108
To: cullmann, kfunk
Cc: kwrite-devel, #frameworks
cullmann created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Fix setPen call to be done after begin()
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5108
AF
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
focus-on-kio
REVISION DETAIL
https://phabricator.kde.org/D5090
To: ltoscano, dfaure
Cc: aacid, lueck, #frameworks
aacid added a comment.
Looks good to me now. I'll let someone else do the final approval, since
various of us commented.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5090
To: ltoscano, dfaure
Cc: aacid, lueck, #frameworks
mpyne added a comment.
Will try to look later today but won't be able to at this point.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D5104
To: ltoscano
Cc: mpyne, #frameworks
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
R285 KCrash
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5079
To: sitter, dfaure, mpyne
Cc: mpyne, #frameworks
ltoscano retitled this revision from "More focus on KIO than Konqueror and msg
cleanups" to "User messages cleanup (and de-emphasize Konqueror)".
ltoscano edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5090
To: ltoscano, dfaure
Cc: aaci
ltoscano updated this revision to Diff 12615.
ltoscano added a comment.
Apply the requested suggestions
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5090?vs=12607&id=12615
BRANCH
focus-on-kio
REVISION DETAIL
https://phabricator.kde.org/D5090
AFFECTED F
ltoscano added inline comments.
INLINE COMMENTS
> dfaure wrote in kprotocolmanager.cpp:846
> How about just KIO ?
>
> kio_http is unnecessarily specific IMHO. It's all of KIO/5.33 that ends up
> making up the http client.
Ack
> dfaure wrote in cache.cpp:109
> Memory? that seems wrong (or at l
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
I'm personally all for improving the status quo, but I think the biggest
problem here is that we have no unit test coverage (or do we?). The unit tests
would also clearly show the
mwolff accepted this revision.
mwolff added a comment.
do you have commit rights? otherwise someone from us can commit this for you
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D4995
To: poboiko, pinakahuja, vhanda, mwolff
Cc: mwolff, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c9cb3e9761f3: Expose additional internal View's
functionality to the public API (authored by jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4947?vs=125
jsalatas marked 9 inline comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
jsalatas marked 2 inline comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
vhanda accepted this revision.
vhanda added a comment.
This revision is now accepted and ready to land.
This is awesome. Good work.
Ship it! (If you don't have commit access, please ask for it, you can add me
as a reference)
(Optionally, one could even add a unit test)
REPOSITORY
dfaure added inline comments.
INLINE COMMENTS
> kprotocolmanager.cpp:846
> d->useragent += QString::number(KIO_VERSION_MAJOR);
> +d->useragent += QStringLiteral(" kio_http/");
> +d->useragent += QString::number(KIO_VERSION_MAJOR);
How about just KIO ?
kio_http is unnece
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/475/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Mar 2017 10:26:13 +
Build duration: 6 min 21 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (r
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/475/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Mar 2017 10:26:13 +
Build duration: 6 min 21 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (r
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.
I cannot reproduce that bug but the patch looks good to me.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D5092
To: cfeck, kossebau, elvi
cullmann accepted this revision.
cullmann added a comment.
Then I would say that is OK to go in.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kw
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/474/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 19 Mar 2017 10:12:18 +
Build duration: 7 min 23 sec
CHANGE SET
Revision e449f82311ad89ded3a27790015cebac87
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e449f82311ad: Updated user agents (Firefox 52 ESR,
Chromium 57) (authored by ltoscano).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5091?vs=12576&id=12610
REVISION
ltoscano retitled this revision from "Updated user agents (Firefox 52 ESR,
Chromium 52)" to "Updated user agents (Firefox 52 ESR, Chromium 57)".
REPOSITORY
R241 KIO
BRANCH
add-current-useragents
REVISION DETAIL
https://phabricator.kde.org/D5091
To: ltoscano, dfaure
Cc: #frameworks
vpilo added a comment.
I pushed https://phabricator.kde.org/D5012; this rev is now testable.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4799
To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik,
graesslin, mck182
Cc: plasma-devel, davi
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Bug in the commit log, Chrome 57, not Chromium 52 ;)
REPOSITORY
R241 KIO
BRANCH
add-current-useragents
REVISION DETAIL
https://phabricator.kde.org/D5091
To: ltoscano, dfaure
Cc: #fr
rjvbb updated this revision to Diff 12608.
rjvbb added a comment.
Updated as requested
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5037?vs=12480&id=12608
REVISION DETAIL
https://phabricator.kde.org/D5037
AFFECTED FILES
src/view/kateviewinternal.cpp
src/view/kateviewinterna
rjvbb closed this revision.
rjvbb added a comment.
https://commits.kde.org/extra-cmake-modules/7af9f8e2b6eb235923a329e8ff24012883fb6b86
REVISION DETAIL
https://phabricator.kde.org/D5089
To: rjvbb, #build_system, #frameworks, kfunk
Cc: kfunk, apol, kde-mac, #frameworks, #build_system
36 matches
Mail list logo
