ltoscano retitled this revision from "More focus on KIO than Konqueror" to
"More focus on KIO than Konqueror and msg cleanups".
ltoscano edited the summary of this revision.
ltoscano edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5090
ltoscano updated this revision to Diff 12607.
ltoscano added a comment.
Few more cleanups and few suggested changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5090?vs=12575&id=12607
BRANCH
focus-on-kio
REVISION DETAIL
https://phabricator.kde.org/D5090
ltoscano created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The local address to the image is injected into an HTML page (the
error page). This address needs to be a proper URL with file:///,
not
dhaumann added a comment.
Yes, this is what I meant. I think the code is now better by using an
isolated class.
I just read the code again, and I think I would like to suggest another
change: The class name currently is too generic, this makes reasoning quite
hard.
That said, I sugges
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
If markType32 does not clash with others (e.g. markTypes that are used by
KDevelop), I am fine with this. Could you check this before comitting?
REPOSITORY
R39 KTextEditor
REVISION D
sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This patch adds scroll-bar-marks to the matches of "Find all" in the advanced
search bar
TEST PLAN
find all results in multiple
jsalatas added a comment.
In https://phabricator.kde.org/D4947#95893, @cullmann wrote:
> Sorry for late response, thanks for ping!
No worries :)
> First about the interface you added: I think that it is ok the way, beside
for the enum values I would go for CamelCase like all
jsalatas updated this revision to Diff 12598.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4947?vs=12416&id=12598
REVISION DETAIL
https://phabricator.kde.org/D4947
AFFECTED FILES
src/include/ktexteditor/view.h
src/utils/ktexteditor.cpp
src/view/k
ltoscano added inline comments.
INLINE COMMENTS
> lueck wrote in smbrodlg.cpp:176-186
> There are no fields named Browse server, Broadcast address, WINS address in
> the dialog, see
> https://bugs.kde.org/show_bug.cgi?id=253389
>
> Last occurences of these strings are in
> https://websvn.kde.or
cullmann added a comment.
I am no security expert, therefore I might not see obvious security flaws.
Beside that we still have issues with the atomicity of the rename, it should
work as it is now, or I am mistaken?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/
cullmann added a comment.
Sorry for late response, thanks for ping!
First about the interface you added: I think that it is ok the way, beside
for the enum values I would go for CamelCase like all other things and
something like VisibleLine or RealLine, that is more KF/Qt style I would s
jsalatas added a comment.
ping?
:)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
kfunk added a comment.
Closing. This Diff refactored the code technically correct.
If you want to replace `MyFlags flags = nullptr` by `... = {}` please do so
in a follow-up patch/review.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D3987
To: kfunk, #framework
kfunk closed this revision.
kfunk added a comment.
Closing. Please just strip the flag from CMake flags if you're using a
library making use of alternative tokens.
We've just seen compilation failing early because some lib in KF5
accidentally used alternative tokens => would have broken
ltoscano added inline comments.
INLINE COMMENTS
> aacid wrote in kprotocolmanager.cpp:844
> This may be techinically correct, but it's going to break stuff that uses
> user agent detection (yes i know, that's broken but people use it still), so
> -1
(like Gecko) kio_http/ (previously Konqueror
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
LGTM
REVISION DETAIL
https://phabricator.kde.org/D5089
To: rjvbb, #build_system, #frameworks, kfunk
Cc: kfunk, apol, kde-mac, #frameworks, #build_system
rjvbb updated this revision to Diff 12583.
rjvbb added a comment.
Uses `MATCHES "Clang"` .
Tested and appears to work with AppleClang `Apple LLVM version 6.0
(clang-600.0.57) (based on LLVM 3.5svn)`
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5089?vs=12572&id=12583
REVISION
aacid added inline comments.
INLINE COMMENTS
> kprotocolmanager.cpp:844
> d->useragent += QString::number(KIO_VERSION_PATCH);
> -d->useragent += QStringLiteral(" (like Gecko) Konqueror/");
> +d->useragent += QStringLiteral(" (like Gecko) kio_http/");
> d->userage
lueck added inline comments.
INLINE COMMENTS
> smbrodlg.cpp:176-186
> + return i18n("Windows SharesApplications using the "
> +"SMB kioslave (like Konqueror) are able to access shared Microsoft "
> +"Windows file systems, if properly configured. If there is a "
> "speci
19 matches
Mail list logo
