Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/#review102846 --- Ship it! Ship It! - Anthony Fieroni On Март 14, 2017,

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 13, 2017, 12:10 p.m., Elvis Angelaccio wrote: > > I'm not sure if we should show the warning dialog at the kio_file level. > > This would result in a double dialog when deleting files with Shift+Del > > from file managers. What about making jobuidelegate.cpp smarter? It could > > sh

D5037: KTextEditor: prevent accidental zooming

rjvbb updated this revision to Diff 12480. rjvbb added a comment. - don't use QElapsedTimer::elapsed() when the timer isn't valid. Changes nothing to the behaviour but may make the code a bit less obfuscated. - edited a few comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5

Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- Review request for KDE Frameworks and Anthony Fieroni. Repository: kfilem

D5037: KTextEditor: prevent accidental zooming

rjvbb added a comment. In https://phabricator.kde.org/D5037#95031, @anthonyfieroni wrote: > Ok, note this situation, hold modifier before first ever wheel event => you call m_lastWheelEvent.elapsed on unstarted timer This is true, and things can indeed be improved a bit there.

D5037: KTextEditor: prevent accidental zooming

anthonyfieroni added a comment. Ok, note this situation, hold modifier before first ever wheel event => you call m_lastWheelEvent.elapsed on unstarted timer and function returns true (m_accidentalModifier == false, m_lastWheelEventUnmodified == false) REVISION DETAIL https://phabricator.kd

D5034: Add support for x-gvfs style options in fstab

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. The patch looks good to me (without testing this locally here). I think the one QStringRef can be turned by to QStringList, since you finally need the QString anyways it seems... INLIN

D5037: KTextEditor: prevent accidental zooming

rjvbb added a subscriber: luebking. REVISION DETAIL https://phabricator.kde.org/D5037 To: rjvbb, #ktexteditor Cc: luebking, anthonyfieroni, dhaumann, kwrite-devel, #ktexteditor, #frameworks, head7, cullmann, kfunk, sars

D5037: KTextEditor: prevent accidental zooming

rjvbb added a comment. In https://phabricator.kde.org/D5037#94944, @anthonyfieroni wrote: > Ok, we discard first wheel event cause elapsed timer isn't started, right? No, it's not discarded; no wheel events are being discarded unless they already were being discarded. What my addi

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 12, 2017, 3:49 p.m., David Faure wrote: > > src/ioslaves/file/kauth/helper.cpp, line 14 > > > > > > Why is this using a QueuedConnection? This prevents any sort of error > > handling because this metho

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 13, 2017, 12:10 p.m., Elvis Angelaccio wrote: > > I'm not sure if we should show the warning dialog at the kio_file level. > > This would result in a double dialog when deleting files with Shift+Del > > from file managers. What about making jobuidelegate.cpp smarter? It could > > sh

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/ --- (Updated March 14, 2017, 2:48 p.m.) Review request for KDE Frameworks, Da

D5037: KTextEditor: prevent accidental zooming

anthonyfieroni added a comment. Ok, we discard first wheel event cause elapsed timer isn't started, right? I think we can "catch" all events we just make it a bit different, set modifiers in contructor and restart elpased timer on global event override function if desired modifiers presents,

D5037: KTextEditor: prevent accidental zooming

rjvbb updated this revision to Diff 12466. rjvbb added a comment. This makes unsetting the modifier non-optional and rewords some comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5037?vs=12448&id=12466 REVISION DETAIL https://phabricator.kde.org/D5037 AFFECTED FILES src/

D5037: KTextEditor: prevent accidental zooming

rjvbb marked an inline comment as done. rjvbb added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kateviewinternal.cpp:76 > About me, it's designed to unset modifiers so param looks unwanted. I don't disagree but not for exactly the same reason. I'm not sure the function is or shou

D4799: Delay notifications until desktop session has loaded

vpilo added reviewers: davidedmundson, dfaure, broulik, graesslin, mck182. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4799 To: vpilo, #plasma, #plasma_workspaces, davidedmundson, dfaure, broulik, graesslin, mck182 Cc: plasma-devel, davidedmundson, dfaure, br

D5037: KTextEditor: prevent accidental zooming

anthonyfieroni added inline comments. INLINE COMMENTS > kateviewinternal.cpp:76 > + > +bool detectZoomingEvent(QWheelEvent *e, bool unsetModifier=true, > Qt::KeyboardModifiers modifier=Qt::ControlModifier) > +{ About me, it's designed to unset modifiers so param looks unwanted. > katev

D5034: Add support for x-gvfs style options in fstab

broulik updated this revision to Diff 12457. broulik added a comment. - Cache mountOptions or else it falls out of scope and QStringRef crashes (now I know why I should cache it :D) REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5034?vs=12456&id=12457 REVIS

D5034: Add support for x-gvfs style options in fstab

broulik updated this revision to Diff 12456. broulik edited the summary of this revision. broulik added a comment. - Use QStringRef - Drop swap of vendor/product, this will be done in a separate patch REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5034?vs=1

D5034: Add support for x-gvfs style options in fstab

broulik added inline comments. INLINE COMMENTS > broulik wrote in fstabdevice.cpp:40-41 > I wondered that too, that's in the original patch, though, didn't really look > into where this will end up, though :D Just checked, this way round it makes more sense. The vendor will be the host name an

D4508: Plasma controls based on QtQuickControls2

This revision was automatically updated to reflect the committed changes. Closed by commit R242:76af5399dd95: Plasma controls based on QtQuickControls2 (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11960&id=12454