D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

2017-03-11 Thread Yuen Hoe Lim
yuenlim updated this revision to Diff 12403. yuenlim added a comment. Something like this? REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5013?vs=12391&id=12403 REVISION DETAIL https://phabricator.kde.org/D5013 AFFECTED FILES src/core/job.cpp src/core/j

D5023: Restore Cancel button shortcut

2017-03-11 Thread Sergey Kalinichev
skalinichev created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY "Ok" and "Cancel" buttons are commonly used with alt+o and alt+c shortcuts. But currently alt+c shortcut is assigned to the Checksums tab, which is very confusing especially when Checksums p

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 376 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/376/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 12 Mar 2017 04:35:36 + Build duration: 2 min 22 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 376 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/376/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 12 Mar 2017 04:35:36 + Build duration: 2 min 22 sec CHANGE SET Revisi

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 461 - Still Unstable!

2017-03-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/461/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 01:30:39 + Build duration: 8 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 466 - Unstable!

2017-03-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/466/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 12 Mar 2017 01:34:44 + Build duration: 8 min 8 sec CHANGE SET No changes JUNIT RESULTS Name: (r

D5017: Fix ecm_generate_pkgconfig_file compatibility with new cmake

2017-03-11 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R240:3980f36db018: Fix ecm_generate_pkgconfig_file compatibility with new cmake (authored by xuetianweng). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D501

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 460 - Unstable!

2017-03-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/460/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 22:51:50 + Build duration: 6 min 3 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 465 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/465/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 22:01:00 + Build duration: 5 min 38 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 465 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/465/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 22:01:00 + Build duration: 5 min 38 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 262 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/262/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 21:45:11 + Build duration: 4 min 57 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 262 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/262/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 21:45:11 + Build duration: 4 min 57 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 261 - Failure!

2017-03-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/261/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:51:38 + Build duration: 1 min 33 sec CHANGE SET Revision c2fbab94b030e16d925c0f09c0bb6d

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

2017-03-11 Thread John Salatas
jsalatas updated this revision to Diff 12396. jsalatas added a comment. Implemented additional functions as non-virtuals, according to @cullmann's suggestion. It's much better and cleaner this way! REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D494

Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux,gcc - Build # 159 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesignerplugin%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/159/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:39:22 + Build duration: 1 min 3 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux,gcc - Build # 159 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdesignerplugin%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/159/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:39:22 + Build duration: 1 min 3 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 459 - Failure!

2017-03-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/459/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:24:28 + Build duration: 3 min 23 sec CHANGE SET Revision 366f509c0ddc6e0618baca2514b0ab4e9130c173 b

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 375 - Unstable!

2017-03-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/375/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 11 Mar 2017 20:22:03 + Build duration: 2 min 46 sec CHANGE SET Revis

Jenkins-kde-ci: kplotting master kf5-qt5 » Linux,gcc - Build # 134 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kplotting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/134/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:16:21 + Build duration: 55 sec CHANGE SET Revision 917b1ab54238816096b6832ac03a58d7adb32a36 b

Jenkins-kde-ci: kplotting master kf5-qt5 » Linux,gcc - Build # 134 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kplotting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/134/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:16:21 + Build duration: 55 sec CHANGE SET Revision 917b1ab54238816096b6832ac03a58d7adb32a36 b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 464 - Failure!

2017-03-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/464/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:11:32 + Build duration: 6 min 24 sec CHANGE SET Revision 366f509c0ddc6e0618baca2514b0ab4e913

Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux,gcc - Build # 158 - Failure!

2017-03-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdesignerplugin%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/158/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 20:00:41 + Build duration: 3 min 7 sec CHANGE SET Revision 1c4b4ef1a8cc6f769e403607

Jenkins-kde-ci: kplotting master kf5-qt5 » Linux,gcc - Build # 133 - Unstable!

2017-03-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kplotting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/133/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Mar 2017 19:51:21 + Build duration: 50 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 156 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/156/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 11 Mar 2017 19:16:56 + Build duration: 5 min 9 sec CHANGE SET No chan

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 156 - Fixed!

2017-03-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/156/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 11 Mar 2017 19:16:56 + Build duration: 5 min 9 sec CHANGE SET No chan

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

2017-03-11 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Extra credit for factorizing this into a file-static function and handling data: URLs separately (no point in seeing 100 chars of data crap, we could do data:[...] or something like that).

D5017: Fix ecm_generate_pkgconfig_file compatibility with new cmake

2017-03-11 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5017 To: xuetianweng, #frameworks, dfaure Cc: #build_system

D5017: Fix ecm_generate_pkgconfig_file compatibility with new cmake

2017-03-11 Thread Xuetian Weng
xuetianweng created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY CMP0053 specifies that: - Expansion of ``@VAR@`` reference syntax defined by the ``configure_file()`` and ``string(C

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

2017-03-11 Thread Yuen Hoe Lim
yuenlim updated this revision to Diff 12391. yuenlim added a comment. Use KStringHandler::csqueeze for truncating! REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5013?vs=12380&id=12391 REVISION DETAIL https://phabricator.kde.org/D5013 AFFECTED FILES src/c

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

2017-03-11 Thread Christoph Cullmann
cullmann added a comment. Hmm, for the interface thing: You could avoid that entirely if you just add the functions as non-virtual ones. That is now possible in KF5, e.g. see insertTemplate(...) method. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: j

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

2017-03-11 Thread David Faure
dfaure added a comment. Can you use KStringHandler::csqueeze ? This way filenames are still visible. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5013 To: yuenlim, #plasma Cc: dfaure, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D5013: Truncate url string in KIO::job description to avoid freezing up plasma notification

2017-03-11 Thread Yuen Hoe Lim
yuenlim created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY When posting large raw image data to imgur in QuickShare, the KIO job ends up triggering a notification that displays th

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

2017-03-11 Thread John Salatas
jsalatas added a comment. ping? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor Cc: dhaumann, anthonyfieroni, mwolff, kwrite-devel