[Differential] [Accepted] D4439: KDirWatch: fix memory leak on destruction.

2017-02-06 Thread Michael Pyne
mpyne accepted this revision. mpyne added a comment. The diff as proposed is just fine. I've been bitten by `qDeleteAll` at proc exit before when called on objects that have complex destructors, but that's not the case here. It would probably be a good idea to try to streamline the code

Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-06 Thread Michael Pyne
On Mon, Feb 06, 2017 at 11:35:15PM +0100, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > > Hi everyone, > > > > From this point forward, communities should be moving away from > > Reviewboard to Phabricator for conducting code review. Sy

Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-06 Thread Albert Astals Cid
El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > Hi everyone, > > From this point forward, communities should be moving away from > Reviewboard to Phabricator for conducting code review. Sysadmin will > be announcing a timeline for the shutdown of Reviewboard in the

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

2017-02-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review102430 --- See bug 37 for a regression. Not sure if it is fixable.

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 242 - Fixed!

2017-02-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/242/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 19:04:24 + Build duration: 1 min 45 sec CHANGE SET Revision a714eec8bfb5f123bd7bdce8508455f649fe3

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 242 - Fixed!

2017-02-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/242/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 19:04:24 + Build duration: 1 min 45 sec CHANGE SET Revision a714eec8bfb5f123bd7bdce8508455f649fe3

[Differential] [Closed] D4463: Konqueror can no longer be selected as default file manager

2017-02-06 Thread Jonathan Marten
This revision was automatically updated to reflect the committed changes. Closed by commit R226:c27a79e2dbab: Restore the ability to select Konqueror as the default file manager (authored by marten). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4463?vs=10973&id=10978#toc REPOSITORY R

[Differential] [Accepted] D4463: Konqueror can no longer be selected as default file manager

2017-02-06 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfmclient_dir.desktop:9 > +# Must be more than gwenview > +InitialPreference=10 > +NoDisplay=true Please make it 9, Dolphin has 10 as well, and Dolphin should be the de

[Differential] [Request, 105 lines] D4463: Konqueror can no longer be selected as default file manager

2017-02-06 Thread Jonathan Marten
marten created this revision. marten added reviewers: Frameworks, dfaure. marten set the repository for this revision to R226 Konqueror. REVISION SUMMARY Konqueror was originally able to be selected as the default file manager by using kcmshell5 componentchooser ("Default Applications"). Now i

[Differential] [Closed] D4436: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout

2017-02-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:c21ff749e646: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabric

[Differential] [Accepted] D4436: [Button Styles] Use Layout.fillHeight instead of parent.height in a Layout

2017-02-06 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4436 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brouli

[Differential] [Commented On] D4425: Add support for flatpak portals

2017-02-06 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > apol wrote in knotificationmanager.cpp:93 > Maybe instead of querying for dbus things we could figure out a what > QPlatformTheme is in use somehow? Not sure how that would help. It would help maybe to detect whether we are in sandbox if we che

[Differential] [Commented On] D4425: Add support for flatpak portals

2017-02-06 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > knotificationmanager.cpp:93 > + > +if (d->inSandbox) { > +QDBusConnectionInterface *interface = > QDBusConnection::sessionBus().interface(); Maybe instead of querying for dbus things we could figure out a what QPlatformTheme is in use s

[Differential] [Closed] D4453: [ContainmentInterface] Also align containment context menu to panel

2017-02-06 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1b02bfdff71e: [ContainmentInterface] Also align containment context menu to panel (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kd

[Differential] [Accepted] D4453: [ContainmentInterface] Also align containment context menu to panel

2017-02-06 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4453 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Request, 2 lines] D4453: [ContainmentInterface] Also align containment context menu to panel

2017-02-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY There'

Re: Review Request 129911: Added property() method to TerminalInterface class

2017-02-06 Thread Sven Fischer
> On Feb. 5, 2017, 9:48 vorm., David Faure wrote: > > Alas, this is a binary incompatible change. It cannot be done this way. > > Solution 1: a V2 interface inheriting from this one (as we had in the past, > > IIRC). > > Solution 2: just use QObject dynamic properties, after documenting that in

Re: Review Request 129911: Added property() method to TerminalInterface class

2017-02-06 Thread Sven Fischer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129911/ --- (Updated Feb. 6, 2017, 9:03 vorm.) Status -- This change has been di

Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements

2017-02-06 Thread Diego S.
> On Feb. 5, 2017, 9:50 a.m., David Faure wrote: > > Can you also deprecate DrawFrame, then? > > Diego S. wrote: > How does stuff get deprecated in Frameworks? I don't have a lot of kde > development (or development in general) experience. I also don't have a > proper dev environment setup

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 424 - Still Unstable!

2017-02-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/424/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Feb 2017 08:13:22 + Build duration: 9 min 44 sec CHANGE SET Revision 8d9fde5daede2315a1d45052828c70f149

Re: Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements

2017-02-06 Thread David Faure
> On Feb. 5, 2017, 9:50 a.m., David Faure wrote: > > Can you also deprecate DrawFrame, then? > > Diego S. wrote: > How does stuff get deprecated in Frameworks? I don't have a lot of kde > development (or development in general) experience. I also don't have a > proper dev environment setup