cfeck added inline comments.
INLINE COMMENTS
> kurlrequester.h:144
> /**
> + * Returns the mimetype filters for the file dialog.
> + * @see QFileDialog::setMimeTypeFilters()
The APIDOX for these two functions are somehow swapped.
REPOSITORY
R241 KIO
REVISION DETAIL
https://pha
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/karchive%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/145/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 05 Feb 2017 00:51:13 +
Build duration: 5 min 0 sec
CHANGE SET
Revision 2225527bb6befd4d32d167898835649
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/karchive%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/145/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 05 Feb 2017 00:51:13 +
Build duration: 5 min 0 sec
CHANGE SET
Revision 2225527bb6befd4d32d167898835649
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/147/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 05 Feb 2017 00:51:13 +
Build duration: 4 min 8 sec
CHANGE SET
Revision 2225527bb6befd4d32d1678988356490ed0db8
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/147/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 05 Feb 2017 00:51:13 +
Build duration: 4 min 8 sec
CHANGE SET
Revision 2225527bb6befd4d32d1678988356490ed0db8
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:2225527bb6be: Fix my fix for KCompressionDevice::seek
(authored by aacid).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4437?vs=10921&id=10922#toc
REPOSITORY
R243 KArchive
CHANGES SINCE L
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah yes of course, this is what I meant. TV distracted me :)
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D4437
EMAIL PREFERENCES
https://phabricator.kde.org/s
aacid updated this revision to Diff 10921.
aacid added a comment.
We can save some seek calls, but we still need it in the if, there's nothing
that guaranteers that "QIODevice::pos" will be d->deviceReadPos so we need to
seek to d->deviceReadPos.
REPOSITORY
R243 KArchive
CHANGES SINCE LAS
dfaure added inline comments.
INLINE COMMENTS
> kcompressiondevice.cpp:208
> +// asked us to be in
> +if (!QIODevice::seek(d->deviceReadPos)) {
> +return false;
I wonder if we could avoid seeking twice, by doing seek(pos) only in the other
cases (the deviceReadPos ==
aacid created this revision.
aacid added a reviewer: dfaure.
aacid set the repository for this revision to R243 KArchive.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This f
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129921/
---
Review request for KDE Frameworks.
Repository: kio-extras
Description
-
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/414/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 20:54:22 +
Build duration: 5 min 28 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) Fa
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/414/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 20:54:22 +
Build duration: 5 min 28 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) Fa
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/418/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 19:39:56 +
Build duration: 19 min
CHANGE SET
Revision 4f8e9f45c600ea6f246fcf3b84a7adc7792276bc
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/418/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 19:39:56 +
Build duration: 19 min
CHANGE SET
Revision 4f8e9f45c600ea6f246fcf3b84a7adc7792276bc
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kguiaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/134/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 19:52:39 +
Build duration: 55 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) F
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kguiaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/134/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 19:52:39 +
Build duration: 55 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) F
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/413/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 19:47:41 +
Build duration: 7 min 23 sec
CHANGE SET
Revision 4f8e9f45c600ea6f246fcf3b84a7adc7792276bc
On Sun, Feb 5, 2017 at 8:45 AM, Nicolás Alvarez
wrote:
> 2017-02-04 16:19 GMT-03:00 David Faure :
>> Today the CI seems capricious ;)
>>
>> - build.kde.org was down for a bit
>
> Yep, Jenkins ran out of memory in the JVM. Restarted a while ago.
>
>> - DNS problems in
>> https://build.kde.org/view
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/238/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 19:24:40 +
Build duration: 1 min 41 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/238/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 19:24:40 +
Build duration: 1 min 41 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:54:33 +
Build duration: 5 min 29 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:54:33 +
Build duration: 5 min 29 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
On samedi 4 février 2017 20:27:59 CET Albert Astals Cid wrote:
> El dissabte, 4 de febrer de 2017, a les 20:19:53 CET, David Faure va
escriure:
> > Today the CI seems capricious ;)
>
> Seems my karchive patch broke another karchive test, that for some reason i
> had not seen failing before.
Yep.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129839/#review102387
---
No need to move this (yet).
src/extractors/taglibextractor
2017-02-04 16:19 GMT-03:00 David Faure :
> Today the CI seems capricious ;)
>
> - build.kde.org was down for a bit
Yep, Jenkins ran out of memory in the JVM. Restarted a while ago.
> - DNS problems in
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kparts%20master%20kf5-qt5/409/console
Bl
dfaure accepted this revision.
dfaure added a reviewer: dfaure.
This revision is now accepted and ready to land.
REPOSITORY
R302 KIconThemes
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4247
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/417/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:44:14 +
Build duration: 7 min 55 sec
CHANGE SET
Revision c9cbe637a77acba06d3a94dac2960102df
El dissabte, 4 de febrer de 2017, a les 20:19:53 CET, David Faure va escriure:
> Today the CI seems capricious ;)
Seems my karchive patch broke another karchive test, that for some reason i
had not seen failing before.
If you're going to do the release *now* you can revert mine temporarily or tr
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/237/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:41:37 +
Build duration: 1 min 57 sec
CHANGE SET
Revision 4ce699c8643a88a83a555711ef1e5077878a
Today the CI seems capricious ;)
- build.kde.org was down for a bit
- DNS problems in
https://build.kde.org/view/Frameworks%20kf5-qt5/job/kparts%20master%20kf5-qt5/409/console
- "QXcbConnection: Could not connect to display :99" problems in many cases
like
https://build.kde.org/view/Frameworks%
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4f8e9f45c600: Add KUrlRequester::setMimeTypeFilters.
(authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4431?vs=10912&id=10914#toc
REPOSITORY
R241 KIO
CHANGES SINCE LAST U
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/karchive%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/144/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:38:41 +
Build duration: 57 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (r
On Sat, Feb 4, 2017 at 7:28 PM, Ben Cooksley wrote:
> On Sun, Feb 5, 2017 at 6:30 AM, Albert Astals Cid wrote:
>> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va
>> escriure:
>>> Hi everyone,
>>>
>>> We've just completed the registration of all mainline repositories
>>> (not
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/150/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:34:41 +
Build duration: 4 min 13 sec
CHANGE SET
Revision d29
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/148/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:34:41 +
Build duration: 4 min 11 sec
CHANGE SET
Revis
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kitemviews%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/129/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:22:41 +
Build duration: 4 min 2 sec
CHANGE SET
Revision e180bee24ec6a62b1d0c511e00a8e0c9883
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D4405
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, emmanuelp, hein, dfaure
Cc: #frameworks
markg accepted this revision.
markg added a reviewer: markg.
markg added a comment.
This revision is now accepted and ready to land.
Looks good to me.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4431
EMAIL PREFERENCES
https://phabricator.kde.org/se
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kguiaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/133/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:17:46 +
Build duration: 52 sec
CHANGE SET
Revision 2464490d761aeee5eda63d6371187261aaffa3a4
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/148/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:13:24 +
Build duration: 1 min 6 sec
CHANGE SET
Revision c285d33156382edf65fb2338f33cb8
On Sun, Feb 5, 2017 at 6:30 AM, Albert Astals Cid wrote:
> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure:
>> Hi everyone,
>>
>> We've just completed the registration of all mainline repositories
>> (not including Websites or Sysadmin namespaced ones) on Phabricator.
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:05:37 +
Build duration: 1 min 13 sec
CHANGE SET
Revision 7e3cd717e10fd63e0a68694d88c8b2cfdbf5
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/karchive%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/143/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 18:05:37 +
Build duration: 1 min 25 sec
CHANGE SET
Revision 14653ce06ab31eaaa7a9eef75a257
dfaure created this revision.
dfaure added a reviewer: mlaurent.
dfaure added a subscriber: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Otherwise people need to call the deprecated fileDialog() method to set it,
which creates the file dialog too early.
TES
On samedi 4 février 2017 10:46:41 CET Stephen Kelly wrote:
> On 02/04/2017 08:14 AM, Matthew Dawson wrote:
> > On Thursday, February 2, 2017 10:08:53 PM EST Jaroslaw Staniek wrote:
> >> On 1 February 2017 at 14:34, David Faure wrote:
> >>> One note though: this is a failure to link a unittest, you
> Does anyone have love for the current syntax?
I have a khotkeys macro for that... +1 for DIFFERENTIAL. It also seems that
release scripts don't extract Phabricator links for inclusion in the changelog
(it does that with REVIEW)
Cheers,
Kai Uwe
dfaure added a comment.
Yeah using qiodevice_p.h is out of the question ;)
For info the commit log syntax for autoclosing is
Differential Revision: https://phabricator.kde.org/D4422
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D4422
EMAIL PREFERENCES
http
El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure:
> Hi everyone,
>
> We've just completed the registration of all mainline repositories
> (not including Websites or Sysadmin namespaced ones) on Phabricator.
> Thanks go to Luigi Toscano for providing significant assista
El dissabte, 4 de febrer de 2017, a les 12:44:54 CET, Ben Cooksley va
escriure:
> On Sat, Feb 4, 2017 at 11:41 AM, Albert Astals Cid wrote:
> > El divendres, 3 de febrer de 2017, a les 21:06:08 CET, Ben Cooksley va
> >
> > escriure:
> >> On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid wrote:
graesslin added a comment.
In https://phabricator.kde.org/D4416#83019, @mck182 wrote:
> In https://phabricator.kde.org/D4416#82951, @hein wrote:
>
> > Gnome-only spec? Why aren't they contributing to fd.o?
>
>
> "Galago is dead, we took over, deal with it."
>
> https://bugzil
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 16:03:34 +
Build duration: 2 min 38 sec
CHANGE SET
Revision 14653ce06ab31eaaa7a9eef75a257e17a048f
aacid added a comment.
In https://phabricator.kde.org/D4422#82977, @dfaure wrote:
> So your patch adds a member variable which duplicates
QIODevice::d->devicePos, but there's no other solution without adding more API
to QIODevice.
>
> I deem QIODevice API incomplete, and your patch c
aacid closed this revision.
aacid added a comment.
I commited it, but instructions at
https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
where unclear and i failed to do it correctly
https://cgit.kde.org/karchive.git/commit/?id=14653ce06ab31eaa
mck182 added a comment.
In https://phabricator.kde.org/D4416#82951, @hein wrote:
> Gnome-only spec? Why aren't they contributing to fd.o?
"Galago is dead, we took over, deal with it."
https://bugzilla.gnome.org/show_bug.cgi?id=745634#c25
REPOSITORY
R289 KNotifications
BRAN
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/225/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 14:11:53 +
Build duration: 5 min 40 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/225/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 14:11:53 +
Build duration: 5 min 40 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 13:46:33 +
Build duration: 1 min 46 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 13:46:33 +
Build duration: 1 min 46 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/224/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 13:46:33 +
Build duration: 6.4 sec
CHANGE SET
No changes
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/235/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 13:36:35 +
Build duration: 5 min 36 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (ro
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/229/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 12:25:16 +
Build duration: 5 min 10 sec
CHANGE SET
No changes
JUNIT RESULTS
Na
On samedi 4 février 2017 10:46:41 CET Stephen Kelly wrote:
> On 02/04/2017 08:14 AM, Matthew Dawson wrote:
> > On Thursday, February 2, 2017 10:08:53 PM EST Jaroslaw Staniek wrote:
> >> On 1 February 2017 at 14:34, David Faure wrote:
> >>> One note though: this is a failure to link a unittest, you
On 02/04/2017 12:49 PM, David Faure wrote:
>> @David Faure, when do you plan on tagging this change? For now I committed
>> a change to the auto test so it will at least build on Windows
>> (b939b48f8d5e5eaf9a51a7e9bda2ad8cedca27d9) which should be included. Would
>> there be time to remove KEntr
On samedi 4 février 2017 09:14:08 CET Matthew Dawson wrote:
> On Thursday, February 2, 2017 10:08:53 PM EST Jaroslaw Staniek wrote:
> > On 1 February 2017 at 14:34, David Faure wrote:
> > > One note though: this is a failure to link a unittest, your release
> > > isn't
> > > blocked, you can just
dfaure accepted this revision.
dfaure added a reviewer: dfaure.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks for the fix.
I had difficulties to understand "Don't use QIODevice:pos to track our pos,
doesn't work.", so I investigated a bit and indeed QIODe
Stephen Kelly ha scritto:
> On 02/04/2017 08:14 AM, Matthew Dawson wrote:
>> On Thursday, February 2, 2017 10:08:53 PM EST Jaroslaw Staniek wrote:
>>> On 1 February 2017 at 14:34, David Faure wrote:
One note though: this is a failure to link a unittest, your release isn't
blocked, you ca
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/234/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 12:24:45 +
Build duration: 1 min 50 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/234/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 12:24:45 +
Build duration: 1 min 50 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/144/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 12:24:59 +
Build duration: 58 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root) Fa
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/bluez-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/128/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 11:49:06 +
Build duration: 1 min 47 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/bluez-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/128/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 11:49:06 +
Build duration: 1 min 47 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/karchive%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/143/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 04 Feb 2017 11:47:31 +
Build duration: 3 min 28 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (ro
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120096/
---
(Updated Feb. 4, 2017, 11:52 a.m.)
Status
--
This change has been di
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122795/#review102371
---
Patch does not apply anymore.
- Albert Astals Cid
On Marc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123031/#review102369
---
This patch does not apply anymore.
- Albert Astals Cid
On
apol added a comment.
In https://phabricator.kde.org/D4416#82951, @hein wrote:
> Gnome-only spec? Why aren't they contributing to fd.o?
That's most certainly not the best forum to discuss this.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricato
This is from GIT master. Problem still exists, but I could try disabling
unit tests and continue. I hope it gets fixed anyway soon so that other
users wouldn't run into the same problem.
On Fri, Feb 3, 2017 at 12:08 AM, Jaroslaw Staniek wrote:
>
>
> On 1 February 2017 at 14:34, David Faure wrot
broulik added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:86
> +if (!runtimeDir.isEmpty()) {
> +d->inSandbox = QFile::exists(runtimeDir +
> QLatin1String("/flatpak-info"));
> +}
`QFileInfo::exists` supposedly is faster
> knotificationmanager.cpp:91
> +// Als
apol added a comment.
Some coding style suggestions.
General +1.
INLINE COMMENTS
> knotificationmanager.cpp:85
> +const QString runtimeDir = qgetenv("XDG_RUNTIME_DIR");
> +if (!runtimeDir.isEmpty()) {
> +d->inSandbox = QFile::exists(runtimeDir +
> QLatin1String("/flatpak-in
On Sat, Feb 4, 2017 at 1:15 PM, Kai Uwe Broulik wrote:
>> This is not ok, the web interface for reviewboard was as good as rb-tools (I
>> guess tbh i never used them) and "forcing" the use of a weird tool noone has
>> heard of is not a good way to attract new contributors
>
> Agreed. Especially
On 02/04/2017 08:14 AM, Matthew Dawson wrote:
> On Thursday, February 2, 2017 10:08:53 PM EST Jaroslaw Staniek wrote:
>> On 1 February 2017 at 14:34, David Faure wrote:
>>> One note though: this is a failure to link a unittest, your release isn't
>>> blocked, you can just disable the building of u
On Thursday, February 2, 2017 10:08:53 PM EST Jaroslaw Staniek wrote:
> On 1 February 2017 at 14:34, David Faure wrote:
> > One note though: this is a failure to link a unittest, your release isn't
> > blocked, you can just disable the building of unittests in kconfig.
> >
> > The double definiti
84 matches
Mail list logo
