[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-03 Thread Eike Hein
hein added a comment. Gnome-only spec? Why aren't they contributing to fd.o? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D4416 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, ap

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 414 - Fixed!

2017-02-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/414/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 01:19:24 + Build duration: 5 min 31 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 414 - Fixed!

2017-02-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/414/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 01:19:24 + Build duration: 5 min 31 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 413 - Failure!

2017-02-03 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/413/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 01:00:00 + Build duration: 2 min 11 sec CHANGE SET Revision 5ce93f9d9e67ff60027a0c1a451ac5ded

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 407 - Fixed!

2017-02-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/407/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 00:45:39 + Build duration: 6 min 22 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 407 - Fixed!

2017-02-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/407/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Feb 2017 00:45:39 + Build duration: 6 min 22 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Kai Uwe Broulik
> This is not ok, the web interface for reviewboard was as good as rb-tools (I > guess tbh i never used them) and "forcing" the use of a weird tool noone has > heard of is not a good way to attract new contributors Agreed. Especially since arc is some mental php script that randomly amends wron

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 228 - Still Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/228/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Feb 2017 23:56:49 + Build duration: 1 min 53 sec CHANGE SET Revision a919d6e4c0164975d40a247fe3437

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 233 - Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/233/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Feb 2017 23:56:49 + Build duration: 1 min 57 sec CHANGE SET Revision a919d6e4c0164975d40a247fe34370c79f15

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 406 - Unstable!

2017-02-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/406/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Feb 2017 23:45:50 + Build duration: 9 min 18 sec CHANGE SET Revision 6a1b24676aa01f9aed272a612b5432402bf1a3a5

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 412 - Fixed!

2017-02-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/412/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Feb 2017 23:45:50 + Build duration: 7 min 12 sec CHANGE SET Revision 6a1b24676aa01f9aed272a612b5432402bf

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 412 - Fixed!

2017-02-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/412/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Feb 2017 23:45:50 + Build duration: 7 min 12 sec CHANGE SET Revision 6a1b24676aa01f9aed272a612b5432402bf

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Ben Cooksley
On Sat, Feb 4, 2017 at 11:41 AM, Albert Astals Cid wrote: > El divendres, 3 de febrer de 2017, a les 21:06:08 CET, Ben Cooksley va > escriure: >> On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid wrote: >> > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va > escriure: >> >> H

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Ben Cooksley
On Fri, Feb 3, 2017 at 11:37 PM, René J.V. Bertin wrote: > On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote: > >>You missed the point. This "bit rot" is not about disk damage but >>about software incompatibility. ZFS doesn't help with that... > > You mean diffs that no longer apply clean

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Albert Astals Cid
El divendres, 3 de febrer de 2017, a les 10:24:08 CET, Elvis Angelaccio va escriure: > On Fri, Feb 3, 2017 at 9:06 AM, Ben Cooksley wrote: > > On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid wrote: > >> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > >>> Hi e

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Albert Astals Cid
El divendres, 3 de febrer de 2017, a les 21:06:08 CET, Ben Cooksley va escriure: > On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid wrote: > > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > >> Hi everyone, > >> > >> We've just completed the registration of al

[Differential] [Accepted] D4421: Reverse meaning of :split, :vsplit to match vi and Kate actions.

2017-02-03 Thread Michal Humpula
michalhumpula accepted this revision. michalhumpula added a reviewer: michalhumpula. michalhumpula added a comment. This revision is now accepted and ready to land. Hi Francis, it probably got switched during massive refactor few years back by me. Looks good. Thanks for the fix! REPOSITORY

Review Request 129911: Added property() method to TerminalInterface class

2017-02-03 Thread Sven Fischer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129911/ --- Review request for KDE Frameworks. Repository: kparts Description -

[Differential] [Commented On] D4421: Reverse meaning of :split, :vsplit to match vi and Kate actions.

2017-02-03 Thread Christoph Cullmann
cullmann added a comment. If that is more consistent with vi, I am ok with that ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4421 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #ktexteditor Cc: cullmann, mwolf

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

2017-02-03 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D4422#82875, @anthonyfieroni wrote: > I understand code, it will work now, but to me it's a workaround. Why is it a workaround? > What about to call QIODevice::seek(0) in constructor, other unchanged to original code ?

[Differential] [Closed] D4355: Add methods to hide the reveal password action

2017-02-03 Thread Christoph Feck
cfeck closed this revision. cfeck added a comment. Submitted as https://commits.kde.org/kwidgetsaddons/307d54fcee3a41e1d8b3dafd16212b5b8d7c8a22 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D4355 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

2017-02-03 Thread Anthony Fieroni
anthonyfieroni added a comment. I understand code, it will work now, but to me it's a workaround. What about to call QIODevice::seek(0) in constructor, other unchanged to original code ? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D4422 EMAIL PREFERENCES https

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

2017-02-03 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D4422#82848, @anthonyfieroni wrote: > > When subclassing QIODevice, you must call QIODevice::seek() at the start of your function to ensure integrity with QIODevice's built-in buffer. > > http://doc.qt.io/qt-5/qiodevice.html#seek

[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

2017-02-03 Thread Anthony Fieroni
anthonyfieroni added a comment. > When subclassing QIODevice, you must call QIODevice::seek() at the start of your function to ensure integrity with QIODevice's built-in buffer. http://doc.qt.io/qt-5/qiodevice.html#seek For me, i'm not test it, it should be if (!QIODevice::see

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Luigi Toscano
René J.V. Bertin ha scritto: > On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote: > >> You missed the point. This "bit rot" is not about disk damage but >> about software incompatibility. ZFS doesn't help with that... > > You mean diffs that no longer apply cleanly? In that case you miss

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread René J . V . Bertin
On Thursday February 2 2017 21:50:38 Nicolás Alvarez wrote: >You missed the point. This "bit rot" is not about disk damage but >about software incompatibility. ZFS doesn't help with that... You mean diffs that no longer apply cleanly? In that case you missed our point. Being able to consult inte

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Elvis Angelaccio
On Fri, Feb 3, 2017 at 9:06 AM, Ben Cooksley wrote: > On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid wrote: >> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va >> escriure: >>> Hi everyone, >>> >>> We've just completed the registration of all mainline repositories >>> (no

[Differential] [Updated] D4425: Add support for flatpak portals

2017-02-03 Thread Jan Grulich
jgrulich added a reviewer: mck182. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jgrulich, mck182 Cc: #frameworks

[Differential] [Request, 393 lines] D4425: Add support for flatpak portals

2017-02-03 Thread Jan Grulich
jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Creates a new flatpak notification plugin, which just forwards messages through DBus to xdg-desktop-portal service, otherwise there is no

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

2017-02-03 Thread Ben Cooksley
On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: >> Hi everyone, >> >> We've just completed the registration of all mainline repositories >> (not including Websites or Sysadmin namespaced ones) on Phabricator