Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

2017-01-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review102245 --- Ping - Anthony Fieroni On Ян. 21, 2017, 7:52 преди обяд,

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-25 Thread Anthony Fieroni
> On Ян. 26, 2017, 1:15 преди обяд, Albert Astals Cid wrote: > > I briefly looked at dolphins code a while ago and i'm pretty sure the code > > is wrong in dolphin > > Albert Astals Cid wrote: > BTW what do you mean with "Works correct on KDE"? The code in Dolphin isn't wrong, the applicat

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-25 Thread Albert Astals Cid
> On Jan. 25, 2017, 11:15 p.m., Albert Astals Cid wrote: > > I briefly looked at dolphins code a while ago and i'm pretty sure the code > > is wrong in dolphin BTW what do you mean with "Works correct on KDE"? - Albert --- This is an a

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/#review102239 --- I briefly looked at dolphins code a while ago and i'm pretty

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/ --- (Updated Ян. 25, 2017, 10:39 след обяд) Review request for KDE Frameworks

Review Request 129885: [KStandadAction] Correct mebars logic

2017-01-25 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/ --- Review request for KDE Frameworks, Albert Astals Cid and David Faure. Rep

[Differential] [Commented On] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

2017-01-25 Thread Kai Uwe Broulik
broulik added a comment. I was under the impression that opening a plasma config dialog would keep the popup opened but then I found that it doesn't (at least not the default popup impl) after I already submitted the patch. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL http

[Differential] [Commented On] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

2017-01-25 Thread Eike Hein
hein added a comment. This is what I suggested in IRC, but Kai had some concerns that it wasn't always desired. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4282 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

2017-01-25 Thread Kai Uwe Broulik
broulik added a comment. Cool! +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4282 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma Cc: broulik, plasma-devel, #frameworks, lesliezhai, ali-moh

[Differential] [Request, 3 lines] D4282: Dialog: Hide when focus changes to ConfigView with hideOnWindowDeactivate

2017-01-25 Thread David Rosca
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Expand applet in systray -> open config -> applet popup gets closed REPOSITORY R242 Plasma Fr

[Differential] [Closed] D4257: [PlasmaComponents Menu] Add maximumWidth property

2017-01-25 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:ceeb57d17fed: [PlasmaComponents Menu] Add maximumWidth property (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4257?vs=104

[Differential] [Updated] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-25 Thread Alexey Varfolomeev
varlesh added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4278 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreaska, alex-l, #breeze Cc: alex-l, andreaska, #frameworks

[Differential] [Updated] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-25 Thread Alexey Varfolomeev
varlesh updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4278 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreaska, alex-l Cc: alex-l, andreaska, #frameworks

[Differential] [Request, 985 lines] D4278: fix icons bittorrent-sync, codeblocks, darktable, ffmulticonverter

2017-01-25 Thread Alexey Varfolomeev
varlesh created this revision. varlesh added reviewers: andreaska, alex-l. varlesh added subscribers: andreaska, alex-l. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL htt

[Differential] [Closed] D4264: redesign android-file-transfer icon

2017-01-25 Thread Alexey Varfolomeev
This revision was automatically updated to reflect the committed changes. Closed by commit R266:5b5098054974: redesign android-file-transfer icon (authored by varlesh). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4264?vs=10480&id=10529 REVISION DETAIL

[Differential] [Accepted] D4264: redesign android-file-transfer icon

2017-01-25 Thread Andreas Kainz
andreaska accepted this revision. andreaska added a reviewer: andreaska. andreaska added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D4264#79949, @varlesh wrote: > @alex-l reverted gradient: > F2164722: Снимок экрана от 2017-01-25 01-18-07.

cbz mimetype

2017-01-25 Thread Jonathan Riddell
Comic book files of the .cbz format don't want to open in Okular in Neon dev-unstable or user now, the same has been confirmed in opensuse tumbleweed. I'm testing with file http://embra.edinburghlinux.co.uk/~jr/tmp/comic.cbz The same file works fine in Peruse. Looking in Dolphin it says the file

[Differential] [Abandoned] D4267: redesign bluefish icon

2017-01-25 Thread Alexey Varfolomeev
varlesh abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4267 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze, andreaska Cc: andreaska, alex-l, #frameworks

[Differential] [Closed] D4252: fix brackets icon

2017-01-25 Thread Alexey Varfolomeev
varlesh closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreaska Cc: guoyunhe, #frameworks

[Differential] [Closed] D4262: redesign android-studio icon

2017-01-25 Thread Alexey Varfolomeev
This revision was automatically updated to reflect the committed changes. Closed by commit R266:3eeb52f15eaf: redesign android-studio icon (authored by varlesh). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4262?vs=10477&id=10527 REVISION DETAIL http

[Differential] [Closed] D4251: Redesign aptana icon

2017-01-25 Thread Alexey Varfolomeev
This revision was automatically updated to reflect the committed changes. Closed by commit R266:3fb0f5486170: Redesign aptana icon (authored by varlesh). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4251?vs=10497&id=10526 REVISION DETAIL https://phabr

[Differential] [Closed] D4259: fix alienarena icon

2017-01-25 Thread Alexey Varfolomeev
This revision was automatically updated to reflect the committed changes. Closed by commit R266:835cba1479e9: fix alienarena icon (authored by varlesh). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4259?vs=10474&id=10525 REVISION DETAIL https://phabri

[Differential] [Closed] D4260: fix bitcoin128 icon

2017-01-25 Thread Alexey Varfolomeev
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b72ab97f1202: fix bitcoin128 icon (authored by varlesh). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4260?vs=10475&id=10524 REVISION DETAIL https://phabri

[Differential] [Closed] D4261: redesign atom icon

2017-01-25 Thread Alexey Varfolomeev
This revision was automatically updated to reflect the committed changes. Closed by commit R266:5da1d72b2416: redesign atom icon (authored by varlesh). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4261?vs=10476&id=10523 REVISION DETAIL https://phabric

[Differential] [Updated] D4267: redesign bluefish icon

2017-01-25 Thread Alexey Varfolomeev
varlesh added a commit: R266:f756dc724ee5: redesign bluefish icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4267 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze, andreaska Cc: andreaska, alex-l,