---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129665/#review102091
---
Ping
- Anthony Fieroni
On Дек. 18, 2016, 9:55 след обяд,
Error processing tokens: Error while parsing action
'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input
position (line 1, pos 32):
${JELLY_SCRIPT,template="text"}
^
java.io.IOException: remote file operation failed:
/home/jenkins/sources
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/220/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 00:13:52 +
Build duration: 5 min 32 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/220/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 00:13:52 +
Build duration: 5 min 32 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/217/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 00:09:07 +
Build duration: 1 min 56 sec
CHANGE SET
No changes
JUNIT RESULTS
Na
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/219/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 22:55:29 +
Build duration: 2 min 1 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (roo
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/216/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 18 Jan 2017 22:38:30 +
Build duration: 2 min 2 sec
CHANGE SET
No changes
JUNIT RESULTS
Nam
dfaure added a comment.
The signature of KUrl::queryItems is
queryItems(const QueryItemsOptions &options = 0),
i.e. = {}, so the caller should just not pass any value ;-)
But otherwise I agree, being explicit on the calling side is the best option.
REPOSITORY
R280 Prison
REVISION
skelly added a comment.
It's true that QFlags has a ctor taking a nullptr. The bindings-related
problem was in our handling of enums by prepending a namespace, so we would end
up with Qt::nullptr. I've fixed that in ECM, and also fixed handling of = {}
for various types too.
So, at leas
kossebau added a comment.
So seems everyone so far agrees that `{}` is best for the default value.
What about the passed argument case? Let's look at the two respective samples:
NETWinInfo info(QX11Info::connection(), win, QX11Info::appRootWindow(), {},
{});
QCOMPARE(QStringLis
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:c7f0b1453720: Fix segfault in trigrams generation and
expose MAXGRAMS constant in the header (authored by jsalatas).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4
davidedmundson added a comment.
A commented out warning doesn't make much sense.
Either it's a valid warning at which point the root cause needs fixing not
hiding, or it's wrong and should be removed.
The hard part of doing this change is working out which of those is correct.
REPOSITO
> On Jan. 16, 2017, 8:53 a.m., Kevin Funk wrote:
> > @Stephen: Let's re-introduce this patch? Laurent + me have applied
> > `Q_DECL_OVERRIDE` everywhere. Do you want to double-check?
Sorry, I didn't get pinged by email about this, despite the mention from Albert
below. Re-applying this sounds
> On Dec. 4, 2016, 2:13 p.m., Dominik Haumann wrote:
> > I guess this is fine. Please commit.
@Alexander: Do you have commit access, or should we commit this for you?
- Dominik
---
This is an automatically generated e-mail. To reply, vi
skelly added a comment.
In https://phabricator.kde.org/D3987#78468, @dfaure wrote:
> {} sounds like the best solution to me.
I think that should be used instead of nullptr anyway.
void foo(const QModelIndex& idx = {});
is obviously better than
void foo(const QModelIn
dfaure added a comment.
{} sounds like the best solution to me.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D3987
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, dfaure, kossebau
Cc: kossebau, dfaure, graess
kossebau added a comment.
Seems the nullptr for QFlags values also breaks Python binding generation:
> Attempting to build the python bindings now fails because our scripting to
> generate sip files (or sip itself - I didn't investigate further because
it
> seems obvious that the
On 01/18/2017 12:41 PM, Shaheed Haque wrote:
> Hi Steve,
>
> I have verified this works on KDE/master, and will close the review.
>
> I did see a "funny" in that I had to run CMake twice in a fresh
> directory before it would run clean. You might want to look into that
> as it was not clear to me w
Am Mittwoch, 18. Januar 2017, 21:12:07 CET schrieb Stephen Kelly:
> Hello,
>
> As a result of the recent porting from 0 to nullptr, we have things like
>
> Qt::WindowFlags f = nullptr
>
> in frameworks headers. See for example kruler. That is - enum default
> parameter values have been ported i
Hello,
As a result of the recent porting from 0 to nullptr, we have things like
Qt::WindowFlags f = nullptr
in frameworks headers. See for example kruler. That is - enum default
parameter values have been ported incorrectly.
I don't know if some clang tooling is being used to do the porting,
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/314/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 18 Jan 2017 18:44:39 +
Build duration: 2 min 56 sec
CHANGE SET
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/314/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 18 Jan 2017 18:44:39 +
Build duration: 2 min 56 sec
CHANGE SET
kossebau added a comment.
In https://phabricator.kde.org/D3987#78427, @kfunk wrote:
> In https://phabricator.kde.org/D3987#78420, @kossebau wrote:
>
> > In https://phabricator.kde.org/D3987#78383, @dfaure wrote:
> >
> > > I agree. But it's the default value anyway, so why not remov
kossebau added a comment.
In https://phabricator.kde.org/D3987#78426, @kfunk wrote:
> In https://phabricator.kde.org/D3987#78421, @kossebau wrote:
>
> > void foo(T* t);
> > void foo(QFlags flags);
> >
>
>
> Both `foo(0)` & `foo(nullptr)` would call `void foo(T* t)`, no? =
kfunk added a comment.
In https://phabricator.kde.org/D3987#78420, @kossebau wrote:
> In https://phabricator.kde.org/D3987#78383, @dfaure wrote:
>
> > I agree. But it's the default value anyway, so why not remove it
completely, thus making everyone happy?
>
>
> What do you mean
kfunk added a comment.
In https://phabricator.kde.org/D3987#78421, @kossebau wrote:
> Another possible issue with using `nullptr`as value for flags: it might
break calling methods with overloads when once a pointer type and once a flags
type is used. Not seen, but there is a risk.
>
kossebau added a comment.
Another possible issue with using `nullptr`as value for flags: it might break
calling methods with overloads when once a pointer type and once a flags type
is used. Not seen, but there is a risk.
void foo(T* t);
void foo(QFlags flags);
REPOSITORY
R280 P
kossebau added a comment.
In https://phabricator.kde.org/D3987#78383, @dfaure wrote:
> I agree. But it's the default value anyway, so why not remove it
completely, thus making everyone happy?
What do you mean by "remove"? In the samples from a few comments above, the
`0` (or now
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/313/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 18 Jan 2017 15:57:43 +
Build duration: 3 min 44 sec
CHANGE SE
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:593f8183dd4e: Set wrapMode to Text.WrapAnywhere.
(authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4189?vs=10326&id=10327
REVIS
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4189
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, mar
hein updated this revision to Diff 10326.
hein added a comment.
Better pick.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4189?vs=10325&id=10326
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4189
AFFECTED FILES
src
mperttunen created this revision.
mperttunen added a reviewer: KTextEditor.
mperttunen set the repository for this revision to R39 KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Currently in th
hein created this revision.
hein added reviewers: Plasma, mart.
hein added a subscriber: plasma-devel.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Means long main texts don't get truncated. One of the main use
dfaure added a comment.
I agree. But it's the default value anyway, so why not remove it completely,
thus making everyone happy?
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D3987
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
kossebau added a comment.
> This is what we are using now and were using before. Seeing
MyFlags(nullptr) may look odd at first, but it's totally fine.
I agree that it is fine from a compiling POV. But from a human-reading-code
POV having a nullptr (thus a pointer) being assigned to a bit
marten created this revision.
marten added reviewers: Frameworks, Plasma.
marten set the repository for this revision to R290 KPackage.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As described in https://bug
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129760/
---
(Updated Jan. 18, 2017, 12:45 p.m.)
Status
--
This change has been d
Hi Steve,
I have verified this works on KDE/master, and will close the review.
I did see a "funny" in that I had to run CMake twice in a fresh directory
before it would run clean. You might want to look into that as it was not
clear to me what it CMake is trying to do. Anyway, here is the first
u
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:1388fb14b9d9: if is not an archive, always copy (authored
by mart).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4118?vs=10313&id=10314
REVISION DETAIL
https
mart updated this revision to Diff 10313.
mart added a comment.
- more comments
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4118?vs=10132&id=10313
BRANCH
phab/isarchive
REVISION DETAIL
https://phabricator.kde.org/D4118
AFFECTED FILES
src/core/
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Right. I think we can sensibly pick this. I would like a comment added,
though, that future "don't simply install things" logic should go into the
section above this one, rather than into t
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:6393cd598bb7: sort alphabetically category list (authored
by mart).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4156?vs=10274&id=10312
REVISION DETAIL
https
elvisangelaccio added a comment.
In https://phabricator.kde.org/D3850#72081, @kfunk wrote:
> In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote:
>
> > What about adding a way (cmake variable?) to opt-in if one wants to use
the alternative operators? Personally I like a
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
LGTM :)
REPOSITORY
R304 KNewStuff
BRANCH
phab/sort
REVISION DETAIL
https://phabricator.kde.org/D4156
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D4181
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #plasma, mart
Cc
kfunk added a comment.
In https://phabricator.kde.org/D3987#78257, @kossebau wrote:
> Seems the porting script had a few wrong matches, where 0 values for enums
were misinterpreted as pointer:
>
> E.g.
>
> @@ -1015 +1015 @@ void KWindowSystemPrivateX11::setShowingDesktop(bool
s
47 matches
Mail list logo
