[Differential] [Updated, 122 lines] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2017-01-10 Thread Jonathan Schultz
jonathans set the repository for this revision to R239 KDELibs4Support. jonathans updated this revision to Diff 10021. jonathans marked 2 inline comments as done. jonathans added a comment. Restricted Application added a project: Frameworks. Found a couple of places in old code where d->w made

[Differential] [Commented On] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2017-01-10 Thread Jonathan Schultz
jonathans added a comment. Apparently updating the diff has had the side-effect of: > https://phabricator.kde.org/source/kdelibs4support/ KDELibs4Support as the repository for this revision. Please excuse my bumbling - I don't know why that happened or how to repair it. :( REVISIO

[Differential] [Updated, 76 lines] D2075: Fix bug in kfiledialog.cpp that causes crashing when native widgets are used.

2017-01-10 Thread Jonathan Schultz
jonathans removed R239 KDELibs4Support as the repository for this revision. jonathans updated this revision to Diff 10020. jonathans added a comment. Following @kfunk comments, I've changed the patch to test d->w rather than d->native, and used nullptr instead of 0 where appropriate. CHANGES

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 121 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/121/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 10 Jan 2017 23:25:34 + Build duration: 5 min 21 sec CHANGE SET No changes

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 121 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/121/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 10 Jan 2017 23:25:34 + Build duration: 5 min 21 sec CHANGE SET No changes

[Differential] [Commented On] D4072: Bug reporter: Allow a URL (not just as an email address) for custom reporting

2017-01-10 Thread Albert Astals Cid
aacid added a comment. Before this lands you want to propose a patch for kcoreaddons src/lib/kaboutdata.h since the parameter is *clearly* called bugsEmailAddress REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D4072 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Updated] D4060: kio: Ensure user certificate directory has been created before storing certs to it

2017-01-10 Thread Andreas Hartmetz
ahartmetz added a comment. Looks like a stupid mistake on my part, thanks for the fix. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4060 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mpyne, #frameworks, apol, ahartmetz

Re: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-10 Thread René J . V . Bertin
On Sunday January 8 2017 23:47:26 Samuel Gaist wrote: Hi, >https://bugreports.qt.io/browse/QTBUG-57990 is about a similar problem for >Ubuntu. >Coming from this https://forum.qt.io/topic/74872/ forum thread. > >5.7.0 works correctly for him but not 5.7.1 Thanks for this. I added my 2 cents to t

[Differential] [Request, 89 lines] D4072: Bug reporter: Allow a URL (not just as an email address) for custom reporting

2017-01-10 Thread Jonathan Marten
marten created this revision. marten added a reviewer: Frameworks. marten set the repository for this revision to R263 KXmlGui. Restricted Application added a project: Frameworks. REVISION SUMMARY The rather old bug https://bugs.kde.org/show_bug.cgi?id=277142, although raised against KDE4 kdeli

[Differential] [Closed] D4048: Support some of the KNSCore questions using notifications

2017-01-10 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R252:a9c3d38560c0: Support some of the KNSCore questions using notifications (authored by apol). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4048?vs=992

[Differential] [Request, 2 lines] D4065: Don't ask if we're getting the file in /tmp

2017-01-10 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, leinir. Restricted Application added a project: Frameworks. REVISION SUMMARY It just results in an awkward question REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4065 AFFECTED FILES s

[Differential] [Closed] D4063: Only continue if it's what was said

2017-01-10 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R304:8f022e574b02: Only continue if it's what was said (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4063?vs=9964&id=9967 REVISION DETAIL https

[Differential] [Accepted] D4048: Support some of the KNSCore questions using notifications

2017-01-10 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That works, yup :) REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D4048 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Accepted] D4063: Only continue if it's what was said

2017-01-10 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Ah, yes, quite, push away :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4063 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Request, 2 lines] D4063: Only continue if it's what was said

2017-01-10 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, leinir. Restricted Application added a project: Frameworks. REVISION SUMMARY Otherwise an InvalidResponse will make the transaction to proceed REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.or

[Differential] [Accepted] D4060: kio: Ensure user certificate directory has been created before storing certs to it

2017-01-10 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4060 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mpyne, #frameworks, ahartmetz

Jenkins-kde-ci: kjsembed master stable-kf5-qt5 » Linux,gcc - Build # 179 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjsembed%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/179/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:37:16 + Build duration: 4 min 38 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kjsembed master stable-kf5-qt5 » Linux,gcc - Build # 179 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjsembed%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/179/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:37:16 + Build duration: 4 min 38 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 174 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/174/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:29:13 + Build duration: 3 min 56 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 174 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/174/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:29:13 + Build duration: 3 min 56 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 197 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:18:48 + Build duration: 8 min 1 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:18:48 + Build duration: 8 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 197 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:18:48 + Build duration: 8 min 1 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:18:48 + Build duration: 8 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/191/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:16:31 + Build duration: 1 min 50 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 191 - Fixed!

2017-01-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/191/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 10 Jan 2017 09:16:31 + Build duration: 1 min 50 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 120 - Unstable!

2017-01-10 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/120/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 10 Jan 2017 08:49:23 + Build duration: 4 min 21 sec CHANGE SET No changes