Re: Review Request 129741: Add renaming capability to ioslaves

2017-01-06 Thread Elvis Angelaccio
> On Jan. 2, 2017, 9:38 a.m., David Faure wrote: > > Renaming is really a special case of moving. Saying that "kio_trash doesn't > > support renaming" is correct but only a partial truth. It also doesn't > > support moving from trash:/ to trash:/subdir/. So it would be more correct > > to say

Re: CI Requirements - Lessons Not Learnt?

2017-01-06 Thread Scarlett Clark
Hello all, First my apologies, yes the CI system is behind, I had done significant work on a new revamp and then life, work and those other incredibly annoying things got in the way. The CI team is rather small and we are trying our best to move things forward. We are now getting back on track, but

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

2017-01-06 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129694/#review101843 --- Ping? - Elvis Angelaccio On Dec. 22, 2016, 4:56 p.m., Elv

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-06 Thread René J . V . Bertin
On Friday January 06 2017 18:33:01 David Faure wrote: > Well, you didn't say either way, so I tried to guess from your description, > and guessed wrong. No problem, can't be right all the time (and it's Friday night at that) ;) > > the shortcut shows up correctly (Command-<) but doesn't work. >

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 368 - Failure!

2017-01-06 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/368/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:45:32 + Build duration: 3 min 36 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 356 - Still Unstable!

2017-01-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/356/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:35:50 + Build duration: 6 min 37 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 351 - Still Unstable!

2017-01-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/351/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:27:04 + Build duration: 7 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 168 - Fixed!

2017-01-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/168/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:10:33 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed

Jenkins-kde-ci: khtml master kf5-qt5 » Linux,gcc - Build # 168 - Fixed!

2017-01-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/168/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:10:33 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 192 - Fixed!

2017-01-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:10:33 + Build duration: 6 min 24 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 192 - Fixed!

2017-01-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:10:33 + Build duration: 6 min 24 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 184 - Fixed!

2017-01-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/184/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:09:48 + Build duration: 5 min 18 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 184 - Fixed!

2017-01-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/184/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 16:09:48 + Build duration: 5 min 18 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 187 - Still Unstable!

2017-01-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/187/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 15:53:05 + Build duration: 1 min 48 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 128 - Still Unstable!

2017-01-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/128/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 15:42:39 + Build duration: 4 min 52 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 133 - Still Unstable!

2017-01-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/133/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 15:38:32 + Build duration: 4 min 39 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Re: CI Requirements - Lessons Not Learnt?

2017-01-06 Thread David Edmundson
>This was demonstrated earlier this week when components of Plasma bumped their version requirements for XKBCommon and Appstream-Qt FWIW, Appstream-Qt became optional later that same day, because of how new the dependency was. Though obviously it could have been hanlded better. Does anyone have a

Re: CI Requirements - Lessons Not Learnt?

2017-01-06 Thread Ben Cooksley
On Fri, Jan 6, 2017 at 9:52 PM, Martin Gräßlin wrote: > Am 2017-01-06 05:57, schrieb Ben Cooksley: >> >> On Fri, Jan 6, 2017 at 12:38 AM, Martin Gräßlin >> wrote: >>> >>> Am 2017-01-05 11:20, schrieb Ben Cooksley: On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin wrote: > >

Jenkins-kde-ci: kconfig master stable-kf5-qt5 » Linux,gcc - Build # 127 - Unstable!

2017-01-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/127/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 08:59:18 + Build duration: 2 min 42 sec CHANGE SET Revision e0db2422362260a2fea3a8e1de4c64

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 132 - Unstable!

2017-01-06 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/132/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 08:59:18 + Build duration: 1 min 50 sec CHANGE SET Revision e0db2422362260a2fea3a8e1de4c64011d2f1

[Differential] [Closed] D3690: Generate an instance with KSharedConfig::Ptr for singleton and arg

2017-01-06 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R237:e0db24223622: Generate an instance with KSharedConfig::Ptr for singleton and arg (authored by graesslin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3690?vs=904

[Differential] [Accepted] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

2017-01-06 Thread dfaure (David Faure)
dfaure accepted this revision. dfaure added a reviewer: dfaure. dfaure added a comment. This revision is now accepted and ready to land. Change it all. One note about "what is a public header" -- the rule is that any private header (i.e. not installed) is called _p.h The rule isn't 100%

Re: Review Request 129760: Fixup handling of KFontUtils::adaptFontSize's flags' default value.

2017-01-06 Thread Shaheed Haque
> On Jan. 5, 2017, 10:56 p.m., Stephen Kelly wrote: > > I've added the change to the unit test. It already passes, so it's not > > clear to me what else is needed from this review request. > > Shaheed Haque wrote: > What version of SIP compiler and C++ compiler are you using? I'm on: >

Re: CI Requirements - Lessons Not Learnt?

2017-01-06 Thread Martin Gräßlin
Am 2017-01-06 05:57, schrieb Ben Cooksley: On Fri, Jan 6, 2017 at 12:38 AM, Martin Gräßlin wrote: Am 2017-01-05 11:20, schrieb Ben Cooksley: On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin wrote: Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all, It seems that my previous vocal complai

[Differential] [Commented On] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)

2017-01-06 Thread kfunk (Kevin Funk)
kfunk added inline comments. INLINE COMMENTS > graesslin wrote in job.h:50 > Question: is this change API and ABI stable? Definitely ABI stable, since default arguments are not part of the function signature. I'm not aware this could break API compat either (well, only in case the compiler co