Re: Minimum required cmake version

2017-01-01 Thread Aleix Pol
On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne wrote: > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote: >> Hey, >> >> On 27/12/16 19:30, Aleix Pol wrote: >> > +1 on changing to 3.0. >> Thanks for your opinion on the matter. I also think we should just bump >> it, 3.0 is old enough -- a

[Differential] [Updated] D3912: kdoctools_install: match the full path for the program

2017-01-01 Thread ltoscano (Luigi Toscano)
ltoscano added a reviewer: Frameworks. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D3912 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, #documentation, #frameworks

Review Request 129741: Add renaming capability to ioslaves

2017-01-01 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129741/ --- Review request for KDE Frameworks, David Faure and Emmanuel Pescosta. Rep

Review Request 129742: Add option FORCE_ENABLE_HUNSPELL

2017-01-01 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129742/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 129648: New widget: tooltip that contains another widget

2017-01-01 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Jan. 1, 2017, 4:56 p.m.) Status -- This change has been mar

Re: Review Request 129648: New widget: tooltip that contains another widget

2017-01-01 Thread Elvis Angelaccio
> On Jan. 1, 2017, 3:25 p.m., Martin Gräßlin wrote: > > Looks good to me. Using the transientParent's qscreen was what I meant. Thanks, I'm going to commit then. :) - Elvis --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 129648: New widget: tooltip that contains another widget

2017-01-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101699 --- Looks good to me. Using the transientParent's qscreen was wh

Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

2017-01-01 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/ --- (Updated Jan. 1, 2017, 12:48 p.m.) Status -- This change has been di

Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

2017-01-01 Thread David Faure
> On Jan. 1, 2017, 11:02 a.m., David Faure wrote: > > I'd rather fix KIO::symlink, which is advertised to support Overwrite. > > > > Unittests and fix coming up. > > Chinmoy Ranjan Pradhan wrote: > Overwrite in KIO::symlink works fine. It's the 'desktop' protocol that > causes the error, s

Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

2017-01-01 Thread Chinmoy Ranjan Pradhan
> On Jan. 1, 2017, 11:02 a.m., David Faure wrote: > > I'd rather fix KIO::symlink, which is advertised to support Overwrite. > > > > Unittests and fix coming up. Overwrite in KIO::symlink works fine. It's the 'desktop' protocol that causes the error, so I used KIO::link which resolves desktop:

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

2017-01-01 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129665/#review101696 --- ping - Anthony Fieroni On Дек. 18, 2016, 9:55 след обяд,

Re: Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

2017-01-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/#review101695 --- I'd rather fix KIO::symlink, which is advertised to support

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

2017-01-01 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review101693 --- ping - Anthony Fieroni On Дек. 29, 2016, 9:17 преди обяд,

Review Request 129737: [kio] Error when changing target of symlink in plasma folder view

2017-01-01 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129737/ --- Review request for KDE Frameworks and David Faure. Bugs: 360487 https