[Differential] [Closed] D3860: appstreamtest: handle non-installed programs

This revision was automatically updated to reflect the committed changes. Closed by commit R240:5ed7ba07e4f3: appstreamtest: handle non-installed programs (authored by ervin). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3860?vs=9459&id=9477 REV

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote: > > Is that enabled by default now? I hope not! This is a completely useless > > warning for all frameworks (as we are not allowed to use override) and even > > more for a legacy code bases. I don't want to have to adjust the cmake in > > al

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101664 --- Is that enabled by default now? I hope not! This is a comple

Re: Review Request 129648: New widget: tooltip that contains another widget

> On Dec. 29, 2016, 5:01 p.m., Martin Gräßlin wrote: > > src/ktooltipwidget.cpp, line 101 > > > > > > this won't work on Wayland, there is no global cursor pos. > > Elvis Angelaccio wrote: > hmm, not sure w

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 357 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/357/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 04:38:33 + Build duration: 5 min 51 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 358 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/358/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 04:27:34 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 169 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/169/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 03:49:37 + Build duration: 1 min 48 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 169 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/169/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 03:49:37 + Build duration: 1 min 48 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 357 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/357/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 00:56:27 + Build duration: 1 min 1 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 356 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/356/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 00:54:27 + Build duration: 1 min 0 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 329 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/329/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 00:46:02 + Build duration: 6 min 10 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 329 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/329/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 00:46:02 + Build duration: 6 min 10 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 168 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/168/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 30 Dec 2016 00:16:08 + Build duration: 1 min 51 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/ --- (Updated Dec. 29, 2016, 11:48 p.m.) Status -- This change has been m

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/#review101662 --- Ship it! LGTM, and the Clang equivalent (-Winconsistent-m

Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/ --- Review request for Build System and KDE Frameworks. Repository: extra-cma

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/ --- (Updated Dec. 29, 2016, 11:01 p.m.) Review request for KDE Frameworks.

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

> On Dec. 29, 2016, 9:24 a.m., David Faure wrote: > > src/kstandardaction.cpp, line 199 > > > > > > If an application creates many "show menu bar" actions, e.g. one per > > window in a many-windows process, then

Review Request 129723: Call the new checkAmbiguousShortcuts() from MainWindow::createShellGUI

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129723/ --- Review request for KDE Frameworks. Repository: kparts Description -

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

rakuco added a comment. Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 355 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Dec 2016 22:15:34 + Build duration: 5 min 48 sec CHANGE SET Revision 53af6f9e0ecc646df

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 356 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/356/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Dec 2016 22:15:34 + Build duration: 59 sec CHANGE SET Revision 53af6f9e0ecc646df4d11582bd45a2

Re: Review Request 129715: KPackage KNSHandler: Improve

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129715/ --- (Updated Dec. 29, 2016, 11:15 p.m.) Status -- This change has been m

[Differential] [Accepted] D3860: appstreamtest: handle non-installed programs

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3860 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ervin, #frameworks, apol

[Differential] [Closed] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

This revision was automatically updated to reflect the committed changes. Closed by commit R268:4ea7687b11ec: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable (authored by graesslin). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3689?vs=9044&id

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 328 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/328/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Dec 2016 17:43:01 + Build duration: 8 min 19 sec CHANGE SET No changes JUNIT RESULTS Name: (root) F

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/ --- (Updated Dec. 29, 2016, 5:31 p.m.) Status -- This change has been ma

Re: Review Request 129648: New widget: tooltip that contains another widget

> On Dec. 29, 2016, 4:01 p.m., Martin Gräßlin wrote: > > src/ktooltipwidget.cpp, line 101 > > > > > > this won't work on Wayland, there is no global cursor pos. hmm, not sure what to use instead. `rect`? Or may

Re: Review Request 129648: New widget: tooltip that contains another widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101652 --- src/ktooltipwidget.cpp (line 101)

[Differential] [Updated, 10 lines] D3860: appstreamtest: handle non-installed programs

ervin updated this revision to Diff 9459. ervin added a comment. Of course, I notice just now I got the order of the parameters wrong. Now properly working both with and without install_manifest.txt in the build directory. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Request, 10 lines] D3860: appstreamtest: handle non-installed programs

ervin created this revision. ervin added reviewers: Frameworks, apol. REVISION SUMMARY If you just built the software without installing it and then run ctest, this will systematically fail while trying to read install_manifest.txt. With this patch this case is now handled gracefully, not fo

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 327 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/327/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Dec 2016 13:01:01 + Build duration: 9 min 4 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

ltoscano added a reviewer: Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ivan, #buildsystem Cc: elvisangelaccio

Re: Scrap Baloo Thread Feedback

Hi all, CC: plasma-devel, due to stability issues On Fri, Oct 7, 2016 at 5:56 PM, Christoph Cullmann wrote: > Hi, > [...] > Actually, the bugs.kde.org page tells you the facts: The bug number > was constant increasing since > 1 year. The thread lists some other facts > what is wrong ATM and shou

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 164 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Dec 2016 11:55:15 + Build duration: 3 min 2 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 164 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/164/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Dec 2016 11:55:15 + Build duration: 3 min 2 sec CHANGE SET No changes JUNIT RESULTS Name

Re: Review Request 129715: KPackage KNSHandler: Improve

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129715/#review101651 --- Ship it! Ship It! - Marco Martin On Dec. 28, 2016, 4:3

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... Hmm... You cou

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

elvisangelaccio added a comment. What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like and use them whenever I start something from scratch... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: ivan. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks, ivan

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

kfunk added a comment. Note: Just refreshing my complete KF5 build to test the change. kactivities fails: /home/kfunk/devel/src/kf5/kactivities/autotests/common/test.h:143:25: error: token is not a valid binary operator in a preprocessor subexpression #if defined(Q_NO_DEBUG) or

[Differential] [Updated] D3850: Pass -fno-operator-names when supported

kfunk added a reviewer: Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Closed] D3733: Force colored warnings in ninja's output

This revision was automatically updated to reflect the committed changes. Closed by commit R240:dc525a42ae70: Enable colored warnings in ninja's output (authored by elvisangelaccio). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3733?vs=9437&id=94

[Differential] [Accepted] D3733: Force colored warnings in ninja's output

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R240 Extra CMake Modules BRANCH ninja-colors REVISION DETAIL https://phabricator.kde.org/D3733 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Updated, 8 lines] D3733: Force colored warnings in ninja's output

elvisangelaccio updated this revision to Diff 9437. elvisangelaccio added a comment. - Add color switch only if the generator is Ninja REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3733?vs=9169&id=9437 BRANCH ninja-colors REVISION DETAIL

Re: Review Request 129648: New widget: tooltip that contains another widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Dec. 29, 2016, 10:11 a.m.) Review request for KDE Frameworks, Be

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review101641 --- src/kstandardaction.cpp (line 84)

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review101640 --- Fix it, then Ship it! Looks good (will need a call from K

[Differential] [Updated] D3548: Add begin/end insert/remove columns to RearrangeColumns

dfaure added a comment. Can you add a unittest too? This class is fully unittested in krearrangecolumnsproxymodeltest.cpp, it's just that changing the source columns configuration "at runtime" wasn't supported. Just add one more test method, with spies for the signals you emit. Thanks!

[Differential] [Requested Changes To] D3733: Force colored warnings in ninja's output

kfunk requested changes to this revision. kfunk added a reviewer: kfunk. kfunk added a comment. This revision now requires changes to proceed. This flag is only needed for Ninja, correct? Thus please check for Ninja in `CMAKE_GENERATOR ` before adding the compiler flag. REPOSITORY R240 Extr

[Differential] [Updated] D3548: Add begin/end insert/remove columns to RearrangeColumns

kfunk added a reviewer: dfaure. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lepagevalleeemmanuel, #frameworks, dfaure Cc: kfunk, ltoscano

[Differential] [Changed Subscribers] D3548: Add begin/end insert/remove columns to RearrangeColumns

kfunk added inline comments. INLINE COMMENTS > krearrangecolumnsproxymodel.cpp:44 > + > +const int cc = d_ptr->m_sourceColumns.size(); > + Please no short hand variable names. `cc` -> `sourceColCount`? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAI