Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 320 - Unstable!

2016-12-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/320/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Dec 2016 04:52:11 + Build duration: 21 min CHANGE SET Revision 5107ca8a1ba35dd549a1beedb0a4b931a53f7f17 by scr

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 324 - Fixed!

2016-12-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/324/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Dec 2016 04:52:11 + Build duration: 10 min CHANGE SET Revision 5107ca8a1ba35dd549a1beedb0a4b931a53f7f17

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 324 - Fixed!

2016-12-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/324/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Dec 2016 04:52:11 + Build duration: 10 min CHANGE SET Revision 5107ca8a1ba35dd549a1beedb0a4b931a53f7f17

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 162 - Unstable!

2016-12-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/162/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Dec 2016 02:44:40 + Build duration: 2 min 23 sec CHANGE SET No changes JUNIT RESULTS Na

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 165 - Unstable!

2016-12-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/165/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Dec 2016 02:43:40 + Build duration: 2 min 5 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Re: Review Request 128672: some fixes for javascript Math object

2016-12-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128672/#review101544 --- > The implementations were tested although. Could you share

[Differential] [Commented On] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

2016-12-21 Thread aacid (Albert Astals Cid)
aacid added a comment. > We can adjust the shortcuts without having side effects on other tests. Why not just delete the test file on start of each test? REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Dec. 21, 2016, 6:43 p.m.) Review request for KDE Frameworks, Ben

[Differential] [Commented On] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

2016-12-21 Thread Martin Gräßlin
graesslin added a comment. ping REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101542 --- Fix it, then Ship it! That's it from my side. src/ktool

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Dec. 21, 2016, 5:57 p.m.) Review request for KDE Frameworks, Ben

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101540 --- src/ktooltipwidget.cpp (line 48)

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
> On Dec. 21, 2016, 5:23 p.m., Christoph Feck wrote: > > src/ktooltipwidget.cpp, line 94 > > > > > > 'auto' is C++11, too (if used as a type). Please use explicit types > > here. > > > > Especially with

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Dec. 21, 2016, 5:29 p.m.) Review request for KDE Frameworks and

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Christoph Feck
> On Dec. 21, 2016, 5 p.m., Christoph Feck wrote: > > src/ktooltipwidget.h, line 72 > > > > > > I am not a native english speaker, but I think 'showBelow' sounds > > better. > > > > Needs a comment from

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101538 --- src/ktooltipwidget.cpp (line 94)

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Dec. 21, 2016, 5:19 p.m.) Review request for KDE Frameworks, Ben

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
> On Dec. 21, 2016, 4 p.m., Christoph Feck wrote: > > src/ktooltipwidget.h, line 72 > > > > > > I am not a native english speaker, but I think 'showBelow' sounds > > better. > > > > Needs a comment from

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/ --- (Updated Dec. 21, 2016, 5:01 p.m.) Review request for KDE Frameworks, Ben

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Elvis Angelaccio
> On Dec. 21, 2016, 4 p.m., Christoph Feck wrote: > > Looks good so far, but see issues below. Please do not use C++11 features > > in library code yet (it's okey for tests). > > > > Regarding the 500 ms timeout, does it need to be configurable using a > > property? I am unsure how the interac

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101534 --- Looks good so far, but see issues below. Please do not use C

Re: Please cleanup your scratch and clone repositories

2016-12-21 Thread Tomaz Canabrava
Done. On Sun, Nov 27, 2016 at 9:39 AM, Ben Cooksley wrote: > On Sat, Nov 26, 2016 at 7:53 AM, Ben Cooksley wrote: > > Hi all, > > Hi all, > > > > > To help Sysadmin assess how these types of repositories would be used > > under Phabricator, it would be appreciated if everyone could please > > c

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 323 - Unstable!

2016-12-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/323/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Dec 2016 08:33:06 + Build duration: 7 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 387 - Still Unstable!

2016-12-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/387/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Dec 2016 07:38:30 + Build duration: 2 min 57 sec CHANGE SET No changes JUNIT RESULTS