Re: Review Request 129617: Restore the "Embeddable Image Viewer" provided by KHTML

2016-12-05 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129617/ --- (Updated Dec. 6, 2016, 6:53 a.m.) Status -- This change has been mar

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Anthony Fieroni
> On Дек. 3, 2016, 6:48 след обяд, Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context,

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Lamarque Souza
> On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context, but "

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Martin Klapetek
> On Dec. 3, 2016, 5:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. > > Thomas Pfeiffer wrote: > Hm, "Using" sounds a bit weird without context, but "

Re: Review Request 129607: Display Application version in About dialog header

2016-12-05 Thread Thomas Pfeiffer
> On Dec. 3, 2016, 4:48 p.m., Martin Klapetek wrote: > > How about "Using" for the title of the tab and then removing the "Using" > > label from inside the tab? > > > > Also, +1 to putting the version front. Hm, "Using" sounds a bit weird without context, but "Libraries" or maybe "Libraries u

Re: Review Request 129540: DropJob: emit started copy job after creation

2016-12-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129540/#review101307 --- Ship it! Ship It! - David Faure On déc. 5, 2016, 4:37

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101305 --- I just saw "When is fixed new kio-extras realease is needed

Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-05 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/ --- Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanu

Re: Review Request 129617: Restore the "Embeddable Image Viewer" provided by KHTML

2016-12-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129617/#review101303 --- Ship it! Ship It! - Albert Astals Cid On Dec. 5, 2016,

[Differential] [Updated, 37 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8792. kossebau added a comment. update to latest ECMAddQch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8589&id=8792 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWi

[Differential] [Updated, 34 lines] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8791. kossebau added a comment. update to latest ECMAddQch REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=8588&id=8791 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3438 AFFECTED FI

[Differential] [Updated, 35 lines] D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8789. kossebau added a comment. update to latest ECMAddQch REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=8590&id=8789 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3458 AFFECTED FILES

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau retitled this revision from "New: ECMAddQCH, for generating qch & doxygen tag files" to "New: ECMAddQch, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVIS

[Differential] [Updated, 1,178 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

2016-12-05 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 8783. kossebau added a comment. s/QCH/Qch/, use find_oackage for needed tools, more control over output REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8639&id=8783 BRANCH addApiDox REVISION DETA

Re: Review Request 129540: DropJob: emit started copy job after creation

2016-12-05 Thread Alex Bikadorov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129540/ --- (Updated Dec. 5, 2016, 4:37 p.m.) Review request for KDE Frameworks. Ch

Review Request 129617: Restore the "Embeddable Image Viewer" provided by KHTML

2016-12-05 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129617/ --- Review request for KDE Frameworks and David Faure. Repository: khtml De

Re: Problems managing KIO::Jobs

2016-12-05 Thread A. Bikadorov
On 04.12.2016 10:58, David Faure wrote: > Indeed suspend() before starting wasn't implemented. It was only used > internally for the bitburger protocol in CopyJob. > > I have now at least implemented suspend()-before-start() in SimpleJob > and FileCopyJob, in > https://commits.kde.org/kio/91fd82c

Re: Review Request 129588: http slave: add newlines to long error message

2016-12-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129588/#review101296 --- Ship it! Ship It! - Sebastian Kügler On Nov. 29, 2016,

Re: Review Request 129540: DropJob: emit started copy job after creation

2016-12-05 Thread David Faure
> On Dec. 4, 2016, 5:50 p.m., David Faure wrote: > > I would prefer the subjob to remain an implementation detail. Just like so > > many other KIO jobs which use other jobs internally. > > > > Instead this code should connect the signals from the subjob to the DropJob > > signals. Much like Fi

Re: Review Request 129540: DropJob: emit started copy job after creation

2016-12-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129540/#review101295 --- Missing: QSignalSpy in dropjobtest to double-check that the

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 297 - Fixed!

2016-12-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/297/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 05 Dec 2016 08:33:26 + Build duration: 5 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 297 - Fixed!

2016-12-05 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/297/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 05 Dec 2016 08:33:26 + Build duration: 5 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa