[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added a comment. And I meant this line: https://code.woboq.org/qt5/qtbase/src/corelib/io/qfsfileengine_win.cpp.html#547 (Woboq bug..., can't link the Windows version of `QFSFileEngine::drivers()`...) BRANCH master REVISION DETAIL https://phabricator.kde.org/D3392 EMAIL PREFERENCE

[Differential] [Accepted] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread brauch (Sven Brauch)
brauch accepted this revision. brauch added a comment. This revision is now accepted and ready to land. Ok then, even if it breaks on WinXP occasionally, I guess the impact is negligible. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3392 EMAIL PREFERENCES https://phabric

[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D3392#63341, @brauch wrote: > Hm, there is at least one race condition here: thread A does old = ::SetErrorMode(...), then if before it resets it thread B does the same, then the old mode might never be restored. We can put a mutex bu

[Differential] [Updated] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread brauch (Sven Brauch)
brauch added a comment. Hm, there is at least one race condition here: thread A does old = ::SetErrorMode(...), then if before it resets it thread B does the same, then the old mode might never be restored. We can put a mutex but of course there might be another piece of code which does the

[Differential] [Updated] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added reviewers: brauch, Frameworks. REVISION DETAIL https://phabricator.kde.org/D3392 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, brauch, #frameworks

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 21:06:19 + Build duration: 7 min 2 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 21:06:19 + Build duration: 7 min 2 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 275 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 21:04:09 + Build duration: 7 min 22 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 275 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 21:04:09 + Build duration: 7 min 22 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Fa

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 145 - Still Unstable!

2016-11-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 20:42:11 + Build duration: 5 min 53 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-16 Thread Anthony Fieroni
> On Ноев. 15, 2016, 6:40 след обяд, David Faure wrote: > > This fix makes sense to me (well, I suggested it) ;) > > > > As to why it doesn't work, that requires more info about how filenamesearch > > URLs are actually being used. Is this documented somewhere, or does it > > require testing an

Re: Send Email with attachment with my Qt Application

2016-11-16 Thread Christoph Feck
On 16.11.2016 19:58, Boudhayan Gupta wrote: KService, and all of KDE software written in C++/Qt, are configured with CMake and not QMake. There's no .pro files, but CMakeLists.txt files. This is not true. KDE Frameworks support both qmake and cmake. On the API pages, the required instructions f

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-11-16 Thread Anthony Fieroni
> On Ноев. 15, 2016, 6:40 след обяд, David Faure wrote: > > This fix makes sense to me (well, I suggested it) ;) > > > > As to why it doesn't work, that requires more info about how filenamesearch > > URLs are actually being used. Is this documented somewhere, or does it > > require testing an

Re: Send Email with attachment with my Qt Application

2016-11-16 Thread Boudhayan Gupta
Hi Charles-Elie, KService, and all of KDE software written in C++/Qt, are configured with CMake and not QMake. There's no .pro files, but CMakeLists.txt files. You'll need to install CMake, and build by doing: cd /path/to/sources cmake . make && sudo make install Hope this helps. Thanks, Boudha

Re: Send Email with attachment with my Qt Application

2016-11-16 Thread Charles-Elie Gentil
In fact I did not understand how to build KService, but I think I have found: I probably have to create the .pro file myself. For the direct use of invokMailer, I have already tried but I can not use ShellExecute on my Mac. But I will try again. Best regards, Charlie m...@jiyuusoft.net http:/

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-11-16 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review100891 --- Ping, i'm still using it without issues, it isn't good enoug

Re: Review Request 129418: Adjust directory structure to Frameworks policies

2016-11-16 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129418/ --- (Updated Nov. 16, 2016, 6:55 p.m.) Status -- This change has been ma

Re: Review Request 129417: Add metainfo.yaml

2016-11-16 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129417/ --- (Updated Nov. 16, 2016, 5:55 p.m.) Status -- This change has been ma

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 17:31:12 + Build duration: 8 min 40 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 17:31:12 + Build duration: 8 min 40 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 279 - Unstable!

2016-11-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/279/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 17:12:02 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 274 - Still Unstable!

2016-11-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/274/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 17:13:48 + Build duration: 10 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Re: Review Request 129418: Adjust directory structure to Frameworks policies

2016-11-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129418/#review100889 --- Ship it! LGTM - Aleix Pol Gonzalez On Nov. 16, 2016, 6

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 144 - Unstable!

2016-11-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/144/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 16:52:39 + Build duration: 6 min 48 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Re: Review Request 129417: Add metainfo.yaml

2016-11-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129417/#review100888 --- Ship it! yay, great to see these points getting addressed

Review Request 129417: Add metainfo.yaml

2016-11-16 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129417/ --- Review request for KDE Frameworks and Sune Vuorela. Repository: prison

Review Request 129418: Adjust directory structure to Frameworks policies

2016-11-16 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129418/ --- Review request for KDE Frameworks and Sune Vuorela. Repository: prison

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/ --- (Updated Nov. 16, 2016, 4:41 p.m.) Status -- This change has been ma

Re: Send Email with attachment with my Qt Application

2016-11-16 Thread Charles-Elie Gentil
Hello, I try this solution with mailto, but adding attachment don’t work with this command Best regards, Charlie m...@jiyuusoft.net http://blog.jiyuusoft.net > Le 16 nov. 2016 à 17:18, David Edmundson a écrit > : > > > ​You can just use QDesktopServices::openUrl() with a mailto: URL. > >

Re: Send Email with attachment with my Qt Application

2016-11-16 Thread David Edmundson
Sorry, didn't read that second line properly about attachments properly. What error do you get when buildling kservice? You may find this tool that builds dependencies useful: https://inqlude.org. Alternatively, you can probably just extract this one invokeMailer here: https://api.kde.org/framew

Re: Send Email with attachment with my Qt Application

2016-11-16 Thread David Edmundson
​You can just use QDesktopServices::openUrl() with a mailto: URL. http://doc.qt.io/qt-5/qdesktopservices.html#openUrl David

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/#review100887 --- Ship it! Ship It! - Christoph Feck On Nov. 16, 2016, 5

[Differential] [Updated, 194 lines] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-11-16 Thread Martin Gräßlin
graesslin updated this revision to Diff 8228. graesslin added a comment. Added a test case CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3386?vs=8220&id=8228 BRANCH kconfigcompiler-instance-ksharedconfig REVISION DETAIL https://phabricator.kde.org/D3386 AFFECTED FILES autot

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/ --- (Updated Nov. 16, 2016, 4:11 p.m.) Review request for KDE Frameworks and

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Heiko Tietze
> On Nov. 16, 2016, 1:10 nachm., Christoph Feck wrote: > > Could you add a screen shot that shows actually wrapped text? > > Christoph Feck wrote: > Thanks, so the close icon is vertically centered. > > Heiko, do you agree that the close icon would look better if it was also > top-

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Elvis Angelaccio
> On Nov. 16, 2016, 1:10 p.m., Christoph Feck wrote: > > Could you add a screen shot that shows actually wrapped text? > > Christoph Feck wrote: > Thanks, so the close icon is vertically centered. > > Heiko, do you agree that the close icon would look better if it was also > top-al

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Heiko Tietze
> On Nov. 16, 2016, 1:10 nachm., Christoph Feck wrote: > > Could you add a screen shot that shows actually wrapped text? > > Christoph Feck wrote: > Thanks, so the close icon is vertically centered. > > Heiko, do you agree that the close icon would look better if it was also > top-

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-11-16 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Then please include a test with your new feature. REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks Cc: apol

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-11-16 Thread Martin Gräßlin
graesslin added a comment. Just checked: the only test with a combination of arg="true" and singleton is signals_test_singleton.kcfgc which is used by kconfigcompiler_test_signals.cpp, but there is no code comparison in that test. The only other arg="true" case is test8a.kcfg, but that o

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-11-16 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3386#63201, @apol wrote: > How can tests still pass? they compare the generated code. eh no idea. I did a make clean, make, make test in the folder. Maybe there is no test for the singleton + arg="true" combination? REVIS

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-11-16 Thread apol (Aleix Pol Gonzalez)
apol added a comment. How can tests still pass? they compare the generated code. REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks Cc: apol

Send Email with attachment with my Qt Application

2016-11-16 Thread Charles-Elie Gentil
Hi, I work on a Qt application with which I have to send an email with an attachment. I want use the native client of device. Unfortunately, mailto can’t send attachment. Also I have looking the source code of Calligra and it seem that it would be possible to use KToolInvocation::invokMailer.

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Christoph Feck
> On Nov. 16, 2016, 2:10 p.m., Christoph Feck wrote: > > Could you add a screen shot that shows actually wrapped text? Thanks, so the close icon is vertically centered. Heiko, do you agree that the close icon would look better if it was also top-aligned like the message icon? - Christoph -

[Differential] [Request, 33 lines] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-11-16 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Frameworks. REVISION SUMMARY In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 293 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/293/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:51:53 + Build duration: 5 min 51 sec CHANGE SET Revision 7a644d7147edb816b69fa973630cea6aa72b

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 293 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/293/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:51:53 + Build duration: 5 min 51 sec CHANGE SET Revision 7a644d7147edb816b69fa973630cea6aa72b

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 298 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/298/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:51:53 + Build duration: 1 min 26 sec CHANGE SET Revision 7a644d7147edb816b69fa973630ce

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 298 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/298/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:51:53 + Build duration: 1 min 26 sec CHANGE SET Revision 7a644d7147edb816b69fa973630ce

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/ --- (Updated Nov. 16, 2016, 1:47 p.m.) Review request for KDE Frameworks, KDE

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 297 - Failure!

2016-11-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/297/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:40:23 + Build duration: 32 sec CHANGE SET Revision 4f6f543fd19d79f91fbf77c5fa88dc45e7d

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 292 - Failure!

2016-11-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/292/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:40:23 + Build duration: 34 sec CHANGE SET Revision 4f6f543fd19d79f91fbf77c5fa88dc45e7d5ab99 b

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 296 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/296/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:28:56 + Build duration: 7 min 8 sec CHANGE SET Revision 11dc09fae3b99b018db29136d5e59c

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 291 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/291/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:28:56 + Build duration: 7 min 14 sec CHANGE SET Revision 11dc09fae3b99b018db29136d5e59ce4896f

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 291 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/291/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:28:56 + Build duration: 7 min 14 sec CHANGE SET Revision 11dc09fae3b99b018db29136d5e59ce4896f

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 296 - Fixed!

2016-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/296/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:28:56 + Build duration: 7 min 8 sec CHANGE SET Revision 11dc09fae3b99b018db29136d5e59c

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 389 - Unstable!

2016-11-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/389/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 12:57:06 + Build duration: 26 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 295 - Failure!

2016-11-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/295/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:09:37 + Build duration: 6 min 40 sec CHANGE SET Revision 29e1276039878c52fa331862deb25

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 290 - Failure!

2016-11-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/290/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 13:09:38 + Build duration: 28 sec CHANGE SET Revision 29e1276039878c52fa331862deb259c75908ab5c b

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/#review100879 --- Could you add a screen shot that shows actually wrapped text

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

2016-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/ --- (Updated Nov. 16, 2016, 12:50 p.m.) Review request for KDE Frameworks.

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 273 - Still Unstable!

2016-11-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/273/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 12:32:33 + Build duration: 16 min CHANGE SET Revision d1c652aa68d0b891f7f9c4fe664e0d3cbdb133af by elv

Re: Review Request 129415: Allow uppercase checksums matching in Checksums tab

2016-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129415/ --- (Updated Nov. 16, 2016, 12:32 p.m.) Status -- This change has been m

Re: Review Request 129415: Allow uppercase checksums matching in Checksums tab

2016-11-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129415/#review100878 --- Ship it! Ship It! - David Faure On Nov. 16, 2016, noon

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/#review100877 --- Ship it! Ship It! - Heiko Tietze On Nov. 16, 2016, 11:

Re: python binding's __init__.py

2016-11-16 Thread Harald Sitter
On Tue, Nov 15, 2016 at 4:04 PM, Stephen Kelly wrote: > Harald Sitter wrote: > >> Alohas >> >> I am currently trying to package kitemmodels' python bindings. The >> module generator installs >> >> -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py >> -./usr/lib/python2.7/dist-packages/PyKF5/KIte

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

2016-11-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/#review100876 --- src/krecentfilesaction.h (line 147)

Review Request 129415: Allow uppercase checksums matching in Checksums tab

2016-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129415/ --- Review request for KDE Frameworks and David Faure. Bugs: 372518 https

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

2016-11-16 Thread Elvis Angelaccio
> On Nov. 14, 2016, 11:22 p.m., Aleix Pol Gonzalez wrote: > > src/krecentfilesaction.h, line 146 > > > > > > How about this? > > ``` > > /** > > * Adds a URL to the recent files list. > >

Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

2016-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129414/ --- Review request for KDE Frameworks, KDE Usability and Christoph Feck. Repo

KService cmake fails on Windows with BUILD_TESTING enabled

2016-11-16 Thread Cordylus Interneter
I was able to cmake KService on Windows XP only with -DBUILD_TESTING=0, otherwise during cmake I get: CMake Error at autotests/CMakeLists.txt:37 (file): file COPY cannot find "D:/KDE/kservice-5.28.0/autotests/fakeplugin.desktop". CMake Error at autotests/CMakeLists.txt:38 (file): file RE

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 272 - Unstable!

2016-11-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/272/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Nov 2016 08:11:07 + Build duration: 22 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

2016-11-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129397/#review100871 --- Ship it! Ship It! - David Faure On Nov. 16, 2016, 7:32