[Differential] [Request, 13 lines] D3315: We don't need to iterate through paths

apol created this revision. apol added reviewers: Frameworks, winterz, mart. REVISION SUMMARY ::filePath will do what it has to do Thanks to Allen Winter for pointing it out TEST PLAN tests pass, projects still compile without complaining BRANCH master REVISION DETAIL https://phabr

[Differential] [Request, 4 lines] D3314: Properly test environment variable

apol created this revision. apol added a reviewer: Frameworks. REVISION SUMMARY use qEnvironmentVariableIsSet instead of qgetenv().isEmpty() BRANCH master REVISION DETAIL https://phabricator.kde.org/D3314 AFFECTED FILES src/core/ksharedconfig.cpp EMAIL PREFERENCES https://phabricator

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129327/#review100732 --- It's weird that it's called `desktopFileName` but it doesn't

Re: Review Request 129362: [KWindowInfo] Add pid()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129362/#review100731 --- You cannot add a virtual method. You need to do an extension

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129209/ --- (Updated Nov. 8, 2016, 5:15 p.m.) Status -- This change has been mar

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100729 --- Doesn't help me on Fedora 24 though (yes, I know this is abo

[Differential] [Closed] D3299: Let KPackage know about X-Plasma-RootPath

apol closed this revision. REVISION DETAIL https://phabricator.kde.org/D3299 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, lbeltrame, mart

[Differential] [Updated] D3299: Let KPackage know about X-Plasma-RootPath

apol added a dependent revision: D3311: Dependency resolution code was moved to KPackagDependency resolution code was moved to KPackagee. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3299 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apo

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/ --- (Updated Nov. 8, 2016, 1:08 p.m.) Status -- This change has been mar

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is actually

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is actually

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is actually

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is actually

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is actually

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100717 --- Ship it! Ship It! - Jonathan Riddell On Nov. 7, 2016,

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote: > > On my system (ubuntu 16.04 base) this is achieved by > > ${KDE_INSTALL_FULL_LIBDIR}/utempter > > What's changed in 16.10 that alters this? > > Albert Astals Cid wrote: > That only works under the bogus assumption that one will i

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

> On Nov. 8, 2016, 11:57 a.m., Anthony Fieroni wrote: > > cmake/FindUTEMPTER.cmake, line 43 > > > > > > I think we shouldn't search in fixed path i.e. /usr/... > > ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCH

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote: > > On my system (ubuntu 16.04 base) this is achieved by > > ${KDE_INSTALL_FULL_LIBDIR}/utempter > > What's changed in 16.10 that alters this? That only works under the bogus assumption that one will install KDE (what does "installing

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100712 --- cmake/FindUTEMPTER.cmake (line 43)

Review Request 129362: [KWindowInfo] Add pid()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129362/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindow

[Differential] [Accepted] D3299: Let KPackage know about X-Plasma-RootPath

mart accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3299 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, lbeltrame, mart

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

> On Nov. 6, 2016, 9:49 a.m., David Faure wrote: > > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 > > should now be @since 5.29 (which is good because the translators have one > > month to translate all these new strings). > > > > Neither ATime nor CTime is actually

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129361/#review100710 --- On my system (ubuntu 16.04 base) this is achieved by ${

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 242 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/242/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 08 Nov 2016 09:54:31 + Build duration: 3 min 18 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 242 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/242/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 08 Nov 2016 09:54:31 + Build duration: 3 min 18 sec CHANGE SET